superreview requested: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1

Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item
don't display properly
https://bugzilla.mozilla.org/show_bug.cgi?id=300474

Attachment 189490: Patch rev. 1
https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit

------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net>
These two changes are not needed to fix this bug:
Removed an unused parameter from GetMaxOptionHeight().
Make sure GetNumberOfOptions() assigns the out parameter even if it fails.
0
bugzilla
7/15/2005 11:46:15 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
546 Views

Similar Articles

[PageSpeed] 28

Reply:

Similar Artilces:

superreview granted: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: layout/forms/nsListControlFrame.cpp >+ nsIPresShell* shell = aPresContext->GetPresShell(); I thi...

superreview requested: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The problem is that "if (aDesiredSize.width > dropdownDesiredSize.width)" is false so we never do the second...

superreview granted: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Looks reasonable. Watch Tp carefully, though! ...

superreview requested: [Bug 277724] <select> and <textarea> don't restore disabled state : [Attachment 245370] Fix
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 277724: <select> and <textarea> don't restore disabled state https://bugzilla.mozilla.org/show_bug.cgi?id=277724 Attachment 245370: Fix https://bugzilla.mozilla.org/attachment.cgi?id=245370&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> I found that <button> doesn't restore disabled state either while doing this... ...

superreview requested: [Bug 342035] Expose all display:block elements via nsIAccessibleText : [Attachment 226786] But don't create for <body> or root element such as <html> or <window>, they are redun #2
Aaron Leventhal <aaronleventhal@moonset.net> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 342035: Expose all display:block elements via nsIAccessibleText https://bugzilla.mozilla.org/show_bug.cgi?id=342035 Attachment 226786: But don't create for <body> or root element such as <html> or <window>, they are redundant with nsDocAccessible created for doc node https://bugzilla.mozilla.org/attachment.cgi?id=226786&action=edit ...

superreview requested: [Bug 342035] Expose all display:block elements via nsIAccessibleText : [Attachment 226786] But don't create for <body> or root element such as <html> or <window>, they are redun #3
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 342035: Expose all display:block elements via nsIAccessibleText https://bugzilla.mozilla.org/show_bug.cgi?id=342035 Attachment 226786: But don't create for <body> or root element such as <html> or <window>, they are redundant with nsDocAccessible created for doc node https://bugzilla.mozilla.org/attachment.cgi?id=226786&action=edit ...

superreview requested: [Bug 313419] Don't kill <area>s outside <map>s : [Attachment 200470] Patch to fix
Jonas Sicking <bugmail@sicking.cc> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 313419: Don't kill <area>s outside <map>s https://bugzilla.mozilla.org/show_bug.cgi?id=313419 Attachment 200470: Patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=200470&action=edit ...

superreview granted: [Bug 185098] Font style ignored if <option selected="selected"> in a <select> that contains an optgroup : [Attachment 154999] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 185098: Font style ignored if <option selected="selected"> in a <select> that contains an optgroup http://bugzilla.mozilla.org/show_bug.cgi?id=185098 Attachment 154999: Patch rev. 1 http://bugzilla.mozilla.org/attachment.cgi?id=154999&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Yeah, this is reasonable. r+sr=bzbarsky. For future reference, using more context and the -p option makes the diff...

superreview granted: [Bug 277724] [FIX]<select> and <textarea> don't restore disabled state : [Attachment 245370] Fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 277724: [FIX]<select> and <textarea> don't restore disabled state https://bugzilla.mozilla.org/show_bug.cgi?id=277724 Attachment 245370: Fix https://bugzilla.mozilla.org/attachment.cgi?id=245370&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> - In nsHTMLTextAreaElement::BeforeSetAttr(): + if (aNotify && aNameSpaceID == kNameSpaceID_None && + aName == nsHTMLAtoms::disabled) { +...

superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248510: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=248510&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The 'cols' attribute is mapped to a 'ch' unit width. This patch implements the 'ch' unit generally for 'wid...

superreview requested: [Bug 296102] Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 : [Attachment 187861] If we can't load a <xul:script>, don't barf, rev. 1
Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 296102: Venkman fails to start in Deer Park Alpha 1 after 5/27/2005 https://bugzilla.mozilla.org/show_bug.cgi?id=296102 Attachment 187861: If we can't load a <xul:script>, don't barf, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187861&action=edit ...

superreview requested: [Bug 223295] <dialog>s don't need trailing <separator>s : [Attachment 134309] Fix
Stefan Borggraefe <borggraefe@despammed.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 223295: <dialog>s don't need trailing <separator>s http://bugzilla.mozilla.org/show_bug.cgi?id=223295 Attachment 134309: Fix http://bugzilla.mozilla.org/attachment.cgi?id=134309&action=edit ...

superreview granted: [Bug 342035] Expose all display:block elements via nsIAccessibleText : [Attachment 226786] But don't create for <body> or root element such as <html> or <window>, they are redunda
neil@parkwaycc.co.uk <neil@httl.net> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 342035: Expose all display:block elements via nsIAccessibleText https://bugzilla.mozilla.org/show_bug.cgi?id=342035 Attachment 226786: But don't create for <body> or root element such as <html> or <window>, they are redundant with nsDocAccessible created for doc node https://bugzilla.mozilla.org/attachment.cgi?id=226786&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ if...

superreview cancelled: [Bug 313419] Don't kill <area>s outside <map>s : [Attachment 200470] Patch to fix
Jonas Sicking <bugmail@sicking.cc> has cancelled Jonas Sicking <bugmail@sicking.cc>'s request for superreview: Bug 313419: Don't kill <area>s outside <map>s https://bugzilla.mozilla.org/show_bug.cgi?id=313419 Attachment 200470: Patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=200470&action=edit ...

Web resources about - superreview requested: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1 - netscape.mozilla.reviewers

Resources last updated: 12/11/2015 6:53:00 AM