superreview cancelled: [Bug 299404] Can't build dmg of Firefox debug build on Mac : [Attachment 187976] Put DeerPark debug builds in DeerParkDebug.app
Mark Mentovai <mark@moxienet.com> has cancelled Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 299404: Can't build dmg of Firefox debug build on Mac https://bugzilla.mozilla.org/show_bug.cgi?id=299404 Attachment 187976: Put DeerPark debug builds in DeerParkDebug.app https://bugzilla.mozilla.org/attachment.cgi?id=187976&action=edit ...

superreview requested: [Bug 54828] Build should default to non-debug/optimized build. : [Attachment 146531] Build moz optimized & non-debug by default
Chris Seawood <cls@seawood.org> has asked Daniel (Leaf) Nunes <leaf@mozilla.org> for superreview: Bug 54828: Build should default to non-debug/optimized build. http://bugzilla.mozilla.org/show_bug.cgi?id=54828 Attachment 146531: Build moz optimized & non-debug by default http://bugzilla.mozilla.org/attachment.cgi?id=146531&action=edit ...

superreview requested: [Bug 248528] JS strict warnings should be on (at least for chrome) in debug builds : [Attachment 208020] Set showInConsole to true for Firefox debug builds
Daniel Cater <DJCater@Gmail.com> has asked Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> for superreview: Bug 248528: JS strict warnings should be on (at least for chrome) in debug builds https://bugzilla.mozilla.org/show_bug.cgi?id=248528 Attachment 208020: Set showInConsole to true for Firefox debug builds https://bugzilla.mozilla.org/attachment.cgi?id=208020&action=edit ------- Additional Comments from Daniel Cater <DJCater@Gmail.com> Yeah, I've changed my mind too, strict isn't useful really, and produces far too many messages. ...

superreview requested: [Bug 248528] JS strict warnings should be on (at least for chrome) in debug builds : [Attachment 207896] Set showInConsole to true for Firefox debug builds and strict to true f
Daniel Cater <DJCater@Gmail.com> has asked Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> for superreview: Bug 248528: JS strict warnings should be on (at least for chrome) in debug builds https://bugzilla.mozilla.org/show_bug.cgi?id=248528 Attachment 207896: Set showInConsole to true for Firefox debug builds and strict to true for all debug builds https://bugzilla.mozilla.org/attachment.cgi?id=207896&action=edit ------- Additional Comments from Daniel Cater <DJCater@Gmail.com> all-thunderbird.js already has showInConsole set to true. I didn...

superreview requested: [Bug 304054] nsScriptSecurityManager.cpp doesn't build ifdef DEBUG_CAPS_HACKER unless defined DEBUG : [Attachment 192099] fix build
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 304054: nsScriptSecurityManager.cpp doesn't build ifdef DEBUG_CAPS_HACKER unless defined DEBUG https://bugzilla.mozilla.org/show_bug.cgi?id=304054 Attachment 192099: fix build https://bugzilla.mozilla.org/attachment.cgi?id=192099&action=edit ...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183648] Phase 1a: SDK-less builds on 10.4, config/build portion
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183648: Phase 1a: SDK-less builds on 10.4, config/build portion https://bugzilla.mozilla.org/attachment.cgi?id=183648&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> Splitting phase 1 into a configure/build half and a Mac-specific implementation half per comment 96. Chris, I do AC_PA...

superreview requested: [Bug 258804] It tries to build Dogbert for BeOS and it's not needed : [Attachment 158497] changes to doesn't build dogbert in a BeOS build
Sergei Dolgov <sergei_d@fi.tartu.ee> has asked timeless@myrealbox.com (working) <timeless@bemail.org> for superreview: Bug 258804: It tries to build Dogbert for BeOS and it's not needed https://bugzilla.mozilla.org/show_bug.cgi?id=258804 Attachment 158497: changes to doesn't build dogbert in a BeOS build https://bugzilla.mozilla.org/attachment.cgi?id=158497&action=edit ------- Additional Comments from Sergei Dolgov <sergei_d@fi.tartu.ee> timeless, are you allowed to sr Thunderbird BeOS bugs? (also need someone for checkin) ...

superreview requested: [Bug 258804] It tries to build Dogbert for BeOS and it's not needed : [Attachment 158497] changes to doesn't build dogbert in a BeOS build #2
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 258804: It tries to build Dogbert for BeOS and it's not needed https://bugzilla.mozilla.org/show_bug.cgi?id=258804 Attachment 158497: changes to doesn't build dogbert in a BeOS build https://bugzilla.mozilla.org/attachment.cgi?id=158497&action=edit ...

superreview requested: [Bug 338880] SuiteRunner doesn't compile with --enable-debug : [Attachment 222933] don't build appleevents twice
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 338880: SuiteRunner doesn't compile with --enable-debug https://bugzilla.mozilla.org/show_bug.cgi?id=338880 Attachment 222933: don't build appleevents twice https://bugzilla.mozilla.org/attachment.cgi?id=222933&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> (In reply to comment #6) > > We still need to make sure that non-debug builds still work > > They do, just tested it (--disable-d...

superreview requested: [Bug 338880] SuiteRunner doesn't compile with --enable-debug : [Attachment 223488] don't build appleevents and lots of tidy up v2
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 338880: SuiteRunner doesn't compile with --enable-debug https://bugzilla.mozilla.org/show_bug.cgi?id=338880 Attachment 223488: don't build appleevents and lots of tidy up v2 https://bugzilla.mozilla.org/attachment.cgi?id=223488&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Fixed a couple of bugs I'd introduced and corrected #if defined() to #ifdef in the couple of places I'd moved stuff but...

superreview requested: [Bug 338880] SuiteRunner doesn't compile with --enable-debug : [Attachment 223226] don't build appleevents twice and tidy up some ifdefs
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 338880: SuiteRunner doesn't compile with --enable-debug https://bugzilla.mozilla.org/show_bug.cgi?id=338880 Attachment 223226: don't build appleevents twice and tidy up some ifdefs https://bugzilla.mozilla.org/attachment.cgi?id=223226&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Revised patch using checks on just MOZ_XUL_APP, I've also included a few other tidy ups now that we know more about ...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183649] Phase 1b: SDK-less builds on 10.4, Mac-specific implementation portion
Mark Mentovai <mark@moxienet.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183649: Phase 1b: SDK-less builds on 10.4, Mac-specific implementation portion https://bugzilla.mozilla.org/attachment.cgi?id=183649&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> Re comment 96: removing those functions in MoreFilesX is an option, since there are no calls to them in Mozilla...

superreview granted: [Bug 54828] Build should default to non-debug/optimized build. : [Attachment 146531] Build moz optimized & non-debug by default
Daniel (Leaf) Nunes <leaf@mozilla.org> has granted Chris Seawood <cls@seawood.org>'s request for superreview: Bug 54828: Build should default to non-debug/optimized build. http://bugzilla.mozilla.org/show_bug.cgi?id=54828 Attachment 146531: Build moz optimized & non-debug by default http://bugzilla.mozilla.org/attachment.cgi?id=146531&action=edit ------- Additional Comments from Daniel (Leaf) Nunes <leaf@mozilla.org> woot. so --disable-debug is a noop now. has this been announced as upcoming in the newsgroups? (obviously, i haven't been keeping up...

superreview cancelled: [Bug 248528] JS strict warnings should be on (at least for chrome) in debug builds : [Attachment 208020] Set showInConsole to true for Firefox debug builds
Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> has cancelled Daniel Cater <DJCater@Gmail.com>'s request for superreview: Bug 248528: JS strict warnings should be on (at least for chrome) in debug builds https://bugzilla.mozilla.org/show_bug.cgi?id=248528 Attachment 208020: Set showInConsole to true for Firefox debug builds https://bugzilla.mozilla.org/attachment.cgi?id=208020&action=edit ...