superreview requested: [Bug 294717] crash in [@ nsFieldSetFrame::SetInitialChildList] printing <fieldset><legend> : [Attachment 187320] Patch rev. 1

Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron
<dbaron@mozillafoundation.org> for superreview:
Bug 294717: crash in [@ nsFieldSetFrame::SetInitialChildList] printing
<fieldset><legend>
https://bugzilla.mozilla.org/show_bug.cgi?id=294717

Attachment 187320: Patch rev. 1
https://bugzilla.mozilla.org/attachment.cgi?id=187320&action=edit

------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net>
Fixes the crash (last hunk, in |CreateContinuingFrame|),
also fixes |GetAbsoluteContainingBlock| which would return the legend frame (if

present), I couldn't find a testcase that triggered that line though -
maybe the inner area frame is also positioned when the fieldset is positioned?
0
bugzilla
6/26/2005 2:37:30 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
351 Views

Similar Articles

[PageSpeed] 44

Reply:

Similar Artilces:

superreview granted: [Bug 294717] crash in [@ nsFieldSetFrame::SetInitialChildList] printing <fieldset><legend> : [Attachment 187320] Patch rev. 1
David Baron <dbaron@mozillafoundation.org> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 294717: crash in [@ nsFieldSetFrame::SetInitialChildList] printing <fieldset><legend> https://bugzilla.mozilla.org/show_bug.cgi?id=294717 Attachment 187320: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187320&action=edit ...

superreview requested: [Bug 344434] Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> : [Attachment 229127] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Jonas Sicking <bugmail@sicking.cc> for superreview: Bug 344434: Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> https://bugzilla.mozilla.org/show_bug.cgi?id=344434 Attachment 229127: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=229127&action=edit ...

superreview requested: [Bug 344850] Tabbing from <radio> or <textbox> with tabindex fails : [Attachment 231513] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 344850: Tabbing from <radio> or <textbox> with tabindex fails https://bugzilla.mozilla.org/show_bug.cgi?id=344850 Attachment 231513: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=231513&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> I need review on the ESM changes and superreview on the whole patch. Boris, I'm sorry my requests seems to land on your or roc's plate every time, but...

superreview requested: [Bug 344850] Tabbing from <radio> or <textbox> with tabindex fails : [Attachment 231513] Patch rev. 1 #2
Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 344850: Tabbing from <radio> or <textbox> with tabindex fails https://bugzilla.mozilla.org/show_bug.cgi?id=344850 Attachment 231513: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=231513&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> roc, if you're at all familiar with this code, could you review? This is the bug I was telling you about the other day... ...

superreview cancelled: [Bug 344434] Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> : [Attachment 229127] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has cancelled superreview: Bug 344434: Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> https://bugzilla.mozilla.org/show_bug.cgi?id=344434 Attachment 229127: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=229127&action=edit ...

superreview cancelled: [Bug 344434] Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> : [Attachment 229127] Patch rev. 1 #2
Mats Palmgren <mats.palmgren@bredband.net> has cancelled superreview: Bug 344434: Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> https://bugzilla.mozilla.org/show_bug.cgi?id=344434 Attachment 229127: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=229127&action=edit ...

superreview requested: [Bug 289667] drag 'n drop of < map > links found in an < img > is broken : [Attachment 187358] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 289667: drag 'n drop of < map > links found in an < img > is broken https://bugzilla.mozilla.org/show_bug.cgi?id=289667 Attachment 187358: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187358&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The problem is that <area> content does not have a primary frame, so we call |StopTrackingDragGesture()| and make an early re...

superreview requested: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> These two changes are not needed to fix this bug: Removed an unused parameter from GetMaxOptionHeight(). Make sure GetNum...

superreview requested: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The problem is that "if (aDesiredSize.width > dropdownDesiredSize.width)" is false so we never do the second...

superreview requested: [Bug 238989] whitespace after a </b> tag is ignored when enclosed inside <fieldset></fieldset> tags : [Attachment 145302] This should fix it
Boris Zbarsky <bzbarsky@mit.edu> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 238989: whitespace after a </b> tag is ignored when enclosed inside <fieldset></fieldset> tags http://bugzilla.mozilla.org/show_bug.cgi?id=238989 Attachment 145302: This should fix it http://bugzilla.mozilla.org/attachment.cgi?id=145302&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> So the problem here was that <fieldset> was marked as a tag which is allowed to discard all direct child whitespace...

superreview requested: [Bug 293224] [FIX]Matrix from getScreenCTM should be to initial viewport space : [Attachment 194961] patch
Jonathan Watt <jonathan.watt@strath.ac.uk> has asked T Rowley (IBM) <tor@acm.org> for superreview: Bug 293224: [FIX]Matrix from getScreenCTM should be to initial viewport space https://bugzilla.mozilla.org/show_bug.cgi?id=293224 Attachment 194961: patch - include currentScale and Translate for <svg><svg></svg></svg> https://bugzilla.mozilla.org/attachment.cgi?id=194961&action=edit ...

superreview requested: [Bug 226956] Bug 197315, </mailnews/*> files: Convert <window class="dialog"> to <dialog> : [Attachment 151099] Patch V1.2
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 226956: Bug 197315, </mailnews/*> files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226956 Attachment 151099: Patch V1.2 http://bugzilla.mozilla.org/attachment.cgi?id=151099&action=edit ...

superreview requested: [Bug 226956] Bug 197315, </mailnews/*> files: Convert <window class="dialog"> to <dialog> : [Attachment 154129] More cleanup V1.1
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 226956: Bug 197315, </mailnews/*> files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226956 Attachment 154129: More cleanup V1.1 http://bugzilla.mozilla.org/attachment.cgi?id=154129&action=edit ...

superreview requested: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 136628] <xpistatus.*> patch v3
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 136628: <xpistatus.*> patch v3 http://bugzilla.mozilla.org/attachment.cgi?id=136628&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> 'approval1.6b=?': Trivial U.I. code cleanup. ...

Web resources about - superreview requested: [Bug 294717] crash in [@ nsFieldSetFrame::SetInitialChildList] printing <fieldset><legend> : [Attachment 187320] Patch rev. 1 - netscape.mozilla.reviewers

Resources last updated: 11/21/2015 9:01:04 AM