superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183870] Phase 2, v3: changes inspired by wtc's review of ph3

Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com>
for superreview:
Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here)
https://bugzilla.mozilla.org/show_bug.cgi?id=292530

Attachment 183870: Phase 2, v3: changes inspired by wtc's review of ph3
https://bugzilla.mozilla.org/attachment.cgi?id=183870&action=edit

------- Additional Comments from Mark Mentovai <mark@moxienet.com>
Changes since ph2v2 and ph2v3:
 - SDK_C_INCLUDE needs to use GCC_VERSION_FULL in lib for gcc4
 - use ${target_os} instead of $TARGET_OS (only necessary in nsprpub, but
   it's better in top-level too)
 - add comment re setting CPP and CXXCPP

This patch already had sr+, I don't see why these updates should change that.

Note that these patches (and hopefully subsequent ones) have been processed so
they should apply without having to tell patch which file to work on.
0
bugzilla
5/18/2005 12:10:21 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
992 Views

Similar Articles

[PageSpeed] 58

Reply:

Similar Artilces:

superreview granted: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183870] Phase 2, v3: changes inspired by wtc's review of ph3
Brian Ryner <bryner@brianryner.com> has granted Mark Mentovai (limited availability May 19-25) <mark@moxienet.com>'s request for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183870: Phase 2, v3: changes inspired by wtc's review of ph3 https://bugzilla.mozilla.org/attachment.cgi?id=183870&action=edit ...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183868] Phase 3, v2: implement wtc's suggestions
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183868: Phase 3, v2: implement wtc's suggestions https://bugzilla.mozilla.org/attachment.cgi?id=183868&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> (In reply to comment #114) (NSS) Good call. This is much better. (In reply to comment #115) (NSPR) OK. The only thing I didn&#...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183237] Phase 2: Allow SDK-ful builds on 10.4
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183237: Phase 2: Allow SDK-ful builds on 10.4 https://bugzilla.mozilla.org/attachment.cgi?id=183237&action=edit ...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183652] Phase 2, v2: Allow SDK-ful builds on 10.4
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183652: Phase 2, v2: Allow SDK-ful builds on 10.4 https://bugzilla.mozilla.org/attachment.cgi?id=183652&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> (In reply to comment #97) > For the Makefile changes, you should use $(shell) rather than the backticks. Done. > Since y...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183649] Phase 1b: SDK-less builds on 10.4, Mac-specific implementation portion
Mark Mentovai <mark@moxienet.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183649: Phase 1b: SDK-less builds on 10.4, Mac-specific implementation portion https://bugzilla.mozilla.org/attachment.cgi?id=183649&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> Re comment 96: removing those functions in MoreFilesX is an option, since there are no calls to them in Mozilla...

superreview granted: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183868] Phase 3, v2: implement wtc's suggestions
Brian Ryner <bryner@brianryner.com> has granted Mark Mentovai (limited availability May 19-25) <mark@moxienet.com>'s request for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183868: Phase 3, v2: implement wtc's suggestions https://bugzilla.mozilla.org/attachment.cgi?id=183868&action=edit ...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183648] Phase 1a: SDK-less builds on 10.4, config/build portion
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183648: Phase 1a: SDK-less builds on 10.4, config/build portion https://bugzilla.mozilla.org/attachment.cgi?id=183648&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> Splitting phase 1 into a configure/build half and a Mac-specific implementation half per comment 96. Chris, I do AC_PA...

superreview cancelled: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183237] Phase 2: Allow SDK-ful builds on 10.4
Chris Seawood <cls@seawood.org> has cancelled Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183237: Phase 2: Allow SDK-ful builds on 10.4 https://bugzilla.mozilla.org/attachment.cgi?id=183237&action=edit ------- Additional Comments from Chris Seawood <cls@seawood.org> For the Makefile changes, you should use $(shell) rather than the backticks. Since you are rearranging that section anyway,...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183236] Phase 1: Allow SDK-less builds on 10.4
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183236: Phase 1: Allow SDK-less builds on 10.4 https://bugzilla.mozilla.org/attachment.cgi?id=183236&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> OK. Pointing it at seawood for his autoconf/build familiarity and bryner for Mac familiarity. shaver and everyone else, your two centses...

superreview granted: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183652] Phase 2, v2: Allow SDK-ful builds on 10.4
Brian Ryner <bryner@brianryner.com> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183652: Phase 2, v2: Allow SDK-ful builds on 10.4 https://bugzilla.mozilla.org/attachment.cgi?id=183652&action=edit ...

superreview granted: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183649] Phase 1b: SDK-less builds on 10.4, Mac-specific implementation portion
Mike Shaver <shaver@mozilla.org> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183649: Phase 1b: SDK-less builds on 10.4, Mac-specific implementation portion https://bugzilla.mozilla.org/attachment.cgi?id=183649&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> sr=shaver. ...

superreview granted: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183648] Phase 1a: SDK-less builds on 10.4, config/build portion
Brian Ryner <bryner@brianryner.com> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183648: Phase 1a: SDK-less builds on 10.4, config/build portion https://bugzilla.mozilla.org/attachment.cgi?id=183648&action=edit ...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183239] Phase 4: Miscellaneous enhancements
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183239: Phase 4: Miscellaneous enhancements https://bugzilla.mozilla.org/attachment.cgi?id=183239&action=edit ...

superreview cancelled: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183236] Phase 1: Allow SDK-less builds on 10.4
Chris Seawood <cls@seawood.org> has cancelled Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183236: Phase 1: Allow SDK-less builds on 10.4 https://bugzilla.mozilla.org/attachment.cgi?id=183236&action=edit ------- Additional Comments from Chris Seawood <cls@seawood.org> Can you split the MoreFiles changes into a separate patch for darin & pinkerton/simon to review? I'm not sure why we ...

Web resources about - superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183870] Phase 2, v3: changes inspired by wtc's review of ph3 - netscape.mozilla.reviewers

Resources last updated: 12/10/2015 11:37:48 AM