superreview requested: [Bug 289667] drag 'n drop of < map > links found in an < img > is broken : [Attachment 187358] Patch rev. 1

Mats Palmgren <mats.palmgren@bredband.net> has asked Robert O'Callahan (Novell)
<roc@ocallahan.org> for superreview:
Bug 289667: drag 'n drop of < map > links found in an < img > is broken
https://bugzilla.mozilla.org/show_bug.cgi?id=289667

Attachment 187358: Patch rev. 1
https://bugzilla.mozilla.org/attachment.cgi?id=187358&action=edit

------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net>
The problem is that <area> content does not have a primary frame, so we call
|StopTrackingDragGesture()| and make an early return.

I suppose there was a reason not to keep the original |inDownFrame| around?
I kept a ref to its content instead.

This patch fixes the bug, but it does cause an assertion in |GetFrameFromNode|:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/widget/src/xpwidgets/nsBaseDragService.cpp&rev=1.35&root=/cvsroot&mark=277,293#277


when called from here:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/widget/src/xpwidgets/nsBaseDragService.cpp&rev=1.35&root=/cvsroot&mark=197,215#196


I'm not sure how to deal with that - should it not be possible to drag
frame-less content?
0
bugzilla
6/26/2005 10:23:38 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
324 Views

Similar Articles

[PageSpeed] 12

Reply: