superreview requested: [Bug 288634] non-ASCII font support in Gfx:Pango and port a couple of other changes in Gfx:Xft to Pango : [Attachment 179348] patch

Jungshik Shin <jshin1987@gmail.com> has asked David Baron <dbaron@mozilla.org>
for superreview:
Bug 288634: non-ASCII font support in Gfx:Pango and port a couple of other
changes in Gfx:Xft to Pango
https://bugzilla.mozilla.org/show_bug.cgi?id=288634

Attachment 179348: patch
https://bugzilla.mozilla.org/attachment.cgi?id=179348&action=edit

------- Additional Comments from Jungshik Shin <jshin1987@gmail.com>
>-    if (!IsASCIIFontName(aFamily))
>-	  return PR_TRUE;
>+    NS_ConvertUTF16toUTF8 name(aFamily);
> 
>-    nsCAutoString name;
>+    // The newest fontconfig does the full Unicode case folding so that 
>+    // we're being lazy here by calling |ToLowerCase| after converting
>+    // to UTF-8  assuming that in virtually all cases, we just have to
>+    // fold [A-Z].  (bug 223653). 
>     name.AssignWithConversion(aFamily.get());

I forgot to remove the above line (|name.AssignWithConversion...|, which is why
fonts with the native names didn't work. With the above line removed, the test
case in bug 223653 gets rendered as it should be.

Asking for r/sr with the above line removed.
0
bugzilla
4/5/2005 10:39:25 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
344 Views

Similar Articles

[PageSpeed] 22

Reply:

Similar Artilces:

superreview granted: [Bug 288634] non-ASCII font support in Gfx:Pango and port a couple of other changes in Gfx:Xft to Pango : [Attachment 179348] patch
David Baron <dbaron@mozillafoundation.org> has granted Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 288634: non-ASCII font support in Gfx:Pango and port a couple of other changes in Gfx:Xft to Pango https://bugzilla.mozilla.org/show_bug.cgi?id=288634 Attachment 179348: patch https://bugzilla.mozilla.org/attachment.cgi?id=179348&action=edit ...

superreview granted: [Bug 288634] non-ASCII font support in Gfx:Pango and port a couple of other changes in Gfx:Xft to Pango : [Attachment 190828] patch without 'xft'
Jungshik Shin <jshin1987@gmail.com> has granted Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 288634: non-ASCII font support in Gfx:Pango and port a couple of other changes in Gfx:Xft to Pango https://bugzilla.mozilla.org/show_bug.cgi?id=288634 Attachment 190828: patch without 'xft' https://bugzilla.mozilla.org/attachment.cgi?id=190828&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> I replaced 'Xft' with 'Gtk'. ...

superreview granted: [Bug 288634] non-ASCII font support in Gfx:Pango and port a couple of other changes in Gfx:Xft to Pango : [Attachment 190231] patch updated to the trunk
Jungshik Shin <jshin1987@gmail.com> has granted Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 288634: non-ASCII font support in Gfx:Pango and port a couple of other changes in Gfx:Xft to Pango https://bugzilla.mozilla.org/show_bug.cgi?id=288634 Attachment 190231: patch updated to the trunk https://bugzilla.mozilla.org/attachment.cgi?id=190231&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> updated to the trunk. there's a little conflict with the patch for bug 300491 (not in a line changed by this p...

superreview requested: [Bug 430413] Port Mozilla to GDK : [Attachment 317215] gfx.patch for GDK porting
Jiny Sung <jh0421.sung@samsung.com> has asked Vladimir Vukicevic (:vlad) <vladimir@pobox.com> for superreview: Bug 430413: Port Mozilla to GDK https://bugzilla.mozilla.org/show_bug.cgi?id=430413 Attachment 317215: gfx.patch for GDK porting https://bugzilla.mozilla.org/attachment.cgi?id=317215&action=edit ...

superreview requested: [Bug 176290] enabling custom font encoding support in Xft-enabled Mozilla (mathml on xft) : [Attachment 126983] Makefile.in patch for rpm(?)/GRE
Jungshik Shin <jshin@mailaps.org> has asked cls <cls@seawood.org> for superreview: Bug 176290: enabling custom font encoding support in Xft-enabled Mozilla (mathml on xft) http://bugzilla.mozilla.org/show_bug.cgi?id=176290 Attachment 126983: Makefile.in patch for rpm(?)/GRE http://bugzilla.mozilla.org/attachment.cgi?id=126983&action=edit ------- Additional Comments from Jungshik Shin <jshin@mailaps.org> Thanks for r, blizzard. As he didn't add sr, I'm asking seawood for sr (build issue) ...

superreview requested: [Bug 176290] enabling custom font encoding support in Xft-enabled Mozilla (mathml on xft) : [Attachment 126983] Makefile.in patch for rpm(?)/GRE #2
Jungshik Shin <jshin@mailaps.org> has asked cls <cls@seawood.org> for superreview: Bug 176290: enabling custom font encoding support in Xft-enabled Mozilla (mathml on xft) http://bugzilla.mozilla.org/show_bug.cgi?id=176290 Attachment 126983: Makefile.in patch for rpm(?)/GRE http://bugzilla.mozilla.org/attachment.cgi?id=126983&action=edit ------- Additional Comments from Jungshik Shin <jshin@mailaps.org> Thanks for r, blizzard. As he didn't add sr, I'm asking seawood for sr (build issue) ...

superreview granted: [Bug 430413] Port Mozilla to GDK : [Attachment 317215] gfx.patch for GDK porting
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has granted Jiny Sung <jh0421.sung@samsung.com>'s request for superreview: Bug 430413: Port Mozilla to GDK https://bugzilla.mozilla.org/show_bug.cgi?id=430413 Attachment 317215: gfx.patch for GDK porting https://bugzilla.mozilla.org/attachment.cgi?id=317215&action=edit ------- Additional Comments from Vladimir Vukicevic (:vlad) <vladimir@pobox.com> This looks fine, but please don't nest the #ifdefs.. e.g., #ifdef MOZ_ENABLE_GTK2 #ifdef MOZ_X11 should just be #if defined(MOZ_ENABLE_GTK2) &&am...

superreview requested: [Bug 266986] system font code leaks pango font objects : [Attachment 164423] patch
David Baron <dbaron@dbaron.org> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 266986: system font code leaks pango font objects https://bugzilla.mozilla.org/show_bug.cgi?id=266986 Attachment 164423: patch https://bugzilla.mozilla.org/attachment.cgi?id=164423&action=edit ...

superreview requested: [Bug 127760] complete patch file for OpenUNIX and OpenServer ports : [Attachment 131313] widget/gfx patch
timeless@myrealbox.com (working) <timeless@bemail.org> has asked rbs@maths.uq.edu.au for superreview: Bug 127760: complete patch file for OpenUNIX and OpenServer ports https://bugzilla.mozilla.org/show_bug.cgi?id=127760 Attachment 131313: widget/gfx patch https://bugzilla.mozilla.org/attachment.cgi?id=131313&action=edit ...

superreview requested: [Bug 127760] complete patch file for OpenUNIX and OpenServer ports : [Attachment 131313] widget/gfx patch
timeless@myrealbox.com <timeless@bemail.org> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 127760: complete patch file for OpenUNIX and OpenServer ports http://bugzilla.mozilla.org/show_bug.cgi?id=127760 Attachment 131313: widget/gfx patch http://bugzilla.mozilla.org/attachment.cgi?id=131313&action=edit ...

superreview requested: [Bug 127760] complete patch file for OpenUNIX and OpenServer ports : [Attachment 131313] widget/gfx patch #2
timeless@myrealbox.com <timeless@bemail.org> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 127760: complete patch file for OpenUNIX and OpenServer ports http://bugzilla.mozilla.org/show_bug.cgi?id=127760 Attachment 131313: widget/gfx patch http://bugzilla.mozilla.org/attachment.cgi?id=131313&action=edit ...

superreview requested: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 293819] patch, v.1.4, updated based on review comments
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=396137 Attachment 293819: patch, v.1.4, updated based on review comments https://bugzilla.mozilla.org/attachment.cgi?id=293819&action=edit ...

superreview requested: [Bug 223653] [Xft] support localized font family name : [Attachment 169724] patch
Jungshik Shin <jshin@i18nl10n.com> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 223653: [Xft] support localized font family name https://bugzilla.mozilla.org/show_bug.cgi?id=223653 Attachment 169724: patch https://bugzilla.mozilla.org/attachment.cgi?id=169724&action=edit ...

superreview requested: [Bug 281948] Port gfx/widget to WinCE : [Attachment 174635] patch v.2
Doug T <dougt@meer.net> has asked Darin Fisher <darin@meer.net> for superreview: Bug 281948: Port gfx/widget to WinCE https://bugzilla.mozilla.org/show_bug.cgi?id=281948 Attachment 174635: patch v.2 https://bugzilla.mozilla.org/attachment.cgi?id=174635&action=edit ...

Web resources about - superreview requested: [Bug 288634] non-ASCII font support in Gfx:Pango and port a couple of other changes in Gfx:Xft to Pango : [Attachment 179348] patch - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 11/27/2015 6:40:54 PM