superreview requested: [Bug 285921] SMTP server improperly resets to default server when viewing account settings : [Attachment 179985] the fix

Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 285921: SMTP server improperly resets to default server when viewing
account settings
https://bugzilla.mozilla.org/show_bug.cgi?id=285921

Attachment 179985: the fix
https://bugzilla.mozilla.org/attachment.cgi?id=179985&action=edit

------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
A bit of a stop gap measure. For some reason the smtp menulist (when you don't
change its value) ends up adding an undefined entry in the account manager hash
table. I'm not sure why that is yet. This patch prevents us from saving that
value into prefs when it is undefined.
0
bugzilla
4/7/2005 10:54:41 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
591 Views

Similar Articles

[PageSpeed] 23

Reply:

Similar Artilces:

superreview granted: [Bug 285921] SMTP server improperly resets to default server when viewing account settings : [Attachment 179985] the fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 285921: SMTP server improperly resets to default server when viewing account settings https://bugzilla.mozilla.org/show_bug.cgi?id=285921 Attachment 179985: the fix https://bugzilla.mozilla.org/attachment.cgi?id=179985&action=edit ...

superreview requested: [Bug 222388] Set initial SMTP server setting to "Always Use Deafult SMTP Server" instead of specific SMTP server : [Attachment 134109] patch v2
David Bienvenu <bienvenu@nventure.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 222388: Set initial SMTP server setting to "Always Use Deafult SMTP Server" instead of specific SMTP server http://bugzilla.mozilla.org/show_bug.cgi?id=222388 Attachment 134109: patch v2 http://bugzilla.mozilla.org/attachment.cgi?id=134109&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Asking Neil for r= ...

superreview cancelled: [Bug 222388] Set initial SMTP server setting to "Always Use Deafult SMTP Server" instead of specific SMTP server : [Attachment 134109] patch v2
Christian Eyrich <ch.ey@gmx.net> has cancelled David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 222388: Set initial SMTP server setting to "Always Use Deafult SMTP Server" instead of specific SMTP server http://bugzilla.mozilla.org/show_bug.cgi?id=222388 Attachment 134109: patch v2 http://bugzilla.mozilla.org/attachment.cgi?id=134109&action=edit ...

superreview requested: [Bug 244413] Mail & Newsgroup Account Settings \ Server Settings\Checkboxes : [Attachment 149157] Fixes all occurrences of this problem in MailNews
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 244413: Mail & Newsgroup Account Settings \ Server Settings\Checkboxes http://bugzilla.mozilla.org/show_bug.cgi?id=244413 Attachment 149157: Fixes all occurrences of this problem in MailNews http://bugzilla.mozilla.org/attachment.cgi?id=149157&action=edit ------- Additional Comments from Stefan Borggraefe <Stefan.Borggraefe@gmx.de> Ok, thanks Neil! Lets ask Scott for sr then. ...

superreview requested: [Bug 202468] Simpler, more consolidated UI for SMTP server settings : [Attachment 174725] proposed fix
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 202468: Simpler, more consolidated UI for SMTP server settings https://bugzilla.mozilla.org/show_bug.cgi?id=202468 Attachment 174725: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=174725&action=edit ...

superreview requested: [Bug 62836] Mozilla should be kinder to mail servers in the event of a failure (disconnects without sending QUIT to SMTP server) : [Attachment 246013] proposed patch
David Bienvenu <bienvenu@nventure.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 62836: Mozilla should be kinder to mail servers in the event of a failure (disconnects without sending QUIT to SMTP server) https://bugzilla.mozilla.org/show_bug.cgi?id=62836 Attachment 246013: proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=246013&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx for the patch - this looks good. I'd just want to make sure we don't get here if we never connect...

superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 238262] fix login page
David Bienvenu <bienvenu@nventure.com> has asked for superreview: Bug 170520: Allow SMTP server to be specified when creating new account https://bugzilla.mozilla.org/show_bug.cgi?id=170520 Attachment 238262: fix login page https://bugzilla.mozilla.org/attachment.cgi?id=238262&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I'm going to see what Neil thinks of this patch, but I need to see if it applies first. ...

superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 238262] fix login page
Alexander Ihrig <AlexIhrig@thunderbird-mail.de> has asked for superreview: Bug 170520: Allow SMTP server to be specified when creating new account https://bugzilla.mozilla.org/show_bug.cgi?id=170520 Attachment 238262: fix login page https://bugzilla.mozilla.org/attachment.cgi?id=238262&action=edit ------- Additional Comments from Alexander Ihrig <AlexIhrig@thunderbird-mail.de> David, I've taken your last patch and fixed the remaining login page bug by removing/changing the related XUL- and JS-code. Additionaly we could remove the entities "haveSmtp2****...

superreview requested: [Bug 41929] can't have multiple accounts with same pop/imap server and username, even if port is different : [Attachment 156513] fix assertion with rss servers
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 41929: can't have multiple accounts with same pop/imap server and username, even if port is different http://bugzilla.mozilla.org/show_bug.cgi?id=41929 Attachment 156513: fix assertion with rss servers http://bugzilla.mozilla.org/attachment.cgi?id=156513&action=edit ...

superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 238262] fix login page #2
Alexander Ihrig <AlexIhrig@thunderbird-mail.de> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 170520: Allow SMTP server to be specified when creating new account https://bugzilla.mozilla.org/show_bug.cgi?id=170520 Attachment 238262: fix login page https://bugzilla.mozilla.org/attachment.cgi?id=238262&action=edit ...

superreview requested: [Bug 170520] Allow SMTP server to be specified when creating new account : [Attachment 236717] fix issues with previous patch
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 170520: Allow SMTP server to be specified when creating new account https://bugzilla.mozilla.org/show_bug.cgi?id=170520 Attachment 236717: fix issues with previous patch https://bugzilla.mozilla.org/attachment.cgi?id=236717&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I think this fixes the bugs you were seeing with the previous patch, Alex - can you try it out? I hope I haven't broken the ability for isp rdf ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292022] patch v1: fixes mentioned problem
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292022: patch v1: fixes mentioned problem https://bugzilla.mozilla.org/attachment.cgi?id=292022&action=edit ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=292031&action=edit ...

superreview requested: [Bug 417957] Setting mail.auth_login and mail.server.default.auth_login to false breaks IMAP after restart : [Attachment 316292] Patch for mozilla/mailnews/imap/src/nsImapProtoc
Petri Kelottij=C3=A4rvi <petri@netatonce.net> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 417957: Setting mail.auth_login and mail.server.default.auth_login to f= alse breaks IMAP after restart https://bugzilla.mozilla.org/show_bug.cgi?id=3D417957 Attachment 316292: Patch for mozilla/mailnews/imap/src/nsImapProtocol.cpp, = cvs tag BRANCH_1_8 https://bugzilla.mozilla.org/attachment.cgi?id=3D316292&action=3Dedit ------- Additional Comments from Petri Kelottij=C3=A4rvi <petri@netatonce.n= et> Some code for looking up the password and...

superreview requested: [Bug 417957] Setting mail.auth_login and mail.server.default.auth_login to false breaks IMAP after restart : [Attachment 316293] Patch for mozilla/mailnews/imap/src/nsImapProtoc
Petri Kelottij=C3=A4rvi <petri@netatonce.net> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 417957: Setting mail.auth_login and mail.server.default.auth_login to f= alse breaks IMAP after restart https://bugzilla.mozilla.org/show_bug.cgi?id=3D417957 Attachment 316293: Patch for mozilla/mailnews/imap/src/nsImapProtocol.cpp, = cvs tag HEAD https://bugzilla.mozilla.org/attachment.cgi?id=3D316293&action=3Dedit ------- Additional Comments from Petri Kelottij=C3=A4rvi <petri@netatonce.n= et> Same as attachment 316292 except for HEAD. Some password looking-up code was not executed unless mail.auth_login was set to true.= ...

superreview requested: [Bug 90507] when using authenticated SMTP smtp username value has "@{smtp server hostname}" appended to it : [Attachment 134113] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 90507: when using authenticated SMTP smtp username value has "@{smtp server hostname}" appended to it http://bugzilla.mozilla.org/show_bug.cgi?id=90507 Attachment 134113: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=134113&action=edit ...

superreview requested: [Bug 373573] Cannot set default identity' s SMTP server in Identity Settings dialog
N.R.Kashivishwanathan <vishwanathan.kashi@gmail.com> has asked for superreview: Bug 373573: Cannot set default identity's SMTP server in Identity Settings dialog https://bugzilla.mozilla.org/show_bug.cgi?id=3D373573 Attachment 276971: bugzilla attachment https://bugzilla.mozilla.org/attachment.cgi?id=3D276971&action=3Dedit= ...

superreview granted: [Bug 244413] Mail & Newsgroup Account Settings \ Server Settings\Checkboxes : [Attachment 149157] Fixes all occurrences of this problem in MailNews
Scott MacGregor <mscott@mozilla.org> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 244413: Mail & Newsgroup Account Settings \ Server Settings\Checkboxes http://bugzilla.mozilla.org/show_bug.cgi?id=244413 Attachment 149157: Fixes all occurrences of this problem in MailNews http://bugzilla.mozilla.org/attachment.cgi?id=149157&action=edit ...

superreview requested: [Bug 420469] Remove superfluous access key in Account settings -> Server settings : [Attachment 307441] remove from .dtd and .xul
David Bienvenu <bienvenu@nventure.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 420469: Remove superfluous access key in Account settings -> Server settings https://bugzilla.mozilla.org/show_bug.cgi?id=420469 Attachment 307441: remove from .dtd and .xul https://bugzilla.mozilla.org/attachment.cgi?id=307441&action=edit ...

superreview requested: [Bug 242970] Server Settings/local directory was changed to \\.\D:\pop3.server.name (Other than C: drive,After 2004-04-29 build) : [Attachment 148192] Failing to set a relative
timeless@myrealbox.com (working) <timeless@bemail.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 242970: Server Settings/local directory was changed to \\.\D:\pop3.server.name (Other than C: drive,After 2004-04-29 build) http://bugzilla.mozilla.org/show_bug.cgi?id=242970 Attachment 148192: Failing to set a relative descriptor is not an error case http://bugzilla.mozilla.org/attachment.cgi?id=148192&action=edit ...

superreview requested: [Bug 334407] [FIX]data: loads should default to the null principal if no owner is set : [Attachment 219560] Fix a view-source issue in the previous patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 334407: [FIX]data: loads should default to the null principal if no owner is set https://bugzilla.mozilla.org/show_bug.cgi?id=334407 Attachment 219560: Fix a view-source issue in the previous patch https://bugzilla.mozilla.org/attachment.cgi?id=219560&action=edit ...

superreview requested: [Bug 235355] hangs/crashes after choosing Server Settings in Mail&Newsgroup Account Settings, click o.k. : [Attachment 142195] v1 patch
Darin Fisher <darin@meer.net> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 235355: hangs/crashes after choosing Server Settings in Mail&Newsgroup Account Settings, click o.k. http://bugzilla.mozilla.org/show_bug.cgi?id=235355 Attachment 142195: v1 patch http://bugzilla.mozilla.org/attachment.cgi?id=142195&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> i checked with the old nsString2.cpp code, and saw that indeed it would return early if ReplaceSubstring was called with aTarget equal to the empty string. it...

superreview requested: [Bug 216789] "Server Settings" tab in "Account Settings" is too big for preferences window : [Attachment 130981] Revised Patch v0.2a
Ian Neal <bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 216789: "Server Settings" tab in "Account Settings" is too big for preferences window http://bugzilla.mozilla.org/show_bug.cgi?id=216789 Attachment 130981: Revised Patch v0.2a http://bugzilla.mozilla.org/attachment.cgi?id=130981&action=edit ...

superreview requested: [Bug 228597] News article gets always sent to the first accounts server when sharing identities by multiple accounts : [Attachment 140680] fix to make import directory build
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 228597: News article gets always sent to the first accounts server when sharing identities by multiple accounts http://bugzilla.mozilla.org/show_bug.cgi?id=228597 Attachment 140680: fix to make import directory build http://bugzilla.mozilla.org/attachment.cgi?id=140680&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I warned Patrick Brunschwig about this checkin and it turns out Christian already warned him and Patrick has fixed it for the next version of enigmail. ...

Web resources about - superreview requested: [Bug 285921] SMTP server improperly resets to default server when viewing account settings : [Attachment 179985] the fix - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 3/13/2016 2:25:27 AM