superreview granted: [Bug 282187] sync xpfe textbox.xml with toolkit textbox.xml : [Attachment 178157] (Av1b) <textbox.xml> (full sync ++)neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Serge
GAUTHERIE <gautheri@noos.fr>'s request for superreview:
Bug 282187: sync xpfe textbox.xml with toolkit textbox.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282187
Attachment 178157: (Av1b) <textbox.xml> (full sync ++)
https://bugzilla.mozilla.org/attachment.cgi?id=178157&action=edit
...
superreview requested: [Bug 282187] sync xpfe textbox.xml with toolkit textbox.xml : [Attachment 178081] (Av1a) <textbox.xml> (nit + anonid)Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 282187: sync xpfe textbox.xml with toolkit textbox.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282187
Attachment 178081: (Av1a) <textbox.xml> (nit + anonid)
https://bugzilla.mozilla.org/attachment.cgi?id=178081&action=edit
...
superreview requested: [Bug 282187] sync xpfe textbox.xml with toolkit textbox.xml : [Attachment 178036] (Av1-MAS) <textbox.xml> (nit fix)Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 282187: sync xpfe textbox.xml with toolkit textbox.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282187
Attachment 178036: (Av1-MAS) <textbox.xml> (nit fix)
https://bugzilla.mozilla.org/attachment.cgi?id=178036&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
Clears the way to better see the 2 remaining sync to do.
Could you (super-)review/check in this patch ? Thanks.
Then, would you have time...
superreview cancelled: [Bug 282187] sync xpfe textbox.xml with toolkit textbox.xml : [Attachment 178081] (Av1a) <textbox.xml> (nit + anonid)Serge GAUTHERIE <gautheri@noos.fr> has cancelled Serge GAUTHERIE
<gautheri@noos.fr>'s request for superreview:
Bug 282187: sync xpfe textbox.xml with toolkit textbox.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282187
Attachment 178081: (Av1a) <textbox.xml> (nit + anonid)
https://bugzilla.mozilla.org/attachment.cgi?id=178081&action=edit
...
superreview cancelled: [Bug 282187] sync xpfe textbox.xml with toolkit textbox.xml : [Attachment 178036] (Av1-MAS) <textbox.xml> (nit fix)Serge GAUTHERIE <gautheri@noos.fr> has cancelled Serge GAUTHERIE
<gautheri@noos.fr>'s request for superreview:
Bug 282187: sync xpfe textbox.xml with toolkit textbox.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282187
Attachment 178036: (Av1-MAS) <textbox.xml> (nit fix)
https://bugzilla.mozilla.org/attachment.cgi?id=178036&action=edit
...
superreview requested: [Bug 282186] sync xpfe text.xml with toolkit text.xml : [Attachment 221205] (Cv1-XPFE) <text.xml>Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282186: sync xpfe text.xml with toolkit text.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282186
Attachment 221205: (Cv1-XPFE) <text.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=221205&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
This part comes from bug 280065 and followups.
Untested.
...
superreview requested: [Bug 282189] sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml : [Attachment 219242] (Bv2-XPFE) <toolbarbutton.xml> ++Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282189: sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282189
Attachment 219242: (Bv2-XPFE) <toolbarbutton.xml> ++
https://bugzilla.mozilla.org/attachment.cgi?id=219242&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
Bv1, updated to current Trunk:
in fact, it's now a port, of the (TB+TK) attachment 214196 in bug 252393,
which addresses comment 5 and comment 6.
...
superreview requested: [Bug 282182] sync xpfe general.xml with toolkit general.xml : [Attachment 219626] (Av3-XPFE) <general.xml>++Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282182: sync xpfe general.xml with toolkit general.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282182
Attachment 219626: (Av3-XPFE) <general.xml>++
https://bugzilla.mozilla.org/attachment.cgi?id=219626&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
Av3-XPFE-Bw, with full diff.
Keeping
[[
(Av3-XPFE-Bw) <general.xml>++ patch 2006-04-23 16:17 PDT
2.38 KB neil: review+
]]
...
superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 221700] (Av4-XPFE) <button.xml>Serge GAUTHERIE <gautheri@noos.fr> has asked for superreview:
Bug 282180: sync xpfe button.xml with toolkit button.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282180
Attachment 221700: (Av4-XPFE) <button.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=221700&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
Av3-XPFE, with comment 17 suggestion(s).
Untested: Would you have a testcase to check this behaviour ?
...
superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 218477] (Av3-XPFE) <button.xml>Serge GAUTHERIE <gautheri@noos.fr> has asked for superreview:
Bug 282180: sync xpfe button.xml with toolkit button.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282180
Attachment 218477: (Av3-XPFE) <button.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=218477&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
Av2, with comment 7 suggestion(s).
...
superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 218477] (Av3-XPFE) <button.xml> #2Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282180: sync xpfe button.xml with toolkit button.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282180
Attachment 218477: (Av3-XPFE) <button.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=218477&action=edit
...
superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 221700] (Av4-XPFE) <button.xml> #2Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282180: sync xpfe button.xml with toolkit button.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282180
Attachment 221700: (Av4-XPFE) <button.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=221700&action=edit
...
superreview requested: [Bug 282180] sync xpfe button.xml with toolkit button.xml : [Attachment 217747] (Av2) <button.xml>Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 282180: sync xpfe button.xml with toolkit button.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282180
Attachment 217747: (Av2) <button.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=217747&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
(In reply to comment #4)
> If the diff still has not changed, I would suggest this also be applied + a
> migration to toolkit's directly.
Updated to current Trunk; un...
superreview requested: [Bug 282189] sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml : [Attachment 176675] (Av1) <toolbarbutton.xml>Serge GAUTHERIE <gautheri@noos.fr> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 282189: sync xpfe toolbarbutton.xml with toolkit toolbarbutton.xml
https://bugzilla.mozilla.org/show_bug.cgi?id=282189
Attachment 176675: (Av1) <toolbarbutton.xml>
https://bugzilla.mozilla.org/attachment.cgi?id=176675&action=edit
------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
Untested, but so obvious...
(What would be the expected non-regression test for this change ?)
This came from Toolkit version:
{{
1.3...