superreview requested: [Bug 282164] Deleting last message doesn't reset message pane and window title : [Attachment 177283] Possible patch

Mark Banner <mark@standard8.demon.co.uk> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 282164: Deleting last message doesn't reset message pane and window title
https://bugzilla.mozilla.org/show_bug.cgi?id=282164

Attachment 177283: Possible patch
https://bugzilla.mozilla.org/attachment.cgi?id=177283&action=edit

------- Additional Comments from Mark Banner <mark@standard8.demon.co.uk>
This patch fixes both this and the thunderbird one (bug 218779).

The reasoning behind it is that currentIndex may be -1 if a range is selected -
that then causes isSelected to fail. Changing the check to see if anything is
selected causes the function to work correctly.

I have tested it deleting single items, ranges and all within imap, pop, and
local folders.
0
bugzilla
3/13/2005 3:00:49 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
492 Views

Similar Articles

[PageSpeed] 50

Reply:

Similar Artilces:

superreview cancelled: [Bug 282164] Deleting last message doesn't reset message pane and window title : [Attachment 177283] Possible patch
Mark Banner <mark@standard8.demon.co.uk> has cancelled Mark Banner <mark@standard8.demon.co.uk>'s request for superreview: Bug 282164: Deleting last message doesn't reset message pane and window title https://bugzilla.mozilla.org/show_bug.cgi?id=282164 Attachment 177283: Possible patch https://bugzilla.mozilla.org/attachment.cgi?id=177283&action=edit ------- Additional Comments from Mark Banner <mark@standard8.demon.co.uk> Cancelling review as this doesn't work in the case neil mentioned. ...

superreview requested: [Bug 419379] delete message doesn't work if focus in header of message preview pane : [Attachment 305846] Make delete button work again v1
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 419379: delete message doesn't work if focus in header of message preview pane https://bugzilla.mozilla.org/show_bug.cgi?id=419379 Attachment 305846: Make delete button work again v1 https://bugzilla.mozilla.org/attachment.cgi?id=305846&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> The patch brings back the button_delete command removed in bug 391701 and also introduces button_shiftD...

superreview requested: [Bug 419379] delete message doesn't work if focus in header of message preview pane : [Attachment 306928] Make the delete button work in all places
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 419379: delete message doesn't work if focus in header of message preview pane https://bugzilla.mozilla.org/show_bug.cgi?id=419379 Attachment 306928: Make the delete button work in all places https://bugzilla.mozilla.org/attachment.cgi?id=306928&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> I forgot the standalone message window before (thx Karsten for spotting), so the patch is v1 +...

superreview requested: [Bug 276812] If you define a message filter with Message Filter window open, filter doesn't appear. : [Attachment 170141] Patch to fix regression for Mailnews and TB
Mark Banner <mark@standard8.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 276812: If you define a message filter with Message Filter window open, filter doesn't appear. https://bugzilla.mozilla.org/show_bug.cgi?id=276812 Attachment 170141: Patch to fix regression for Mailnews and TB https://bugzilla.mozilla.org/attachment.cgi?id=170141&action=edit ------- Additional Comments from Mark Banner <mark@standard8.demon.co.uk> This patch adds the missing changes from preselectedFolder to folder for both mailnews and TB. Going...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=292031&action=edit ...

superreview requested: [Bug 310844] shift+space doesn't scroll message pane up unless message pane has focus : [Attachment 201109] Explicitly allow shift key
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 310844: shift+space doesn't scroll message pane up unless message pane has focus https://bugzilla.mozilla.org/show_bug.cgi?id=310844 Attachment 201109: Explicitly allow shift key https://bugzilla.mozilla.org/attachment.cgi?id=201109&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Previously to bug 295288 we automatically ignored the shift key. ...

superreview granted: [Bug 419379] delete message doesn't work if focus in header of message preview pane : [Attachment 305846] Make delete button work again v1
neil@parkwaycc.co.uk <neil@httl.net> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 419379: delete message doesn't work if focus in header of message preview pane https://bugzilla.mozilla.org/show_bug.cgi?id=419379 Attachment 305846: Make delete button work again v1 https://bugzilla.mozilla.org/attachment.cgi?id=305846&action=edit ...

superreview granted: [Bug 419379] delete message doesn't work if focus in header of message preview pane : [Attachment 306928] Make the delete button work in all places
neil@parkwaycc.co.uk <neil@httl.net> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 419379: delete message doesn't work if focus in header of message preview pane https://bugzilla.mozilla.org/show_bug.cgi?id=419379 Attachment 306928: Make the delete button work in all places https://bugzilla.mozilla.org/attachment.cgi?id=306928&action=edit ...

superreview requested: [Bug 252317] Character Encoding menu doesn't work in Message Source window : [Attachment 153870] Proposed patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 252317: Character Encoding menu doesn't work in Message Source window http://bugzilla.mozilla.org/show_bug.cgi?id=252317 Attachment 153870: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=153870&action=edit ...

superreview granted: [Bug 276812] If you define a message filter with Message Filter window open, filter doesn't appear. : [Attachment 170141] Patch to fix regression for Mailnews and TB
David Bienvenu <bienvenu@nventure.com> has granted Mark Banner <mark@standard8.demon.co.uk>'s request for superreview: Bug 276812: If you define a message filter with Message Filter window open, filter doesn't appear. https://bugzilla.mozilla.org/show_bug.cgi?id=276812 Attachment 170141: Patch to fix regression for Mailnews and TB https://bugzilla.mozilla.org/attachment.cgi?id=170141&action=edit ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292088] patch v3: remove unnecessary QueryInterface
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292088: patch v3: remove unnecessary QueryInterface https://bugzilla.mozilla.org/attachment.cgi?id=292088&action=edit ------- Additional Comments from Anant Narayanan <anant@kix.in> Sorry, should have taken a look at the implementation of NS_GetInnermostURI first. ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292022] patch v1: fixes mentioned problem
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292022: patch v1: fixes mentioned problem https://bugzilla.mozilla.org/attachment.cgi?id=292022&action=edit ...

superreview denied: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has denied Anant Narayanan <anant@kix.in>'s request for superreview: Bug 393002: "Server not found" message for view-source window doesn't displ= ay server name https://bugzilla.mozilla.org/show_bug.cgi?id=3D393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=3D292031&action=3Dedit ------- Additional Comments from Boris Zbarsky (reviews very slow until spr= ing) <bzbarsky@mit.edu> You don't need the QI. ...

superreview requested: [Bug 297027] NS_ScriptErrorReporter(JSContext *cx, const char *message, JSErrorReport *report) doesn't report message to stdout : [Attachment 185635] report ascii message when
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 297027: NS_ScriptErrorReporter(JSContext *cx, const char *message, JSErrorReport *report) doesn't report message to stdout https://bugzilla.mozilla.org/show_bug.cgi?id=297027 Attachment 185635: report ascii message when ucmessage isn't provided https://bugzilla.mozilla.org/attachment.cgi?id=185635&action=edit ...

Web resources about - superreview requested: [Bug 282164] Deleting last message doesn't reset message pane and window title : [Attachment 177283] Possible patch - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/15/2015 4:12:40 PM