superreview requested: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174088] updated patch

Hasse <jasajudeju@telia.com> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 274440: ".key" should not be used to describe access keys, use ".accesskey"
instead
https://bugzilla.mozilla.org/show_bug.cgi?id=274440

Attachment 174088: updated patch
https://bugzilla.mozilla.org/attachment.cgi?id=174088&action=edit

------- Additional Comments from Hasse <jasajudeju@telia.com>
Don't remove the "<key key=" lines.
0
bugzilla
2/11/2005 10:00:53 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
708 Views

Similar Articles

[PageSpeed] 17

Reply:

Similar Artilces:

superreview granted: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174088] updated patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Hasse <jasajudeju@telia.com>'s request for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174088: updated patch https://bugzilla.mozilla.org/attachment.cgi?id=174088&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Transferring r=db48x as per his comment. ...

superreview requested: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174078] proposed patch
Hasse <jasajudeju@telia.com> has asked Daniel Brooks <db48x@yahoo.com> for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174078: proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=174078&action=edit ...

superreview requested: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174078] proposed patch #2
Daniel Brooks <db48x@yahoo.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174078: proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=174078&action=edit ------- Additional Comments from Daniel Brooks <db48x@yahoo.com> >- <key key="&selectall.key;" modifiers="alt" command="cmd_selectall"/> �...

superreview cancelled: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174078] proposed patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has cancelled Daniel Brooks <db48x@yahoo.com>'s request for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174078: proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=174078&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Cancelling request on obsolete patch. ...

superreview requested: [Bug 260141] Some strings in locale files is using "Firefox"
Alexander L. Slovesnik <als@mozilla.ru> has asked for superreview: Bug 260141: Some strings in locale files is using "Firefox" - should use &brandShortName; instead https://bugzilla.mozilla.org/show_bug.cgi?id=260141 Attachment 159777: Patch for updated.dtd only. https://bugzilla.mozilla.org/attachment.cgi?id=159777&action=edit ...

superreview requested: [Bug 260141] Some strings in locale files is using "Firefox"
Alexander L. Slovesnik <als@mozilla.ru> has asked for superreview: Bug 260141: Some strings in locale files is using "Firefox" - should use &brandShortName; instead https://bugzilla.mozilla.org/show_bug.cgi?id=260141 Attachment 159777: Patch for updated.dtd only. https://bugzilla.mozilla.org/attachment.cgi?id=159777&action=edit ...

superreview requested: [Bug 266373] "Deprecated property window.title used. Please use document.title instead." has no source information : [Attachment 163687] Updated patch
James Ross <silver@warwickcompsoc.co.uk> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 266373: "Deprecated property window.title used. Please use document.title instead." has no source information https://bugzilla.mozilla.org/show_bug.cgi?id=266373 Attachment 163687: Updated patch https://bugzilla.mozilla.org/attachment.cgi?id=163687&action=edit ...

superreview requested: [Bug 230807] Calendar uses xmlterm's "program launch"-accelerator key (commandkey "7") : [Attachment 138974] changes the commandkey for all locales
Mikko Virkkil� <mikko.virkkila@mbnet.fi> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 230807: Calendar uses xmlterm's "program launch"-accelerator key (commandkey "7") http://bugzilla.mozilla.org/show_bug.cgi?id=230807 Attachment 138974: changes the commandkey for all locales http://bugzilla.mozilla.org/attachment.cgi?id=138974&action=edit ...

superreview requested: [Bug 229438] Support the "Find" and "Help" keys on Sun keyboard : [Attachment 137978] patch
Simford <Simford.Dong@sun.com> has asked Henry Jia <Henry.Jia@sun.com> for superreview: Bug 229438: Support the "Find" and "Help" keys on Sun keyboard http://bugzilla.mozilla.org/show_bug.cgi?id=229438 Attachment 137978: patch http://bugzilla.mozilla.org/attachment.cgi?id=137978&action=edit ...

superreview requested: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156223] use OK/Cancel
Steffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156223: use OK/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156223&action=edit ------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de> Brian, this is really simple, yet a 1.0PR blocker. ...

superreview requested: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156227] use Grant/Cancel
Steffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156227: use Grant/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156227&action=edit ------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de> Grant/Cancel is better indeed. ...

superreview requested: [Bug 283840] "Select User Profile" dialog is broken after using "Custom" in installer : [Attachment 175665] patch
Andrew Schultz <ajschult@verizon.net> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 283840: "Select User Profile" dialog is broken after using "Custom" in installer https://bugzilla.mozilla.org/show_bug.cgi?id=283840 Attachment 175665: patch https://bugzilla.mozilla.org/attachment.cgi?id=175665&action=edit ------- Additional Comments from Andrew Schultz <ajschult@verizon.net> (thanks for catching this Mats) the index owned by the component should have been nuked. The component list was just walking the list with a b...

superreview requested: [Bug 299058] XUL error report in main window
Sergei Dolgov <sergei_d@fi.tartu.ee> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 299058: XUL error report in main window - <key id="addBookmarkKb key="&addCurPageCmd.commandkey;"/> https://bugzilla.mozilla.org/show_bug.cgi?id=299058 Attachment 198626: patch https://bugzilla.mozilla.org/attachment.cgi?id=198626&action=edit ------- Additional Comments from Sergei Dolgov <sergei_d@fi.tartu.ee> asking Neil for sr (and commit) ...

superreview granted: [Bug 236700] The "v" key brings up the find dialog : [Attachment 143158] I really should use |keycode| instead of |key| for the keybinding
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 236700: The "v" key brings up the find dialog http://bugzilla.mozilla.org/show_bug.cgi?id=236700 Attachment 143158: I really should use |keycode| instead of |key| for the keybinding http://bugzilla.mozilla.org/attachment.cgi?id=143158&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky ...

Web resources about - superreview requested: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174088] updated patch - netscape.mozilla.reviewers

Resources last updated: 12/6/2015 11:29:57 PM