superreview requested: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174078] proposed patch #2

Daniel Brooks <db48x@yahoo.com> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 274440: ".key" should not be used to describe access keys, use ".accesskey"
instead
https://bugzilla.mozilla.org/show_bug.cgi?id=274440

Attachment 174078: proposed patch
https://bugzilla.mozilla.org/attachment.cgi?id=174078&action=edit

------- Additional Comments from Daniel Brooks <db48x@yahoo.com>
>-    <key key="&selectall.key;"   modifiers="alt"   command="cmd_selectall"/>
�
>-    <key key="&selectall.key;"   modifiers="alt"   command="cmd_selectall"/>

Don't remove those lines, they're there for a reason. Other than that, it looks
correct.

I'm not the guy to go for to get super review, Neil is. I will give you r=
though, with that one correction.
0
bugzilla
2/11/2005 9:12:22 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
492 Views

Similar Articles

[PageSpeed] 6

Reply:

Similar Artilces:

superreview requested: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174078] proposed patch
Hasse <jasajudeju@telia.com> has asked Daniel Brooks <db48x@yahoo.com> for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174078: proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=174078&action=edit ...

superreview cancelled: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174078] proposed patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has cancelled Daniel Brooks <db48x@yahoo.com>'s request for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174078: proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=174078&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Cancelling request on obsolete patch. ...

superreview requested: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174088] updated patch
Hasse <jasajudeju@telia.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174088: updated patch https://bugzilla.mozilla.org/attachment.cgi?id=174088&action=edit ------- Additional Comments from Hasse <jasajudeju@telia.com> Don't remove the "<key key=" lines. ...

superreview granted: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174088] updated patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Hasse <jasajudeju@telia.com>'s request for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174088: updated patch https://bugzilla.mozilla.org/attachment.cgi?id=174088&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Transferring r=db48x as per his comment. ...

superreview requested: [Bug 340373] Escape key should cancel "send in Unicode (UTF-8)?" dialog : [Attachment 226042] use button 1 for cancel instead of button 2 #2
Gavin Sharp <gavin.sharp@gmail.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 340373: Escape key should cancel "send in Unicode (UTF-8)?" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=340373 Attachment 226042: use button 1 for cancel instead of button 2 https://bugzilla.mozilla.org/attachment.cgi?id=226042&action=edit ...

superreview requested: [Bug 260141] Some strings in locale files is using "Firefox"
Alexander L. Slovesnik <als@mozilla.ru> has asked for superreview: Bug 260141: Some strings in locale files is using "Firefox" - should use &brandShortName; instead https://bugzilla.mozilla.org/show_bug.cgi?id=260141 Attachment 159777: Patch for updated.dtd only. https://bugzilla.mozilla.org/attachment.cgi?id=159777&action=edit ...

superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile #2
Steuard Jensen <steuard+mozilla@slimy.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 315633: "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" https://bugzilla.mozilla.org/show_bug.cgi?id=315633 Attachment 206616: Use Mac-appropriate text in profile creation https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit ...

superreview requested: [Bug 230807] Calendar uses xmlterm's "program launch"-accelerator key (commandkey "7") : [Attachment 138974] changes the commandkey for all locales
Mikko Virkkil� <mikko.virkkila@mbnet.fi> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 230807: Calendar uses xmlterm's "program launch"-accelerator key (commandkey "7") http://bugzilla.mozilla.org/show_bug.cgi?id=230807 Attachment 138974: changes the commandkey for all locales http://bugzilla.mozilla.org/attachment.cgi?id=138974&action=edit ...

superreview requested: [Bug 157067] Inconsistency in appearance of "Move Up" and "Move Down" buttons : [Attachment 145778] Makes buttons and access keys in Filter List consistent with the rest of Sea #2
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 157067: Inconsistency in appearance of "Move Up" and "Move Down" buttons http://bugzilla.mozilla.org/show_bug.cgi?id=157067 Attachment 145778: Makes buttons and access keys in Filter List consistent with the rest of Seamonkey http://bugzilla.mozilla.org/attachment.cgi?id=145778&action=edit ------- Additional Comments from Stefan Borggraefe <Stefan.Borggraefe@gmx.de> Asking a MailNews peer for sr. ...

superreview requested: [Bug 340373] Escape key should cancel "send in Unicode (UTF-8)?" dialog : [Attachment 226042] use button 1 for cancel instead of button 2
Gavin Sharp <gavin.sharp@gmail.com> has asked for superreview: Bug 340373: Escape key should cancel "send in Unicode (UTF-8)?" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=340373 Attachment 226042: use button 1 for cancel instead of button 2 https://bugzilla.mozilla.org/attachment.cgi?id=226042&action=edit ------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com> commonDialog.js sets the cancel button to the button at index 1 in the button flags, so POS_1 should be used for the cancel button. The only implementation that I tested was the...

superreview requested: [Bug 229438] Support the "Find" and "Help" keys on Sun keyboard : [Attachment 137978] patch
Simford <Simford.Dong@sun.com> has asked Henry Jia <Henry.Jia@sun.com> for superreview: Bug 229438: Support the "Find" and "Help" keys on Sun keyboard http://bugzilla.mozilla.org/show_bug.cgi?id=229438 Attachment 137978: patch http://bugzilla.mozilla.org/attachment.cgi?id=137978&action=edit ...

superreview requested: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156227] use Grant/Cancel
Steffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156227: use Grant/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156227&action=edit ------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de> Grant/Cancel is better indeed. ...

superreview requested: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156223] use OK/Cancel
Steffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156223: use OK/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156223&action=edit ------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de> Brian, this is really simple, yet a 1.0PR blocker. ...

superreview requested: [Bug 241181] inconsistent spelling of cancelled or canceled in Mozilla. : [Attachment 146719] Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Fi
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Scott Collins <scc@mozilla.org> for superreview: Bug 241181: inconsistent spelling of cancelled or canceled in Mozilla. http://bugzilla.mozilla.org/show_bug.cgi?id=241181 Attachment 146719: Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Firefox. http://bugzilla.mozilla.org/attachment.cgi?id=146719&action=edit ------- Additional Comments from Bruce Davidson <Bruce.Davidson@iplbath.com> Requesting r/sr (rs=?) on this patch for 1.8 trunk. ...

Web resources about - superreview requested: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174078] proposed patch #2 - netscape.mozilla.reviewers

Resources last updated: 1/21/2016 6:22:02 AM