superreview denied: [Bug 272250] make distclean from mozilla does not clean mozilla/camino/build : [Attachment 169383] make distclean work
Mike Pinkerton <pinkerton@aol.net> has denied Ludovic Hirlimann <qa-mozilla@hirlimann.net>'s request for superreview: Bug 272250: make distclean from mozilla does not clean mozilla/camino/build https://bugzilla.mozilla.org/show_bug.cgi?id=272250 Attachment 169383: make distclean work https://bugzilla.mozilla.org/attachment.cgi?id=169383&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> $(DIST)/camino doesn't exist. ...

superreview granted: [Bug 272250] make distclean from mozilla does not clean mozilla/camino/build : [Attachment 169648] Adressing pink's comment.
Mike Pinkerton <pinkerton@aol.net> has granted Mike Pinkerton <pinkerton@aol.net>'s request for superreview: Bug 272250: make distclean from mozilla does not clean mozilla/camino/build https://bugzilla.mozilla.org/show_bug.cgi?id=272250 Attachment 169648: Adressing pink's comment. https://bugzilla.mozilla.org/attachment.cgi?id=169648&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink ...

superreview requested: [Bug 249782] Make Mozilla compile with Microsoft Visual Studio 2005 : [Attachment 152300] Make Mozilla build
Stephen Walker <sdwalker@myrealbox.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 249782: Make Mozilla compile with Microsoft Visual Studio 2005 http://bugzilla.mozilla.org/show_bug.cgi?id=249782 Attachment 152300: Make Mozilla build http://bugzilla.mozilla.org/attachment.cgi?id=152300&action=edit ...

superreview requested: [Bug 232742] Mozilla incl. firebird does not build on Amd64 cpu : [Attachment 140309] This patch makes mozilla build on amd64 under gentoo linux
Roland Mainz <roland.mainz@nrubsig.org> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 232742: Mozilla incl. firebird does not build on Amd64 cpu http://bugzilla.mozilla.org/show_bug.cgi?id=232742 Attachment 140309: This patch makes mozilla build on amd64 under gentoo linux http://bugzilla.mozilla.org/attachment.cgi?id=140309&action=edit ------- Additional Comments from Roland Mainz <roland.mainz@nrubsig.org> Requesting r= from wtc for the NSPR and NSS changes per bryner's suggestion... ...

superreview denied: [Bug 249782] Make Mozilla compile with Microsoft Visual Studio 2005 : [Attachment 152300] Make Mozilla build
David Baron <dbaron@dbaron.org> has denied Stephen Walker <sdwalker@myrealbox.com>'s request for superreview: Bug 249782: Make Mozilla compile with Microsoft Visual Studio 2005 http://bugzilla.mozilla.org/show_bug.cgi?id=249782 Attachment 152300: Make Mozilla build http://bugzilla.mozilla.org/attachment.cgi?id=152300&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> > AC_MSG_ERROR([This version of the MSVC compiler, $CC_VERSION , is unsupported.]) I'm somewhat skeptical whether giving an error on an unknown compil...

superreview requested: [Bug 424641] Write profile migrator to make old Thunderbird profiles available under "Mozilla", "~/mozilla", or "Application Support" : [Attachment 318390] The fix v2
Mark Banner <bugzilla@standard8.plus.com> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 424641: Write profile migrator to make old Thunderbird profiles available under "Mozilla", "~/mozilla", or "Application Support" https://bugzilla.mozilla.org/show_bug.cgi?id=424641 Attachment 318390: The fix v2 https://bugzilla.mozilla.org/attachment.cgi?id=318390&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> I'm happy this should work on all platforms. I'll request toolkit revi...

superreview requested: [Bug 280901] Mozilla build fails when trying to build in mozilla/extensions/spellcheck/myspell/src directory. : [Attachment 173252] Suggested fix
Boris Zbarsky <bzbarsky@mit.edu> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 280901: Mozilla build fails when trying to build in mozilla/extensions/spellcheck/myspell/src directory. https://bugzilla.mozilla.org/show_bug.cgi?id=280901 Attachment 173252: Suggested fix https://bugzilla.mozilla.org/attachment.cgi?id=173252&action=edit ...

superreview requested: [Bug 333308] make clean and make distclean miss various files : [Attachment 217729] Remove generated / copied files
jag (Peter Annema) <jag@tty.nl> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 333308: make clean and make distclean miss various files https://bugzilla.mozilla.org/show_bug.cgi?id=333308 Attachment 217729: Remove generated / copied files https://bugzilla.mozilla.org/attachment.cgi?id=217729&action=edit ...

superreview requested: [Bug 213281] make mozilla build with mingw gcc on win98 (windres no resources error) : [Attachment 128155] probable patch
cls <cls@seawood.org> has asked Daniel (Leaf) Nunes <leaf@mozilla.org> for superreview: Bug 213281: make mozilla build with mingw gcc on win98 (windres no resources error) http://bugzilla.mozilla.org/show_bug.cgi?id=213281 Attachment 128155: probable patch http://bugzilla.mozilla.org/attachment.cgi?id=128155&action=edit ...

superreview requested: [Bug 168624] Microsoft Narrator hangs Mozilla : [Attachment 151156] Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public
Aaron Leventhal <aaronleventhal@moonset.net> has asked Alec Flett <alecf@flett.org> for superreview: Bug 168624: Microsoft Narrator hangs Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=168624 Attachment 151156: Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public http://bugzilla.mozilla.org/attachment.cgi?id=151156&action=edit ...

superreview requested: [Bug 168624] Microsoft Narrator hangs Mozilla : [Attachment 151156] Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public #2
Aaron Leventhal <aaronleventhal@moonset.net> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 168624: Microsoft Narrator hangs Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=168624 Attachment 151156: Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public http://bugzilla.mozilla.org/attachment.cgi?id=151156&action=edit ...

superreview requested: [Bug 168624] Microsoft Narrator hangs Mozilla : [Attachment 151156] Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public #3
Darin Fisher (IBM) <darin@meer.net> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 168624: Microsoft Narrator hangs Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=168624 Attachment 151156: Fix build error for atk by makeing nsAccessNode::gLastFocusedNode public http://bugzilla.mozilla.org/attachment.cgi?id=151156&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> I'm sorry, I don't know this code well enough to provide you with a reasonable review. Since focus stuff is involved, I'm goi...

superreview requested: [Bug 351246] Load some of Mozilla into Highmem on OS/2 : [Attachment 248070] Mozilla build changes
Peter Weilbacher <mozilla@Weilbacher.org> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 351246: Load some of Mozilla into Highmem on OS/2 https://bugzilla.mozilla.org/show_bug.cgi?id=351246 Attachment 248070: Mozilla build changes https://bugzilla.mozilla.org/attachment.cgi?id=248070&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> Changes to the Mozilla build system. These were also adapted following earlier comments. ...

superreview requested: [Bug 244193] Giving out the wrong IAccessible for top Mozilla content and UI windows : [Attachment 148957] This patch makes us work with Window-Eyes, at least partially
Aaron Leventhal <aaronleventhal@moonset.net> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244193: Giving out the wrong IAccessible for top Mozilla content and UI windows http://bugzilla.mozilla.org/show_bug.cgi?id=244193 Attachment 148957: This patch makes us work with Window-Eyes, at least partially http://bugzilla.mozilla.org/attachment.cgi?id=148957&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net> This is a followup to the mousepad scroll bug that also fixes screen reader support. ...