Vladimir Vukicevic (:vlad) <firstname.lastname@example.org> has asked Boris Zbarsky <email@example.com> for superreview: Bug 267422: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=267422 Attachment 198372: print-preview-fix.patch https://bugzilla.mozilla.org/attachment.cgi?id=198372&action=edit ------- Additional Comments from Vladimir Vukicevic (:vlad) <firstname.lastname@example.org> This is not an ideal fix. However, it does work. This also fixes bug 302495. Whenever a print setting is changed, to get the right reflow mechanics, this forces an exit/enter of print preview mode; in firefox, this causes the menus/toolbars to flash up on the screen for a second. It's ugly, but it's better than having broken print preview, and things get displayed correctly at that point. Print Preview UI needs to be reworked on the trunk (taking over the window is a pretty bad idea). kInitSaveNativeData isn't used/handled anywhere in the code, so PrintUtils.savePrintSettings() wasn't saving anything useful. Got rid of that function and had the toolbar save expliticlty what it needs to save. We also don't clear out the enter/exit pp callbacks once we've called them once; this /shouldn't/ break anything, but I'm not sure if tbird or something has some complex behaviour in here. Setting r? mscott/bz, since I have no idea who can review this quickly..