superreview requested: [Bug 267422] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 198379] print-preview-fix.patch (version 2)

Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has asked Mike Connor
<mconnor@mozilla.com> for superreview:
Bug 267422: Print Preview window is partly overlayed by background and is
missing scrollbars
https://bugzilla.mozilla.org/show_bug.cgi?id=267422

Attachment 198379: print-preview-fix.patch (version 2)
https://bugzilla.mozilla.org/attachment.cgi?id=198379&action=edit

------- Additional Comments from Vladimir Vukicevic (:vlad)
<vladimir@pobox.com>
Much better patch.  Just hide/show the print preview toolbar; it doesn't even
look horrible doing it this way, and there's very little risk since we don't
change the semantics of the preview callbacks.
0
bugzilla
10/3/2005 11:46:35 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
512 Views

Similar Articles

[PageSpeed] 17

Reply:

Similar Artilces:

superreview granted: [Bug 267422] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 198379] print-preview-fix.patch (version 2)
Mike Connor <mconnor@mozilla.com> has granted Vladimir Vukicevic (:vlad) <vladimir@pobox.com>'s request for superreview: Bug 267422: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=267422 Attachment 198379: print-preview-fix.patch (version 2) https://bugzilla.mozilla.org/attachment.cgi?id=198379&action=edit ...

superreview requested: [Bug 267422] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 198372] print-preview-fix.patch #2
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 267422: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=267422 Attachment 198372: print-preview-fix.patch https://bugzilla.mozilla.org/attachment.cgi?id=198372&action=edit ------- Additional Comments from Vladimir Vukicevic (:vlad) <vladimir@pobox.com> This is not an ideal fix. However, it does work. This also fixes bug 302495. Whenever a print setting is changed, to ...

superreview requested: [Bug 267422] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 198372] print-preview-fix.patch
Scott MacGregor <mscott@mozilla.org> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 267422: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=267422 Attachment 198372: print-preview-fix.patch https://bugzilla.mozilla.org/attachment.cgi?id=198372&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> switching to mike for the 2nd review since bz is gone. I've been testing with this patch and can confirm that it makes things better for...

superreview cancelled: [Bug 267422] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 198372] print-preview-fix.patch
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has cancelled Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 267422: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=267422 Attachment 198372: print-preview-fix.patch https://bugzilla.mozilla.org/attachment.cgi?id=198372&action=edit ...

superreview requested: [Bug 311028] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 207272] gInPrintPreviewMode patch v0.1e
Ian Neal <iann_bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 311028: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=311028 Attachment 207272: gInPrintPreviewMode patch v0.1e https://bugzilla.mozilla.org/attachment.cgi?id=207272&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@arlen.demon.co.uk> Changes since v0.1d: * Put gInPrintPreviewMode setting back into browser.js it works in navigator.js * Removed unus...

superreview requested: [Bug 311028] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 207039] Collapsed browser patch v0.1c
Ian Neal <iann_bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 311028: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=311028 Attachment 207039: Collapsed browser patch v0.1c https://bugzilla.mozilla.org/attachment.cgi?id=207039&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@arlen.demon.co.uk> leaving _debug as is as was put back in after removing in a previous patch - discussed with Neil on IRC ...

superreview requested: [Bug 311028] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 207227] Non-allcaps patch with editor/mail changes too v0.1d
Ian Neal <iann_bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 311028: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=311028 Attachment 207227: Non-allcaps patch with editor/mail changes too v0.1d https://bugzilla.mozilla.org/attachment.cgi?id=207227&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@arlen.demon.co.uk> Changes from v0.1c: * Removed all caps variable names * Fixed printing.js and editor.js so print...

superreview granted: [Bug 311028] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 207272] gInPrintPreviewMode patch v0.1e
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <iann_bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 311028: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=311028 Attachment 207272: gInPrintPreviewMode patch v0.1e https://bugzilla.mozilla.org/attachment.cgi?id=207272&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx very much for taking this on. ...

superreview granted: [Bug 311028] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 207039] Collapsed browser patch v0.1c
David Bienvenu <bienvenu@nventure.com> has granted Ian Neal <iann_bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 311028: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=311028 Attachment 207039: Collapsed browser patch v0.1c https://bugzilla.mozilla.org/attachment.cgi?id=207039&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> why the all upper-case var names? e.g.? Is this a new fad I'm not up on? :-) + var PRINTPROMPTSVC...

superreview granted: [Bug 311028] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 207225] Non duplicated patch v0.1c
Ian Neal <iann_bugzilla@arlen.demon.co.uk> has granted Ian Neal <iann_bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 311028: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=311028 Attachment 207225: Non duplicated patch v0.1c https://bugzilla.mozilla.org/attachment.cgi?id=207225&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@arlen.demon.co.uk> Correct version without duplicating diff, carrying over r/sr= ...

superreview cancelled: [Bug 311028] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 207227] Non-allcaps patch with editor/mail changes too v0.1d
Ian Neal <iann_bugzilla@arlen.demon.co.uk> has cancelled Ian Neal <iann_bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 311028: Print Preview window is partly overlayed by background and is missing scrollbars https://bugzilla.mozilla.org/show_bug.cgi?id=311028 Attachment 207227: Non-allcaps patch with editor/mail changes too v0.1d https://bugzilla.mozilla.org/attachment.cgi?id=207227&action=edit ...

superreview requested: [Bug 126802] Printing while in print preview disabled on Unix : [Attachment 333675] patch to enable printing while in print preview
Leon Sha <leon.sha@sun.com> has asked Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> for superreview: Bug 126802: Printing while in print preview disabled on Unix https://bugzilla.mozilla.org/show_bug.cgi?id=126802 Attachment 333675: patch to enable printing while in print preview https://bugzilla.mozilla.org/attachment.cgi?id=333675&action=edit ...

superreview requested: [Bug 307367] [BC] print preview doesn't match print for thin borders on windows : [Attachment 207175] patch #2
Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 307367: [BC] print preview doesn't match print for thin borders on windows https://bugzilla.mozilla.org/show_bug.cgi?id=307367 Attachment 207175: patch https://bugzilla.mozilla.org/attachment.cgi?id=207175&action=edit ------- Additional Comments from Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> Looks reasonable to me, but I'd really like roc to glance at this, since he understands the distin...

superreview requested: [Bug 226973] Print Preview Error (Previewing During Page Rendering/No Printer Installed) Shows Print Preview Toolbar : [Attachment 155015] fix
Jan Varga <varga@mozilla-europe.org> has asked Ben Goodger <bugs@bengoodger.com> for superreview: Bug 226973: Print Preview Error (Previewing During Page Rendering/No Printer Installed) Shows Print Preview Toolbar http://bugzilla.mozilla.org/show_bug.cgi?id=226973 Attachment 155015: fix http://bugzilla.mozilla.org/attachment.cgi?id=155015&action=edit ...

Web resources about - superreview requested: [Bug 267422] Print Preview window is partly overlayed by background and is missing scrollbars : [Attachment 198379] print-preview-fix.patch (version 2) - netscape.mozilla.reviewers

Resources last updated: 11/22/2015 8:05:41 PM