superreview granted: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Mike Pinkerton <pinkerton@aol.net> has granted Bruce Davidson <Bruce.Davidson@iplbath.com>'s request for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink, will land myself. ...

superreview requested: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 163739] Proposed patch
Ludovic Hirlimann <qa-mozilla@hirlimann.net> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 163739: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=163739&action=edit ...

superreview granted: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 163739] Proposed patch
Mike Pinkerton <pinkerton@aol.net> has granted Ludovic Hirlimann <qa-mozilla@hirlimann.net>'s request for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 163739: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=163739&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink ...

superreview denied: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 163739] Proposed patch
Mike Pinkerton <pinkerton@aol.net> has denied Mike Pinkerton <pinkerton@aol.net>'s request for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 163739: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=163739&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> actually i'd like a better fix for this. if the separator button is only enabled for bookmarks, then just call the |-setEnabled:| onc...

superreview requested: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 173081] updated patch to reflect Mike's comment
olivier@umich.edu has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 173081: updated patch to reflect Mike's comment https://bugzilla.mozilla.org/attachment.cgi?id=173081&action=edit ------- Additional Comments from olivier@umich.edu did a mistake on the previous one, so here is the correct patch ...

superreview requested: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 173080] updated patch file to reflect Mike's comments
olivier@umich.edu has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 173080: updated patch file to reflect Mike's comments https://bugzilla.mozilla.org/attachment.cgi?id=173080&action=edit ...

superreview cancelled: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 173081] updated patch to reflect Mike's comment
Mike Pinkerton <pinkerton@aol.net> has cancelled olivier@umich.edu's request for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 173081: updated patch to reflect Mike's comment https://bugzilla.mozilla.org/attachment.cgi?id=173081&action=edit ...

superreview cancelled: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 173080] updated patch file to reflect Mike's comments
Mike Pinkerton <pinkerton@aol.net> has cancelled olivier@umich.edu's request for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 173080: updated patch file to reflect Mike's comments https://bugzilla.mozilla.org/attachment.cgi?id=173080&action=edit ...

superreview requested: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 181275] patch with pinkerton's comments addresed
Torben <torben@despammed.com> has asked Simon Fraser (on vacation) <sfraser_bugs@smfr.org> for superreview: Bug 90918: RFE: Add url in "comments" field of the "get info" window when download file. https://bugzilla.mozilla.org/show_bug.cgi?id=90918 Attachment 181275: patch with pinkerton's comments addresed https://bugzilla.mozilla.org/attachment.cgi?id=181275&action=edit ------- Additional Comments from Torben <torben@despammed.com> > does this only happen when dragging files? > what about when downloading them via normal means? ...

superreview requested: [Bug 246750] Can't read menu/menuitem's "keyboard shortcut" and "accesskey" : [Attachment 150781] patch v1
Louie Zhao <Louie.Zhao@sun.com> has asked Henry Jia <Henry.Jia@sun.com> for superreview: Bug 246750: Can't read menu/menuitem's "keyboard shortcut" and "accesskey" http://bugzilla.mozilla.org/show_bug.cgi?id=246750 Attachment 150781: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=150781&action=edit ...

superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...

superreview requested: [Bug 237228] pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js : [Attachment 158389] patch, add UnregisterPrefCallback
Ginn Chen <ginn.chen@sun.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 237228: pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js http://bugzilla.mozilla.org/show_bug.cgi?id=237228 Attachment 158389: patch, add UnregisterPrefCallback http://bugzilla.mozilla.org/attachment.cgi?id=158389&action=edit ...

superreview granted: [Bug 225809] Don't fall back to insecure authentication if "use secure authentication" is checked : [Attachment 136279] patch addressing mscott's comments
Lorenzo Colitti <lorenzo@colitti.com> has granted Lorenzo Colitti <lorenzo@colitti.com>'s request for superreview: Bug 225809: Don't fall back to insecure authentication if "use secure authentication" is checked http://bugzilla.mozilla.org/show_bug.cgi?id=225809 Attachment 136279: patch addressing mscott's comments http://bugzilla.mozilla.org/attachment.cgi?id=136279&action=edit ------- Additional Comments from Lorenzo Colitti <lorenzo@colitti.com> Carrying forward r= and sr= ...

superreview requested: [Bug 47475] Need "Show(View) Image" / "Reload Image" on context menu : [Attachment 233530] unrotted, addressing bz's review comments from before
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 47475: Need "Show(View) Image" / "Reload Image" on context menu https://bugzilla.mozilla.org/show_bug.cgi?id=47475 Attachment 233530: unrotted, addressing bz's review comments from before https://bugzilla.mozilla.org/attachment.cgi?id=233530&action=edit ...