superreview requested: [Bug 264980] [MASv1.8a2++] Installer crashes when using Alt-N key on 'Select Components' step of 'Custom' install : [Attachment 174245] (Av1) <setuprsc.rc>

Serge GAUTHERIE <gautheri@noos.fr> has asked Daniel Veditz <dveditz@cruzio.com>
for superreview:
Bug 264980: [MASv1.8a2++] Installer crashes when using Alt-N key on 'Select
Components'  step of 'Custom' install
https://bugzilla.mozilla.org/show_bug.cgi?id=264980

Attachment 174245: (Av1) <setuprsc.rc>
https://bugzilla.mozilla.org/attachment.cgi?id=174245&action=edit

------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
Per comment 14 suggestion.

I have no compiler: Could you compile/test/(super-)review this patch ? Thanks.

PS: Could you update your "unreferenced" 'dveditz+bmo@cruzio.com' on
<http://www.mozilla.org/hacking/reviewers.html> ? Thanks.
0
bugzilla
2/13/2005 7:40:47 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
541 Views

Similar Articles

[PageSpeed] 27

Reply:

Similar Artilces:

superreview granted: [Bug 264980] [MASv1.8a2++] Installer crashes when using Alt-N key on 'Select Components' step of 'Custom' install : [Attachment 174245] (Av1) <setuprsc.rc>
Daniel Veditz <dveditz@cruzio.com> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 264980: [MASv1.8a2++] Installer crashes when using Alt-N key on 'Select Components' step of 'Custom' install https://bugzilla.mozilla.org/show_bug.cgi?id=264980 Attachment 174245: (Av1) <setuprsc.rc> https://bugzilla.mozilla.org/attachment.cgi?id=174245&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> r+sr=dveditz ...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 137404] (Av1) <nsInternetSearchService.cpp>
Serge GAUTHERIE <gautheri@noos.fr> has asked Alec Flett <alecf@flett.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 137404: (Av1) <nsInternetSearchService.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=137404&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> 'r=?': (see comment 2) Can you (super-)review, compile, test, check it in ? ...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 137796] (Av2) <nsInternetSearchService.cpp>
Serge GAUTHERIE <gautheri@noos.fr> has asked Alec Flett <alecf@flett.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 137796: (Av2) <nsInternetSearchService.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=137796&action=edit ...

superreview cancelled: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 137404] (Av1) <nsInternetSearchService.cpp>
Alec Flett <alecf@flett.org> has cancelled Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 137404: (Av1) <nsInternetSearchService.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=137404&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> reviewers do not compile and test. Don't ask for a review until you've done that much yourself. ...

superreview requested: [Bug 227633] (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR : [Attachment 154285] (Av1a-Bw) <mailnews/*> (review only)
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 227633: (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR http://bugzilla.mozilla.org/show_bug.cgi?id=227633 Attachment 154285: (Av1a-Bw) <mailnews/*> (review only) http://bugzilla.mozilla.org/attachment.cgi?id=154285&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Keeping {{ (Av1_Bw) Fixes most '/mailnews/' '0x0?' occurences (review only) patch 2003-12-06 07:58...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 139060] (Bv1b) </mailnews/addrbook/src/ns*.*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 139060: (Bv1b) </mailnews/addrbook/src/ns*.*> http://bugzilla.mozilla.org/attachment.cgi?id=139060&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> { (Bv1) </mailnews/addrbook/src/ns*.*> patch 2003-12-29 15:10:42 neil.parkwaycc.co.uk: review+ } ...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 139060] (Bv1b) </mailnews/addrbook/src/ns*.*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 139060: (Bv1b) </mailnews/addrbook/src/ns*.*> http://bugzilla.mozilla.org/attachment.cgi?id=139060&action=edit ...

superreview requested: [Bug 227633] (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR : [Attachment 154285] (Av1a-Bw) <mailnews/*> (review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 227633: (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR https://bugzilla.mozilla.org/show_bug.cgi?id=227633 Attachment 154285: (Av1a-Bw) <mailnews/*> (review only) https://bugzilla.mozilla.org/attachment.cgi?id=154285&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No super-review from <sspitzer@mozilla.org> since "2004-07-25" :-( DanM: DanW suggests giving 'rs...

superreview requested: [Bug 414014] SM add-on window should have 'Install' button visible by default : [Attachment 313795] Make the 'Install' button visible by default
Philip Chee <philip.chee@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 414014: SM add-on window should have 'Install' button visible by default https://bugzilla.mozilla.org/show_bug.cgi?id=414014 Attachment 313795: Make the 'Install' button visible by default https://bugzilla.mozilla.org/attachment.cgi?id=313795&action=edit ------- Additional Comments from Philip Chee <philip.chee@gmail.com> Simple one line patch to turn on the "Install" button in the Addon Manager window. ...

superreview requested: [Bug 428803] In <pageinfo/security.js> (Line: 315), "Warning: reference to undefined property Components.classes['@mozilla.org/login-manager; 1']" : [Attachment 320397] (Av1) <s
Serge Gautherie <sgautherie.bz@free.fr> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 428803: In <pageinfo/security.js> (Line: 315), "Warning: reference to undefined property Components.classes['@mozilla.org/login-manager;1']" https://bugzilla.mozilla.org/show_bug.cgi?id=428803 Attachment 320397: (Av1) <security.js> Comment out future code https://bugzilla.mozilla.org/attachment.cgi?id=320397&action=edit ------- Additional Comments from Serge Gautherie <sgautherie.bz@free.fr> [Mozilla/5.0 (Windows; U; Windows...

superreview requested: [Bug 299422] r:/mozilla\netwerk\base\src\nsProtocolProxyService.cpp(74) : warning C4099: 'nsProtocolInfo' : type name first seen using 'class' now seen using 'struct' : [Attach
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Darin Fisher <darin@meer.net> for superreview: Bug 299422: r:/mozilla\netwerk\base\src\nsProtocolProxyService.cpp(74) : warning C4099: 'nsProtocolInfo' : type name first seen using 'class' now seen using 'struct' https://bugzilla.mozilla.org/show_bug.cgi?id=299422 Attachment 187998: fix forward declaration https://bugzilla.mozilla.org/attachment.cgi?id=187998&action=edit ...

superreview requested: [Bug 307122] HTML5 'section' goes in 'head' when </head> and <body> are implicit : [Attachment 195052] restore compat for userdefined tags
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 307122: HTML5 'section' goes in 'head' when </head> and <body> are implicit https://bugzilla.mozilla.org/show_bug.cgi?id=307122 Attachment 195052: restore compat for userdefined tags https://bugzilla.mozilla.org/attachment.cgi?id=195052&action=edit ...

superreview granted: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 137796] (Av2) <nsInternetSearchService.cpp>
Alec Flett <alecf@flett.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 137796: (Av2) <nsInternetSearchService.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=137796&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> sr=alecf then. ...

superreview requested: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Neil: Easy fix, you forgot an arg ;-). ...

Web resources about - superreview requested: [Bug 264980] [MASv1.8a2++] Installer crashes when using Alt-N key on 'Select Components' step of 'Custom' install : [Attachment 174245] (Av1) <setuprsc.rc> - netscape.mozilla.reviewers

Resources last updated: 12/5/2015 5:48:10 AM