superreview requested: [Bug 255123] Opening URL from another app focuses an existing window before opening a new window : [Attachment 161778] Updated patch repsecting loadDivertedInBackground prefere

Dan M <danm.moz@gmail.com> has asked Brian Ryner (IBM) <bryner@brianryner.com>
for superreview:
Bug 255123: Opening URL from another app focuses an existing window before
opening a new window
https://bugzilla.mozilla.org/show_bug.cgi?id=255123

Attachment 161778: Updated patch repsecting loadDivertedInBackground preference
https://bugzilla.mozilla.org/attachment.cgi?id=161778&action=edit

------- Additional Comments from Dan M <danm.moz@gmail.com>
I have mixed feelings about this patch.

(1) It's (mostly) Windows-only, and this is an XP bug. Certainly you can't
close this bug after checking in this patch, though it'll be fixed on Windows.

2) It can move focus from the URLbar to the content area. Yes that part of the
patch was written to address my own comment 30, but it's a little suboptimal.
However I asked Brian "Focus" R. about this and he said "eh?" Let's make him
superreview.

If/when you check this in obviously the browser.js patch will no longer apply
as is. Add those two lines at the end of the |try| clause, just before the
corresponding |catch|.

Formatting gobbledygoo:

I can't tell what whitespace nonsense is responsible for half the lines changed
in nsWindowsShellService.cpp. It would be annoying were unwelcome tab
characters introduced.

Please do take one space out of the long browser.js line (perhaps
"if(!gPrefService...)) to make it fit an 80 character line. Yup, that's still a
requirement.
0
bugzilla
1/18/2005 7:15:39 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
690 Views

Similar Articles

[PageSpeed] 19

Reply:

Similar Artilces:

superreview granted: [Bug 255123] Opening URL from another app focuses an existing window before opening a new window : [Attachment 161778] Updated patch repsecting loadDivertedInBackground preferenc
Brian Ryner (IBM) <bryner@brianryner.com> has granted Dan M <danm.moz@gmail.com>'s request for superreview: Bug 255123: Opening URL from another app focuses an existing window before opening a new window https://bugzilla.mozilla.org/show_bug.cgi?id=255123 Attachment 161778: Updated patch repsecting loadDivertedInBackground preference https://bugzilla.mozilla.org/attachment.cgi?id=161778&action=edit ...

superreview requested: [Bug 310395] Open Link in New Window
froodiantherapy (mostly gone until June 4) <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 310395: Open Link in New Window - new background windows open with Address bar focused https://bugzilla.mozilla.org/show_bug.cgi?id=310395 Attachment 223629: Last Patch before sr? https://bugzilla.mozilla.org/attachment.cgi?id=223629&action=edit ------- Additional Comments from froodiantherapy (mostly gone until June 4) <stridey@gmail.com> Assuming that this has cl+ too. ;) ...

superreview requested: [Bug 279495] A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] : [Attachment 172585] Patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 279495: A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] https://bugzilla.mozilla.org/show_bug.cgi?id=279495 Attachment 172585: Patch https://bugzilla.mozilla.org/attachment.cgi?id=172585&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This basically backs out the "fix" for bug 135811. Now I can't figure out how finding targe...

superreview requested: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 159443] optional addition to divert window.open to a new tab
Dan M <danm.moz@gmail.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 159443: optional addition to divert window.open to a new tab https://bugzilla.mozilla.org/attachment.cgi?id=159443&action=edit ...

superreview requested: [Bug 310395] Open Link in New Window
froodiantherapy <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 310395: Open Link in New Window - new background windows open with Address bar focused https://bugzilla.mozilla.org/show_bug.cgi?id=310395 Attachment 227974: Unbitrots it https://bugzilla.mozilla.org/attachment.cgi?id=227974&action=edit ------- Additional Comments from froodiantherapy <stridey@gmail.com> This patch unbitrots the previous one. It touches all the high-traffic files, and took a long time to get back up to date, so lets try to get this review...

superreview requested: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 161419] don't divert window.open to a new tab if the named wi
Dan M <danm.moz@gmail.com> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 161419: don't divert window.open to a new tab if the named window exists https://bugzilla.mozilla.org/attachment.cgi?id=161419&action=edit ...

superreview cancelled: [Bug 310395] Open Link in New Window
froodiantherapy <stridey@gmail.com> has cancelled froodiantherapy <stridey@gmail.com>'s request for superreview: Bug 310395: Open Link in New Window - new background windows open with Address bar focused https://bugzilla.mozilla.org/show_bug.cgi?id=310395 Attachment 223629: Last Patch before sr? https://bugzilla.mozilla.org/attachment.cgi?id=223629&action=edit ------- Additional Comments from froodiantherapy <stridey@gmail.com> This patch unbitrots the previous one. It touches all the high-traffic files, and took a long time to get back up to date, so let...

superreview requested: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177879] Patch to make externally-launched links open in new window (Seamonkey only)
Jeremy Morton <bugzilla@game-point.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177879: Patch to make externally-launched links open in new window (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177879&action=edit ...

superreview requested: [Bug 355352] [Cocoa] while the app is running, if no browser windows are open, clicking on the app in the dock doesn't open a browser window : [Attachment 248569] New and improv
Josh Aas <joshmoz@gmail.com> has asked Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> for superreview: Bug 355352: [Cocoa] while the app is running, if no browser windows are open, clicking on the app in the dock doesn't open a browser window https://bugzilla.mozilla.org/show_bug.cgi?id=355352 Attachment 248569: New and improved patch https://bugzilla.mozilla.org/attachment.cgi?id=248569&action=edit ------- Additional Comments from Josh Aas <joshmoz@gmail.com> The minor changes remaining (comments mostly) can be made on checkin. ...

superreview requested: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 316692] BrowserOpenTab() even when no windows are open
Stefan <stefanh@bluebottle.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 429926: Make Cmd+T open a new window when no browser windows are open https://bugzilla.mozilla.org/show_bug.cgi?id=429926 Attachment 316692: BrowserOpenTab() even when no windows are open https://bugzilla.mozilla.org/attachment.cgi?id=316692&action=edit ...

superreview requested: [Bug 300485] Launching SeaMonkey when it's already running, with "open in new tab" preference, should opens a new tab rather than window. : [Attachment 189715] Proposed patch (
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 300485: Launching SeaMonkey when it's already running, with "open in new tab" preference, should opens a new tab rather than window. https://bugzilla.mozilla.org/show_bug.cgi?id=300485 Attachment 189715: Proposed patch (Windows) https://bugzilla.mozilla.org/attachment.cgi?id=189715&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> You can't do clever stuff in app startup...

superreview requested: [Bug 159377] tab-group bookmark does nothing when no windows are open : [Attachment 139408] revised patch plus open bookmarks group in new window
Andreas Kunz <durbacher@gmx.de> has asked Alec Flett <alecf@flett.org> for superreview: Bug 159377: tab-group bookmark does nothing when no windows are open http://bugzilla.mozilla.org/show_bug.cgi?id=159377 Attachment 139408: revised patch plus open bookmarks group in new window http://bugzilla.mozilla.org/attachment.cgi?id=139408&action=edit ------- Additional Comments from Andreas Kunz <durbacher@gmx.de> Requesting sr= from alecf. pch: my tree does not include Firebird, so all I could possibly do is write the patch, but not test it. ...

superreview requested: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) : [Attachment 173746] patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked T Rowley (IBM) <tor@acm.org> for superreview: Bug 250936: Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) https://bugzilla.mozilla.org/show_bug.cgi?id=250936 Attachment 173746: patch https://bugzilla.mozilla.org/attachment.cgi?id=173746&action=edit ...

superreview requested: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 159442] base code to control where URLs are opened
Dan M <danm.moz@gmail.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) http://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 159442: base code to control where URLs are opened http://bugzilla.mozilla.org/attachment.cgi?id=159442&action=edit ...

Web resources about - superreview requested: [Bug 255123] Opening URL from another app focuses an existing window before opening a new window : [Attachment 161778] Updated patch repsecting loadDivertedInBackground prefere - netscape.mozilla.reviewers

Resources last updated: 12/29/2015 1:21:38 PM