superreview requested: [Bug 252780] Roaming Access needs to be documented in help : [Attachment 172544] First attempt at fixing the bug all at once

Giacomo Magnini <giacomo.magnini@portalis.it> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 252780: Roaming Access needs to be documented in help
https://bugzilla.mozilla.org/show_bug.cgi?id=252780

Attachment 172544: First attempt at fixing the bug all at once
https://bugzilla.mozilla.org/attachment.cgi?id=172544&action=edit

------- Additional Comments from Giacomo Magnini <giacomo.magnini@portalis.it>
Ok, I've made the following:
1) Split preferences from description paragraph
2) Modified pref-help.js to link up the help button to the right sections
3) Modified help-toc.rdf to show roaming profiles under the profile section
(preferences are in their own subparagraph)
4) Added an entry in help-indez1.rdf
5) Added an entry in help-glossary.rdf
6) Added an entry to glossary.xhtml (PLEASE double check!)

Built locally on linux and everything seems to work fine (links work and show
correctly, no js errors in console).
This has gone a little further than planned...
0
bugzilla
1/27/2005 9:34:50 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
334 Views

Similar Articles

[PageSpeed] 15

Reply:

Similar Artilces:

superreview granted: [Bug 252780] Roaming Access needs to be documented in help : [Attachment 172544] First attempt at fixing the bug all at once
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Giacomo Magnini <giacomo.magnini@portalis.it>'s request for superreview: Bug 252780: Roaming Access needs to be documented in help https://bugzilla.mozilla.org/show_bug.cgi?id=252780 Attachment 172544: First attempt at fixing the bug all at once https://bugzilla.mozilla.org/attachment.cgi?id=172544&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> I assume the copyright lines in changed files need updating. >+ <rdf:li><...

superreview granted: [Bug 252780] Roaming Access needs to be documented in help : [Attachment 172648] Added new examples, ungrouped Roaming sections and removed h1...
Giacomo Magnini <giacomo.magnini@portalis.it> has granted Giacomo Magnini <giacomo.magnini@portalis.it>'s request for superreview: Bug 252780: Roaming Access needs to be documented in help https://bugzilla.mozilla.org/show_bug.cgi?id=252780 Attachment 172648: Added new examples, ungrouped Roaming sections and removed h1... https://bugzilla.mozilla.org/attachment.cgi?id=172648&action=edit ------- Additional Comments from Giacomo Magnini <giacomo.magnini@portalis.it> I think this is ready to go. Carrying over r/sr flags. Can someone please check this in? T...

superreview granted: [Bug 252780] Roaming Access needs to be documented in help : [Attachment 172649] Missed a retun to begin of section, humf...
Giacomo Magnini <giacomo.magnini@portalis.it> has granted Giacomo Magnini <giacomo.magnini@portalis.it>'s request for superreview: Bug 252780: Roaming Access needs to be documented in help https://bugzilla.mozilla.org/show_bug.cgi?id=252780 Attachment 172649: Missed a retun to begin of section, humf... https://bugzilla.mozilla.org/attachment.cgi?id=172649&action=edit ...

superreview granted: [Bug 252780] Roaming Access needs to be documented in help : [Attachment 172567] Updated patch to cope with Neil's suggestions, ready for checkin after Ben's approval
Giacomo Magnini <giacomo.magnini@portalis.it> has granted Giacomo Magnini <giacomo.magnini@portalis.it>'s request for superreview: Bug 252780: Roaming Access needs to be documented in help https://bugzilla.mozilla.org/show_bug.cgi?id=252780 Attachment 172567: Updated patch to cope with Neil's suggestions, ready for checkin after Ben's approval https://bugzilla.mozilla.org/attachment.cgi?id=172567&action=edit ...

superreview requested: [Bug 292962] Need to sort out policy on DOM access in cached documents : [Attachment 187179] patch to fix
Jonas Sicking <bugmail@sicking.cc> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292962: Need to sort out policy on DOM access in cached documents https://bugzilla.mozilla.org/show_bug.cgi?id=292962 Attachment 187179: patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=187179&action=edit ------- Additional Comments from Jonas Sicking <bugmail@sicking.cc> I had to add the mDocument member because some callsites first calls Destroy() on the contentviewer before calling SetContentViewer(nsnull) on the SHEntry. In that case we would...

superreview requested: [Bug 292962] Need to sort out policy on DOM access in cached documents : [Attachment 198313] Fix remaining issues
Jonas Sicking <bugmail@sicking.cc> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292962: Need to sort out policy on DOM access in cached documents https://bugzilla.mozilla.org/show_bug.cgi?id=292962 Attachment 198313: Fix remaining issues https://bugzilla.mozilla.org/attachment.cgi?id=198313&action=edit ------- Additional Comments from Jonas Sicking <bugmail@sicking.cc> This should take care of the remaining issues I hope. I've beaten this hard and it seems to behave properly. While the document is in the bf cache it is unaware of i...

superreview requested: [Bug 292962] Need to sort out policy on DOM access in cached documents : [Attachment 198352] Fix remaining issues v2
Jonas Sicking <bugmail@sicking.cc> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292962: Need to sort out policy on DOM access in cached documents https://bugzilla.mozilla.org/show_bug.cgi?id=292962 Attachment 198352: Fix remaining issues v2 https://bugzilla.mozilla.org/attachment.cgi?id=198352&action=edit ------- Additional Comments from Jonas Sicking <bugmail@sicking.cc> Fixes comments by bryner. I also made the event hold a reference to the document just so that the document doesn't die if contentviewer releases the reference it is...

superreview requested: [Bug 241469] Help interface not keyboard accessible : [Attachment 150276] Fixed fix
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 241469: Help interface not keyboard accessible http://bugzilla.mozilla.org/show_bug.cgi?id=241469 Attachment 150276: Fixed fix http://bugzilla.mozilla.org/attachment.cgi?id=150276&action=edit ...

superreview requested: [Bug 359392] [FIX]Very slow rendering of the top bar on mozilla.org : [Attachment 246930] Fix one more arithmetic bug
Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 359392: [FIX]Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246930: Fix one more arithmetic bug https://bugzilla.mozilla.org/attachment.cgi?id=246930&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This should be the last patch, honest! ;) ...

superreview requested: [Bug 215798] Running Venkman crashes Mozilla [@ JS_GetPrivate ] : [Attachment 131582] patch to fix the GC safety bug, plus a few warning fixes
Brendan Eich <brendan@mozilla.org> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 215798: Running Venkman crashes Mozilla [@ JS_GetPrivate ] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131582: patch to fix the GC safety bug, plus a few warning fixes http://bugzilla.mozilla.org/attachment.cgi?id=131582&action=edit ...

superreview requested: [Bug 263406] [FIX]abs/fixed pos handling (placeholder, etc) needs consolidation : [Attachment 163244] Patch without changes from bug 263846
Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 263406: [FIX]abs/fixed pos handling (placeholder, etc) needs consolidation https://bugzilla.mozilla.org/show_bug.cgi?id=263406 Attachment 163244: Patch without changes from bug 263846 https://bugzilla.mozilla.org/attachment.cgi?id=163244&action=edit ...

superreview requested: [Bug 280947] Fix for bug 279945 breaks dragging of dynamic images : [Attachment 174494] Additional patch needed to download the right file with the fixed extension
Johnny Stenback <jst@mozilla.org> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 280947: Fix for bug 279945 breaks dragging of dynamic images https://bugzilla.mozilla.org/show_bug.cgi?id=280947 Attachment 174494: Additional patch needed to download the right file with the fixed extension https://bugzilla.mozilla.org/attachment.cgi?id=174494&action=edit ...

superreview requested: [Bug 319463] display:none iframe pointing to a xul document stops main document from finishing to load. : [Attachment 207948] Patch to fix regression in bug 322701
Bill Gianopoulos <wgianopoulos@yahoo.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 319463: display:none iframe pointing to a xul document stops main document from finishing to load. https://bugzilla.mozilla.org/show_bug.cgi?id=319463 Attachment 207948: Patch to fix regression in bug 322701 https://bugzilla.mozilla.org/attachment.cgi?id=207948&action=edit ...

superreview requested: [Bug 245066] [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) : [Attachment 156344] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 245066: [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) http://bugzilla.mozilla.org/show_bug.cgi?id=245066 Attachment 156344: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=156344&action=edit ...

Web resources about - superreview requested: [Bug 252780] Roaming Access needs to be documented in help : [Attachment 172544] First attempt at fixing the bug all at once - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/9/2016 10:52:46 AM