superreview requested: [Bug 250828] When i use global inbox, thunderbird does not use localized string "Inbox". : [Attachment 160458] possible fix

Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 250828: When i use global inbox, thunderbird does not use localized string
"Inbox".
https://bugzilla.mozilla.org/show_bug.cgi?id=250828

Attachment 160458: possible fix
https://bugzilla.mozilla.org/attachment.cgi?id=160458&action=edit

------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
What do you think of this David?

On startup, we weren't setting the MSG_FOLDER_FLAG_INBOX on the root local
folder.

As a result we never ended up calling:

nsMsgLocalMailFolder::SetFlagsOnDefaultMailboxes(PRUint32 flags)
{
  if (flags & MSG_FOLDER_FLAG_INBOX)
    setSubfolderFlag(NS_LITERAL_STRING("Inbox").get(), MSG_FOLDER_FLAG_INBOX);

this in turn calls SetPrettyName on the inbox folder which causes us to use the
localized name for "Inbox".

This patch checks to see if the incoming server is  acting as the deferred
account. If it is, then pass in the inbox flag so our inbox gets a pretty name.


One thing I wasn't sure of. I noticed I had an Inbox under Local Folders  in my
profile and I've never set up a deferred account before. so with this patch,
that name never got the localized name set on it. Was it a fluke that I even
had an inbox showing up under local folders? I wonder how it got created.

If it's possible to get an Inbox here without a deferred account then we should
probably remove my check to make sure the server is acitng as a deferred
account before passing in the folder inbox flag.
0
bugzilla
9/29/2004 7:05:43 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
638 Views

Similar Articles

[PageSpeed] 26

Reply:

Similar Artilces:

superreview granted: [Bug 250828] When i use global inbox, thunderbird does not use localized string "Inbox". : [Attachment 160458] possible fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 250828: When i use global inbox, thunderbird does not use localized string "Inbox". https://bugzilla.mozilla.org/show_bug.cgi?id=250828 Attachment 160458: possible fix https://bugzilla.mozilla.org/attachment.cgi?id=160458&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I like this - I'd fix the comment // "none" doesn't have an inbox - maybe just remove it... ...

superreview requested: [Bug 260141] Some strings in locale files is using "Firefox"
Alexander L. Slovesnik <als@mozilla.ru> has asked for superreview: Bug 260141: Some strings in locale files is using "Firefox" - should use &brandShortName; instead https://bugzilla.mozilla.org/show_bug.cgi?id=260141 Attachment 159777: Patch for updated.dtd only. https://bugzilla.mozilla.org/attachment.cgi?id=159777&action=edit ...

superreview requested: [Bug 260141] Some strings in locale files is using "Firefox"
Alexander L. Slovesnik <als@mozilla.ru> has asked for superreview: Bug 260141: Some strings in locale files is using "Firefox" - should use &brandShortName; instead https://bugzilla.mozilla.org/show_bug.cgi?id=260141 Attachment 159777: Patch for updated.dtd only. https://bugzilla.mozilla.org/attachment.cgi?id=159777&action=edit ...

superreview requested: [Bug 253519] Non-working "Use Global Inbox" option is shown during Movemail account creation : [Attachment 160469] Patch
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 253519: Non-working "Use Global Inbox" option is shown during Movemail account creation https://bugzilla.mozilla.org/show_bug.cgi?id=253519 Attachment 160469: Patch https://bugzilla.mozilla.org/attachment.cgi?id=160469&action=edit ...

superreview requested: [Bug 241181] inconsistent spelling of cancelled or canceled in Mozilla. : [Attachment 146719] Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Fi
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Scott Collins <scc@mozilla.org> for superreview: Bug 241181: inconsistent spelling of cancelled or canceled in Mozilla. http://bugzilla.mozilla.org/show_bug.cgi?id=241181 Attachment 146719: Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Firefox. http://bugzilla.mozilla.org/attachment.cgi?id=146719&action=edit ------- Additional Comments from Bruce Davidson <Bruce.Davidson@iplbath.com> Requesting r/sr (rs=?) on this patch for 1.8 trunk. ...

superreview requested: [Bug 424641] Write profile migrator to make old Thunderbird profiles available under "Mozilla", "~/mozilla", or "Application Support" : [Attachment 318390] The fix v2
Mark Banner <bugzilla@standard8.plus.com> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 424641: Write profile migrator to make old Thunderbird profiles available under "Mozilla", "~/mozilla", or "Application Support" https://bugzilla.mozilla.org/show_bug.cgi?id=424641 Attachment 318390: The fix v2 https://bugzilla.mozilla.org/attachment.cgi?id=318390&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> I'm happy this should work on all platforms. I'll request toolkit revi...

superreview requested: [Bug 329018] Disable "Global Inbox" by default : [Attachment 244892] The (maybe) final version of the "global" patch
Manuel Reimer <Manuel.Spam@nurfuerspam.de> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 329018: Disable "Global Inbox" by default https://bugzilla.mozilla.org/show_bug.cgi?id=329018 Attachment 244892: The (maybe) final version of the "global" patch https://bugzilla.mozilla.org/attachment.cgi?id=244892&action=edit ------- Additional Comments from Manuel Reimer <Manuel.Spam@nurfuerspam.de> Did the changes, but I've used "mail.accountwizard.deferstorage" as pref as "deferStorage" is also the ID ...

superreview requested: [Bug 423956] Global inbox is missing after creating a first account which uses global inbox
Boying Lu <brian.lu@sun.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 423956: Global inbox is missing after creating a first account which uses global inbox - No mail receiving possible then https://bugzilla.mozilla.org/show_bug.cgi?id=423956 Attachment 323981: patch https://bugzilla.mozilla.org/attachment.cgi?id=323981&action=edit ...

superreview requested: [Bug 187768] allow filter of "To or CC" to use "is in Address Book..." and "is not in Address Book..." : [Attachment 325639] Fixed Standard8's nits
Kent James (:rkent) <kent@caspia.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 187768: allow filter of "To or CC" to use "is in Address Book..." and "is not in Address Book..." https://bugzilla.mozilla.org/show_bug.cgi?id=187768 Attachment 325639: Fixed Standard8's nits https://bugzilla.mozilla.org/attachment.cgi?id=325639&action=edit ------- Additional Comments from Kent James (:rkent) <kent@caspia.com> Fixed Standard8's issues, generally updated unit test to the most recent standards. Carryi...

superreview requested: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156227] use Grant/Cancel
Steffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156227: use Grant/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156227&action=edit ------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de> Grant/Cancel is better indeed. ...

superreview requested: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156223] use OK/Cancel
Steffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156223: use OK/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156223&action=edit ------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de> Brian, this is really simple, yet a 1.0PR blocker. ...

superreview requested: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174088] updated patch
Hasse <jasajudeju@telia.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174088: updated patch https://bugzilla.mozilla.org/attachment.cgi?id=174088&action=edit ------- Additional Comments from Hasse <jasajudeju@telia.com> Don't remove the "<key key=" lines. ...

superreview requested: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174078] proposed patch
Hasse <jasajudeju@telia.com> has asked Daniel Brooks <db48x@yahoo.com> for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174078: proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=174078&action=edit ...

superreview requested: [Bug 285911] XPrint hardcodes english string with literal "Mozilla" : [Attachment 183036] Just remove "Mozilla" from the string
Ian Neal <bugzilla@arlen.demon.co.uk> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 285911: XPrint hardcodes english string with literal "Mozilla" https://bugzilla.mozilla.org/show_bug.cgi?id=285911 Attachment 183036: Just remove "Mozilla" from the string https://bugzilla.mozilla.org/attachment.cgi?id=183036&action=edit ------- Additional Comments from Ian Neal <bugzilla@arlen.demon.co.uk> No sign of roland ...

Web resources about - superreview requested: [Bug 250828] When i use global inbox, thunderbird does not use localized string "Inbox". : [Attachment 160458] possible fix - netscape.mozilla.reviewers

Resources last updated: 2/8/2016 10:56:23 AM