superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149404] Cleanup

neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Robert
O'Callahan <roc@ocallahan.org> for superreview:
Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't
change which option is selected
http://bugzilla.mozilla.org/show_bug.cgi?id=244761

Attachment 149404: Cleanup
http://bugzilla.mozilla.org/attachment.cgi?id=149404&action=edit

------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
Whoops, I accidentally mixed up part of this with another patch. Someone please
remind me not to kill ToggleList :-)

I changed the logic for firing on change events. FireOnChange is now called
whenever the combo box is clicked, blurred, or return is hit, and the combo box
gets to veto the change if the saved index is still current. This avoid firing
the change event if you change the selection with the keyboard, then drop the
list down and reselect the original item. Also moving the FireOnSelect code out
of ComboboxFinish allows me to centralize the code for DOM_VK_RETURN (which
should be named DOM_VK_ENTER, but that's another bug).
0
bugzilla
5/27/2004 4:59:49 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
496 Views

Similar Articles

[PageSpeed] 12

Reply: