superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149378] Change the check for if the dropdown is show

Doron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan
<roc@ocallahan.org> for superreview:
Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't
change which option is selected
http://bugzilla.mozilla.org/show_bug.cgi?id=244761

Attachment 149378: Change the check for if the dropdown is shown to the correct
way
http://bugzilla.mozilla.org/attachment.cgi?id=149378&action=edit
0
bugzilla
5/26/2004 10:28:58 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
707 Views

Similar Articles

[PageSpeed] 41

Reply:

Similar Artilces:

superreview cancelled: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149378] Change the check for if the dropdown is show
Simon Paquet (back in business) <bugzilla@babylonsounds.com> has cancelled Doron Rosenberg (IBM) <doronr@us.ibm.com>'s request for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149378: Change the check for if the dropdown is shown to the correct way http://bugzilla.mozilla.org/attachment.cgi?id=149378&action=edit ------- Additional Comments from Simon Paquet (back in business) <bugzilla@babylonsounds.com> ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149416] Patch for 1.7 per roc
Doron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149416: Patch for 1.7 per roc - adding a if() check http://bugzilla.mozilla.org/attachment.cgi?id=149416&action=edit ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149404] Cleanup
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149404: Cleanup http://bugzilla.mozilla.org/attachment.cgi?id=149404&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Whoops, I accidentally mixed up part of this with another patch. Someone please ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149525] Work around focus issue
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Richard Suitor <rsuitor@acm.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149525: Work around focus issue http://bugzilla.mozilla.org/attachment.cgi?id=149525&action=edit ...

superreview granted: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149416] Patch for 1.7 per roc
Robert O'Callahan <roc@ocallahan.org> has granted Doron Rosenberg (IBM) <doronr@us.ibm.com>'s request for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149416: Patch for 1.7 per roc - adding a if() check http://bugzilla.mozilla.org/attachment.cgi?id=149416&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> + if (mComboBoxFrame != nsnull) { should be + if (...

superreview granted: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149404] Cleanup
Robert O'Callahan <roc@ocallahan.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149404: Cleanup http://bugzilla.mozilla.org/attachment.cgi?id=149404&action=edit ...

superreview requested: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The problem is that "if (aDesiredSize.width > dropdownDesiredSize.width)" is false so we never do the second...

superreview granted: [Bug 242760] code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change : [Attachment 147787] store rc's so ifs can check, drop temporary comptr, chang
Johnny Stenback <jst@mozilla.jstenback.com> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 242760: code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change http://bugzilla.mozilla.org/show_bug.cgi?id=242760 Attachment 147787: store rc's so ifs can check, drop temporary comptr, change comment, check alloc http://bugzilla.mozilla.org/attachment.cgi?id=147787&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> - element->Append...

superreview requested: [Bug 112281] ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items : [Attachment 135533] Proposed patch
Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 112281: ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items http://bugzilla.mozilla.org/show_bug.cgi?id=112281 Attachment 135533: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=135533&action=edit ------- Additional Comments from Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> roc, what do you think? ...

superreview requested: [Bug 242760] code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change : [Attachment 147787] store rc's so ifs can check, drop temporary comptr, cha
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 242760: code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change http://bugzilla.mozilla.org/show_bug.cgi?id=242760 Attachment 147787: store rc's so ifs can check, drop temporary comptr, change comment, check alloc http://bugzilla.mozilla.org/attachment.cgi?id=147787&action=edit ...

superreview granted: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Looks reasonable. Watch Tp carefully, though! ...

superreview requested: [Bug 283345] Description of Profile Manager's <dialogheader> isn't updated when switching from Select Profile to Manage Profile mode : [Attachment 175337] Patch
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 283345: Description of Profile Manager's <dialogheader> isn't updated when switching from Select Profile to Manage Profile mode https://bugzilla.mozilla.org/show_bug.cgi?id=283345 Attachment 175337: Patch https://bugzilla.mozilla.org/attachment.cgi?id=175337&action=edit ------- Additional Comments from Stefan Borggraefe <Stefan.Borggraefe@gmx.de> The code used the wrong attribute to update this UI string. ...

superreview requested: [Bug 306437] change event fires twice for HTML select (mousedown & mouseup) : [Attachment 194591] Don't know how the UpdateSelection() call snuck in. It's clearly wrong.
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 306437: change event fires twice for HTML select (mousedown & mouseup) https://bugzilla.mozilla.org/show_bug.cgi?id=306437 Attachment 194591: Don't know how the UpdateSelection() call snuck in. It's clearly wrong. https://bugzilla.mozilla.org/attachment.cgi?id=194591&action=edit ...

superreview requested: [Bug 269561] Dropup/dropdown boxes leave gray box visible after selection if <select> has height/width on Mac : [Attachment 171565] Don't set mVisible to true willy-nilly
Simon Fraser <sfraser_bugs@smfr.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 269561: Dropup/dropdown boxes leave gray box visible after selection if <select> has height/width on Mac https://bugzilla.mozilla.org/show_bug.cgi?id=269561 Attachment 171565: Don't set mVisible to true willy-nilly https://bugzilla.mozilla.org/attachment.cgi?id=171565&action=edit ...

Web resources about - superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149378] Change the check for if the dropdown is show - netscape.mozilla.reviewers

Resources last updated: 12/22/2015 8:03:17 AM