superreview requested: [Bug 242760] code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change : [Attachment 147787] store rc's so ifs can check, drop temporary comptr, cha

timeless@myrealbox.com (working) <timeless@bemail.org> has asked Johnny
Stenback <jst@mozilla.jstenback.com> for superreview:
Bug 242760: code cleaning: rechecking checked rc's, dropping a temporary
comptr, a comment change
http://bugzilla.mozilla.org/show_bug.cgi?id=242760

Attachment 147787: store rc's so ifs can check, drop temporary comptr, change
comment, check alloc
http://bugzilla.mozilla.org/attachment.cgi?id=147787&action=edit
0
bugzilla
5/6/2004 6:40:14 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
676 Views

Similar Articles

[PageSpeed] 38

Reply:

Similar Artilces:

superreview granted: [Bug 242760] code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change : [Attachment 147787] store rc's so ifs can check, drop temporary comptr, chang
Johnny Stenback <jst@mozilla.jstenback.com> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 242760: code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change http://bugzilla.mozilla.org/show_bug.cgi?id=242760 Attachment 147787: store rc's so ifs can check, drop temporary comptr, change comment, check alloc http://bugzilla.mozilla.org/attachment.cgi?id=147787&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> - element->Append...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149378] Change the check for if the dropdown is show
Doron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149378: Change the check for if the dropdown is shown to the correct way http://bugzilla.mozilla.org/attachment.cgi?id=149378&action=edit ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149416] Patch for 1.7 per roc
Doron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149416: Patch for 1.7 per roc - adding a if() check http://bugzilla.mozilla.org/attachment.cgi?id=149416&action=edit ...

superreview requested: [Bug 232722] change 'character coding' to 'character encoding' : [Attachment 140854] Addressed jshin's comments
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 232722: change 'character coding' to 'character encoding' http://bugzilla.mozilla.org/show_bug.cgi?id=232722 Attachment 140854: Addressed jshin's comments http://bugzilla.mozilla.org/attachment.cgi?id=140854&action=edit ...

superreview cancelled: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149378] Change the check for if the dropdown is show
Simon Paquet (back in business) <bugzilla@babylonsounds.com> has cancelled Doron Rosenberg (IBM) <doronr@us.ibm.com>'s request for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149378: Change the check for if the dropdown is shown to the correct way http://bugzilla.mozilla.org/attachment.cgi?id=149378&action=edit ------- Additional Comments from Simon Paquet (back in business) <bugzilla@babylonsounds.com> ...

superreview requested: [Bug 229737] [RFE] Favicons for XUL error pages : [Attachment 193389] address Neil's comments, fix seamonkey's check
Mike Connor <mconnor@steelgryphon.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 229737: [RFE] Favicons for XUL error pages https://bugzilla.mozilla.org/show_bug.cgi?id=229737 Attachment 193389: address Neil's comments, fix seamonkey's check https://bugzilla.mozilla.org/attachment.cgi?id=193389&action=edit ------- Additional Comments from Mike Connor <mconnor@steelgryphon.com> this addresses all but the 256 color-safe issue, which is an edge case ...

superreview requested: [Bug 303010] Certificate upgrade can drop S/MIME certificates. : [Attachment 191278] remove the incorrect spacing change to the 'if' in ReadSubjectEntry()
Robert Relyea <rrelyea@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 303010: Certificate upgrade can drop S/MIME certificates. https://bugzilla.mozilla.org/show_bug.cgi?id=303010 Attachment 191278: remove the incorrect spacing change to the 'if' in ReadSubjectEntry() https://bugzilla.mozilla.org/attachment.cgi?id=191278&action=edit ...

superreview requested: [Bug 330946] Can drag bookmarks into address book collection of Show All Bookmarks : [Attachment 224328] invalidates drop if it's going to occur on a smart folder's outline view
Chris Lawson <bugzilla@chrislawson.net> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 330946: Can drag bookmarks into address book collection of Show All Bookmarks https://bugzilla.mozilla.org/show_bug.cgi?id=330946 Attachment 224328: invalidates drop if it's going to occur on a smart folder's outline view https://bugzilla.mozilla.org/attachment.cgi?id=224328&action=edit ...

superreview requested: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220886] Addressing more of Gavin's comments
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 220886: Addressing more of Gavin's comments https://bugzilla.mozilla.org/attachment.cgi?id=220886&action=edit ------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com> Gavin's convinced me that there's no need to re...

superreview requested: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220883] Patch addressing Gavin's comments
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 220883: Patch addressing Gavin's comments https://bugzilla.mozilla.org/attachment.cgi?id=220883&action=edit ------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com> Fixed all the problems Gavin noticed; thanks. > Any...

superreview requested: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220997] Patch addressing Joe's comments
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 220997: Patch addressing Joe's comments https://bugzilla.mozilla.org/attachment.cgi?id=220997&action=edit ------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com> (In reply to comment #33) > + if (textBox.value &&a...

superreview requested: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220877] Patch addressing Joe's comments
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 220877: Patch addressing Joe's comments https://bugzilla.mozilla.org/attachment.cgi?id=220877&action=edit ------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com> Thanks. Changes made according to comments throughout; I&#...

superreview granted: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149416] Patch for 1.7 per roc
Robert O'Callahan <roc@ocallahan.org> has granted Doron Rosenberg (IBM) <doronr@us.ibm.com>'s request for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149416: Patch for 1.7 per roc - adding a if() check http://bugzilla.mozilla.org/attachment.cgi?id=149416&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> + if (mComboBoxFrame != nsnull) { should be + if (...

superreview requested: [Bug 285438] Drag and drop gestures can be hijacked to load priviliged xul : [Attachment 179132] XPFE fixes per Neil's suggestion, and only do the security checks when dealing
Johnny Stenback <jst@mozilla.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 285438: Drag and drop gestures can be hijacked to load priviliged xul https://bugzilla.mozilla.org/show_bug.cgi?id=285438 Attachment 179132: XPFE fixes per Neil's suggestion, and only do the security checks when dealing with URI's. https://bugzilla.mozilla.org/attachment.cgi?id=179132&action=edit ...

Web resources about - superreview requested: [Bug 242760] code cleaning: rechecking checked rc's, dropping a temporary comptr, a comment change : [Attachment 147787] store rc's so ifs can check, drop temporary comptr, cha - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/19/2015 2:08:09 PM