superreview requested: [Bug 239226] Opening Forward Message Attachment Opens parent message in a new window : [Attachment 145295] the fix

Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 239226: Opening Forward Message Attachment Opens parent message in a new
window
http://bugzilla.mozilla.org/show_bug.cgi?id=239226

Attachment 145295: the fix
http://bugzilla.mozilla.org/attachment.cgi?id=145295&action=edit

------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
asking Darin for the r=. This was a regression caused  by the string
defragmentation landing. The code in question was causing the url spec for the
underlying nsIURI being run to get modified inadvertantly. I'm calling
BeginWriting on the nsCAutoString before we attempt to modify the underlying
buffer.

Is this ok Darin?
0
bugzilla
4/1/2004 10:33:10 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
623 Views

Similar Articles

[PageSpeed] 59

Reply:

Similar Artilces:

superreview granted: [Bug 239226] Opening Forward Message Attachment Opens parent message in a new window : [Attachment 145295] the fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 239226: Opening Forward Message Attachment Opens parent message in a new window http://bugzilla.mozilla.org/show_bug.cgi?id=239226 Attachment 145295: the fix http://bugzilla.mozilla.org/attachment.cgi?id=145295&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> ok with me if it's ok with Darin. ...

superreview requested: [Bug 284381] open/view/save attachments of .eml file in browser : [Attachment 193466] fix opening of attachments from saved messages
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 284381: open/view/save attachments of .eml file in browser https://bugzilla.mozilla.org/show_bug.cgi?id=284381 Attachment 193466: fix opening of attachments from saved messages https://bugzilla.mozilla.org/attachment.cgi?id=193466&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> this fixes the opening of attachments from saved local messages - the mailbox uri in the case of saved local messages is not useful, so we use t...

superreview requested: [Bug 203570] [message/rfc822] opening a fwd local message has original messages's attachments : [Attachment 199818] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 203570: [message/rfc822] opening a fwd local message has original messages's attachments https://bugzilla.mozilla.org/show_bug.cgi?id=203570 Attachment 199818: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=199818&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> this fixes two problems with local msgs: 1. Opening a forwarded message with inline image attachments displayed broken images. 2. The forwa...

superreview requested: [Bug 241212] Message window for .EML file needs envelope panel : [Attachment 193489] enable opening of attachments from .eml files opened in stand-along window
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 241212: Message window for .EML file needs envelope panel https://bugzilla.mozilla.org/show_bug.cgi?id=241212 Attachment 193489: enable opening of attachments from .eml files opened in stand-along window https://bugzilla.mozilla.org/attachment.cgi?id=193489&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> use url instead of message uri. ...

superreview requested: [Bug 204350] (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) : [Attachment 200351] support reply/forward (as attachment and inlin
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 204350: (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) https://bugzilla.mozilla.org/show_bug.cgi?id=204350 Attachment 200351: support reply/forward (as attachment and inline) for message/rfc822 attachments https://bugzilla.mozilla.org/attachment.cgi?id=200351&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> with this patch, thunderbird supports reply + forward as attachme...

superreview requested: [Bug 303336] [FIX]stack overflow crash when I try to open an attachment with forwarded message : [Attachment 192770] Patch -- use a valid content type
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 303336: [FIX]stack overflow crash when I try to open an attachment with forwarded message https://bugzilla.mozilla.org/show_bug.cgi?id=303336 Attachment 192770: Patch -- use a valid content type https://bugzilla.mozilla.org/attachment.cgi?id=192770&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Darin's on vacation - so I'm taking the liberty of switching the sr request to mscott - hope that's ok! ...

superreview cancelled: [Bug 284381] open/view/save attachments of .eml file in browser : [Attachment 193466] fix opening of attachments from saved messages
David Bienvenu <bienvenu@nventure.com> has cancelled David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 284381: open/view/save attachments of .eml file in browser https://bugzilla.mozilla.org/show_bug.cgi?id=284381 Attachment 193466: fix opening of attachments from saved messages https://bugzilla.mozilla.org/attachment.cgi?id=193466&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> wrong bug, sorry ...

superreview requested: [Bug 201879] RFE
Chris Thomas <cst@andrew.cmu.edu> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 201879: RFE - Warning the user that many message windows are going opened due to a double-click when many messages are selected http://bugzilla.mozilla.org/show_bug.cgi?id=201879 Attachment 140378: New patch http://bugzilla.mozilla.org/attachment.cgi?id=140378&action=edit ...

superreview requested: [Bug 201879] RFE
Chris Thomas <cst@andrew.cmu.edu> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 201879: RFE - Warning the user that many message windows are going opened due to a double-click when many messages are selected http://bugzilla.mozilla.org/show_bug.cgi?id=201879 Attachment 140551: New newer patch http://bugzilla.mozilla.org/attachment.cgi?id=140551&action=edit ...

superreview requested: [Bug 276812] If you define a message filter with Message Filter window open, filter doesn't appear. : [Attachment 170141] Patch to fix regression for Mailnews and TB
Mark Banner <mark@standard8.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 276812: If you define a message filter with Message Filter window open, filter doesn't appear. https://bugzilla.mozilla.org/show_bug.cgi?id=276812 Attachment 170141: Patch to fix regression for Mailnews and TB https://bugzilla.mozilla.org/attachment.cgi?id=170141&action=edit ------- Additional Comments from Mark Banner <mark@standard8.demon.co.uk> This patch adds the missing changes from preselectedFolder to folder for both mailnews and TB. Going...

superreview granted: [Bug 203570] [message/rfc822] opening a fwd local message has original messages's attachments : [Attachment 199818] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 203570: [message/rfc822] opening a fwd local message has original messages's attachments https://bugzilla.mozilla.org/show_bug.cgi?id=203570 Attachment 199818: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=199818&action=edit ...

superreview requested: [Bug 103638] targets with same name in different windows open in wrong window with javascript : [Attachment 170288] Proposed fix, bz's fix with window.open() etc fixed.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 103638: targets with same name in different windows open in wrong window with javascript https://bugzilla.mozilla.org/show_bug.cgi?id=103638 Attachment 170288: Proposed fix, bz's fix with window.open() etc fixed. https://bugzilla.mozilla.org/attachment.cgi?id=170288&action=edit ...

superreview requested: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 316692] BrowserOpenTab() even when no windows are open
Stefan <stefanh@bluebottle.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 429926: Make Cmd+T open a new window when no browser windows are open https://bugzilla.mozilla.org/show_bug.cgi?id=429926 Attachment 316692: BrowserOpenTab() even when no windows are open https://bugzilla.mozilla.org/attachment.cgi?id=316692&action=edit ...

superreview granted: [Bug 241212] Message window for .EML file needs envelope panel : [Attachment 193489] enable opening of attachments from .eml files opened in stand-along window
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 241212: Message window for .EML file needs envelope panel https://bugzilla.mozilla.org/show_bug.cgi?id=241212 Attachment 193489: enable opening of attachments from .eml files opened in stand-along window https://bugzilla.mozilla.org/attachment.cgi?id=193489&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> I don't know what the answer is to Neil's comment about using LOAD_FLAGS_LINK. I know everywhe...

Web resources about - superreview requested: [Bug 239226] Opening Forward Message Attachment Opens parent message in a new window : [Attachment 145295] the fix - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/9/2015 11:49:09 AM