superreview requested: [Bug 237228] pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js : [Attachment 158389] patch, add UnregisterPrefCallback
Ginn Chen <ginn.chen@sun.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 237228: pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js http://bugzilla.mozilla.org/show_bug.cgi?id=237228 Attachment 158389: patch, add UnregisterPrefCallback http://bugzilla.mozilla.org/attachment.cgi?id=158389&action=edit
|
0 |
|
bugzilla
9/10/2004 3:36:55 AM
netscape.mozilla.reviewers
29156 articles. 
0 followers.
0 Replies
573 Views
Similar Artilces:
superreview granted: [Bug 237228] pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js : [Attachment 158389] patch, add UnregisterPrefCallback
Robert O'Callahan <roc@ocallahan.org> has granted Ginn Chen <ginn.chen@sun.com>'s request for superreview: Bug 237228: pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js http://bugzilla.mozilla.org/show_bug.cgi?id=237228 Attachment 158389: patch, add UnregisterPrefCallback http://bugzilla.mozilla.org/attachment.cgi?id=158389&action=edit ...
superreview requested: [Bug 246750] Can't read menu/menuitem's "keyboard shortcut" and "accesskey" : [Attachment 150781] patch v1
Louie Zhao <Louie.Zhao@sun.com> has asked Henry Jia <Henry.Jia@sun.com> for superreview: Bug 246750: Can't read menu/menuitem's "keyboard shortcut" and "accesskey" http://bugzilla.mozilla.org/show_bug.cgi?id=246750 Attachment 150781: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=150781&action=edit ...
superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...
superreview requested: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) : [Attachment 292260] patch
Gavin Sharp <gavin.sharp@gmail.com> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 407538: newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) https://bugzilla.mozilla.org/show_bug.cgi?id=407538 Attachment 292260: patch https://bugzilla.mozilla.org/attachment.cgi?id=292260&action=edit ------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com> I'm not sure about the XXX comment in the test - seems like we should probably fix that, too, but I&...
superreview requested: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ...
superreview granted: [Bug 246750] Can't read menu/menuitem's "keyboard shortcut" and "accesskey" : [Attachment 150781] patch v1
Henry Jia <Henry.Jia@sun.com> has granted Louie Zhao <Louie.Zhao@sun.com>'s request for superreview: Bug 246750: Can't read menu/menuitem's "keyboard shortcut" and "accesskey" http://bugzilla.mozilla.org/show_bug.cgi?id=246750 Attachment 150781: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=150781&action=edit ------- Additional Comments from Henry Jia <Henry.Jia@sun.com> sr=Henry ...
superreview requested: [Bug 216751] general.config.filename set in user's prefs.js overrides setting in all.js : [Attachment 189091] Patch
Frank Wein <bugzilla@mcsmurf.de> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 216751: general.config.filename set in user's prefs.js overrides setting in all.js https://bugzilla.mozilla.org/show_bug.cgi?id=216751 Attachment 189091: Patch https://bugzilla.mozilla.org/attachment.cgi?id=189091&action=edit ...
superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...
superreview requested: [Bug 333315] Can't "Copy Locations to Clipboard" in bookmarks manager : [Attachment 221053] third patch, updated to substitute a set for tracking what we've seen
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked for superreview: Bug 333315: Can't "Copy Locations to Clipboard" in bookmarks manager https://bugzilla.mozilla.org/show_bug.cgi?id=333315 Attachment 221053: third patch, updated to substitute a set for tracking what we've seen https://bugzilla.mozilla.org/attachment.cgi?id=221053&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Yep, that's why I said "build a set in parallel with the array". r=me. + NSMutableSet* bookmarkList = [NSMu...
superreview requested: [Bug 276378] [BeOS] Download-prefs / Downloadmanager returns path to Home as Desktop : [Attachment 169840] patch to add ifdefs for BeOS so that 'Desktop' points to "DESK" as it
tqh <thesuckiestemail@yahoo.se> has asked Ben Goodger <bugs@bengoodger.com> for superreview: Bug 276378: [BeOS] Download-prefs / Downloadmanager returns path to Home as Desktop https://bugzilla.mozilla.org/show_bug.cgi?id=276378 Attachment 169840: patch to add ifdefs for BeOS so that 'Desktop' points to "DESK" as it should. https://bugzilla.mozilla.org/attachment.cgi?id=169840&action=edit ------- Additional Comments from tqh <thesuckiestemail@yahoo.se> sr? (and possibly checkin in case of success) ...
superreview granted: [Bug 245325] [Contacts side bar is empty in the compose window] and ["Add to Address Book ..." pane isn't filling in] : [Attachment 149988] pref-directory.js patch v2
Scott MacGregor <mscott@mozilla.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 245325: [Contacts side bar is empty in the compose window] and ["Add to Address Book ..." pane isn't filling in] http://bugzilla.mozilla.org/show_bug.cgi?id=245325 Attachment 149988: pref-directory.js patch v2 http://bugzilla.mozilla.org/attachment.cgi?id=149988&action=edit ...
superreview granted: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Mike Pinkerton <pinkerton@aol.net> has granted Bruce Davidson <Bruce.Davidson@iplbath.com>'s request for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink, will land myself. ...
superreview requested: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 144546] patch
Andrew Schultz <ajschult@mindspring.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 144546: patch http://bugzilla.mozilla.org/attachment.cgi?id=144546&action=edit ------- Additional Comments from Andrew Schultz <ajschult@mindspring.com> note that with bug 240929 and bug 236294 fixed, only the ErrorHandler part here is relevant. ...
superreview requested: [Bug 422511] "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" : [Attachment 312549] Patch
H=C3=A5kan Waara <hwaara@gmail.com> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 422511: "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" https://bugzilla.mozilla.org/show_bug.cgi?id=3D422511 Attachment 312549: Patch https://bugzilla.mozilla.org/attachment.cgi?id=3D312549&action=3Dedit= ...
Robert O'Callahan <roc@ocallahan.org> has granted Ginn Chen <ginn.chen@sun.com>'s request for superreview: Bug 237228: pref "layout.word_select.eat_space_to_next_word" can't be set by user in the profile's prefs.js http://bugzilla.mozilla.org/show_bug.cgi?id=237228 Attachment 158389: patch, add UnregisterPrefCallback http://bugzilla.mozilla.org/attachment.cgi?id=158389&action=edit ...
superreview requested: [Bug 246750] Can't read menu/menuitem's "keyboard shortcut" and "accesskey" : [Attachment 150781] patch v1
Louie Zhao <Louie.Zhao@sun.com> has asked Henry Jia <Henry.Jia@sun.com> for superreview: Bug 246750: Can't read menu/menuitem's "keyboard shortcut" and "accesskey" http://bugzilla.mozilla.org/show_bug.cgi?id=246750 Attachment 150781: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=150781&action=edit ...
superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...
superreview requested: [Bug 407538] newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) : [Attachment 292260] patch
Gavin Sharp <gavin.sharp@gmail.com> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 407538: newURI("http://foo.com:80").port is 80, should be -1 (can set a URI's port to it's default value by setting .spec) https://bugzilla.mozilla.org/show_bug.cgi?id=407538 Attachment 292260: patch https://bugzilla.mozilla.org/attachment.cgi?id=292260&action=edit ------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com> I'm not sure about the XXX comment in the test - seems like we should probably fix that, too, but I&...
superreview requested: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ...
superreview granted: [Bug 246750] Can't read menu/menuitem's "keyboard shortcut" and "accesskey" : [Attachment 150781] patch v1
Henry Jia <Henry.Jia@sun.com> has granted Louie Zhao <Louie.Zhao@sun.com>'s request for superreview: Bug 246750: Can't read menu/menuitem's "keyboard shortcut" and "accesskey" http://bugzilla.mozilla.org/show_bug.cgi?id=246750 Attachment 150781: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=150781&action=edit ------- Additional Comments from Henry Jia <Henry.Jia@sun.com> sr=Henry ...
superreview requested: [Bug 216751] general.config.filename set in user's prefs.js overrides setting in all.js : [Attachment 189091] Patch
Frank Wein <bugzilla@mcsmurf.de> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 216751: general.config.filename set in user's prefs.js overrides setting in all.js https://bugzilla.mozilla.org/show_bug.cgi?id=216751 Attachment 189091: Patch https://bugzilla.mozilla.org/attachment.cgi?id=189091&action=edit ...
superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...
superreview requested: [Bug 333315] Can't "Copy Locations to Clipboard" in bookmarks manager : [Attachment 221053] third patch, updated to substitute a set for tracking what we've seen
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked for superreview: Bug 333315: Can't "Copy Locations to Clipboard" in bookmarks manager https://bugzilla.mozilla.org/show_bug.cgi?id=333315 Attachment 221053: third patch, updated to substitute a set for tracking what we've seen https://bugzilla.mozilla.org/attachment.cgi?id=221053&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Yep, that's why I said "build a set in parallel with the array". r=me. + NSMutableSet* bookmarkList = [NSMu...
superreview requested: [Bug 276378] [BeOS] Download-prefs / Downloadmanager returns path to Home as Desktop : [Attachment 169840] patch to add ifdefs for BeOS so that 'Desktop' points to "DESK" as it
tqh <thesuckiestemail@yahoo.se> has asked Ben Goodger <bugs@bengoodger.com> for superreview: Bug 276378: [BeOS] Download-prefs / Downloadmanager returns path to Home as Desktop https://bugzilla.mozilla.org/show_bug.cgi?id=276378 Attachment 169840: patch to add ifdefs for BeOS so that 'Desktop' points to "DESK" as it should. https://bugzilla.mozilla.org/attachment.cgi?id=169840&action=edit ------- Additional Comments from tqh <thesuckiestemail@yahoo.se> sr? (and possibly checkin in case of success) ...
superreview granted: [Bug 245325] [Contacts side bar is empty in the compose window] and ["Add to Address Book ..." pane isn't filling in] : [Attachment 149988] pref-directory.js patch v2
Scott MacGregor <mscott@mozilla.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 245325: [Contacts side bar is empty in the compose window] and ["Add to Address Book ..." pane isn't filling in] http://bugzilla.mozilla.org/show_bug.cgi?id=245325 Attachment 149988: pref-directory.js patch v2 http://bugzilla.mozilla.org/attachment.cgi?id=149988&action=edit ...
superreview granted: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Mike Pinkerton <pinkerton@aol.net> has granted Bruce Davidson <Bruce.Davidson@iplbath.com>'s request for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink, will land myself. ...
superreview requested: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 144546] patch
Andrew Schultz <ajschult@mindspring.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 144546: patch http://bugzilla.mozilla.org/attachment.cgi?id=144546&action=edit ------- Additional Comments from Andrew Schultz <ajschult@mindspring.com> note that with bug 240929 and bug 236294 fixed, only the ErrorHandler part here is relevant. ...
superreview requested: [Bug 422511] "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" : [Attachment 312549] Patch
H=C3=A5kan Waara <hwaara@gmail.com> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 422511: "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" https://bugzilla.mozilla.org/show_bug.cgi?id=3D422511 Attachment 312549: Patch https://bugzilla.mozilla.org/attachment.cgi?id=3D312549&action=3Dedit= ...