superreview requested: [Bug 235355] hangs/crashes after choosing Server Settings in Mail&Newsgroup Account Settings, click o.k. : [Attachment 142195] v1 patch

Darin Fisher <darin@meer.net> has asked David Baron <dbaron@dbaron.org> for
superreview:
Bug 235355: hangs/crashes after choosing Server Settings in Mail&Newsgroup
Account Settings, click o.k.
http://bugzilla.mozilla.org/show_bug.cgi?id=235355

Attachment 142195: v1 patch
http://bugzilla.mozilla.org/attachment.cgi?id=142195&action=edit

------- Additional Comments from Darin Fisher <darin@meer.net>
i checked with the old nsString2.cpp code, and saw that indeed it would return
early if ReplaceSubstring was called with aTarget equal to the empty string.

it also would returned early if aNewValue was empty, but that makes little
sense to me.  what if you wanted to replace a certain substring with an empty
value?	that should be supported.  this makes that happen.

i also corrected the adjustment of the iteration variable |i| in the
algorithm's loop.  i think it is correct for it to resume replacing after the
end of the last replaced substring.  previously what it was doing was pretty
bogus.
0
bugzilla
2/25/2004 1:57:59 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
439 Views

Similar Articles

[PageSpeed] 28

Reply:

Similar Artilces:

superreview granted: [Bug 235355] hangs/crashes after choosing Server Settings in Mail&Newsgroup Account Settings, click o.k. : [Attachment 142195] v1 patch
David Baron <dbaron@dbaron.org> has granted Darin Fisher <darin@meer.net>'s request for superreview: Bug 235355: hangs/crashes after choosing Server Settings in Mail&Newsgroup Account Settings, click o.k. http://bugzilla.mozilla.org/show_bug.cgi?id=235355 Attachment 142195: v1 patch http://bugzilla.mozilla.org/attachment.cgi?id=142195&action=edit ...

superreview requested: [Bug 244413] Mail & Newsgroup Account Settings \ Server Settings\Checkboxes : [Attachment 149157] Fixes all occurrences of this problem in MailNews
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 244413: Mail & Newsgroup Account Settings \ Server Settings\Checkboxes http://bugzilla.mozilla.org/show_bug.cgi?id=244413 Attachment 149157: Fixes all occurrences of this problem in MailNews http://bugzilla.mozilla.org/attachment.cgi?id=149157&action=edit ------- Additional Comments from Stefan Borggraefe <Stefan.Borggraefe@gmx.de> Ok, thanks Neil! Lets ask Scott for sr then. ...

superreview granted: [Bug 244413] Mail & Newsgroup Account Settings \ Server Settings\Checkboxes : [Attachment 149157] Fixes all occurrences of this problem in MailNews
Scott MacGregor <mscott@mozilla.org> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 244413: Mail & Newsgroup Account Settings \ Server Settings\Checkboxes http://bugzilla.mozilla.org/show_bug.cgi?id=244413 Attachment 149157: Fixes all occurrences of this problem in MailNews http://bugzilla.mozilla.org/attachment.cgi?id=149157&action=edit ...

superreview requested: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Here's what I did: 1) nsMsgAccountManagerDS.cpp.h Add code to display a junk mail panel for all accounts but news who h...

superreview requested: [Bug 417957] Setting mail.auth_login and mail.server.default.auth_login to false breaks IMAP after restart : [Attachment 316293] Patch for mozilla/mailnews/imap/src/nsImapProtoc
Petri Kelottij=C3=A4rvi <petri@netatonce.net> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 417957: Setting mail.auth_login and mail.server.default.auth_login to f= alse breaks IMAP after restart https://bugzilla.mozilla.org/show_bug.cgi?id=3D417957 Attachment 316293: Patch for mozilla/mailnews/imap/src/nsImapProtocol.cpp, = cvs tag HEAD https://bugzilla.mozilla.org/attachment.cgi?id=3D316293&action=3Dedit ------- Additional Comments from Petri Kelottij=C3=A4rvi <petri@netatonce.n= et> Same as attachment 316292 except for HEAD. Some...

superreview requested: [Bug 417957] Setting mail.auth_login and mail.server.default.auth_login to false breaks IMAP after restart : [Attachment 316292] Patch for mozilla/mailnews/imap/src/nsImapProtoc
Petri Kelottij=C3=A4rvi <petri@netatonce.net> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 417957: Setting mail.auth_login and mail.server.default.auth_login to f= alse breaks IMAP after restart https://bugzilla.mozilla.org/show_bug.cgi?id=3D417957 Attachment 316292: Patch for mozilla/mailnews/imap/src/nsImapProtocol.cpp, = cvs tag BRANCH_1_8 https://bugzilla.mozilla.org/attachment.cgi?id=3D316292&action=3Dedit ------- Additional Comments from Petri Kelottij=C3=A4rvi <petri@netatonce.n= et> Some code for looking up the password and...

superreview granted: [Bug 279627] Mail & Newsgroups, choosing as default mail client, setting doesn't stick, dialog reappears on subsequent startups. : [Attachment 177304] Proposed patch
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 279627: Mail & Newsgroups, choosing as default mail client, setting doesn't stick, dialog reappears on subsequent startups. https://bugzilla.mozilla.org/show_bug.cgi?id=279627 Attachment 177304: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=177304&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> thanks Neil. ...

superreview requested: [Bug 204339] [RFE] Mozilla Mail should support the setting and reading the mail-followup-to header : [Attachment 327347] support for setting mail-followup-to and mail-reply-to -
David Bienvenu <bienvenu@nventure.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 204339: [RFE] Mozilla Mail should support the setting and reading the mail-followup-to header https://bugzilla.mozilla.org/show_bug.cgi?id=204339 Attachment 327347: support for setting mail-followup-to and mail-reply-to - v3 https://bugzilla.mozilla.org/attachment.cgi?id=327347&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Daniel meant to ask me for a review, but I think I'll push the review to Standard8, and I...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> my one concern is about migration from the per-server prefs to the global prefs. What happens in that scenar...

superreview requested: [Bug 216789] "Server Settings" tab in "Account Settings" is too big for preferences window : [Attachment 130981] Revised Patch v0.2a
Ian Neal <bugzilla@arlen.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 216789: "Server Settings" tab in "Account Settings" is too big for preferences window http://bugzilla.mozilla.org/show_bug.cgi?id=216789 Attachment 130981: Revised Patch v0.2a http://bugzilla.mozilla.org/attachment.cgi?id=130981&action=edit ...

superreview requested: [Bug 222388] Set initial SMTP server setting to "Always Use Deafult SMTP Server" instead of specific SMTP server : [Attachment 134109] patch v2
David Bienvenu <bienvenu@nventure.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 222388: Set initial SMTP server setting to "Always Use Deafult SMTP Server" instead of specific SMTP server http://bugzilla.mozilla.org/show_bug.cgi?id=222388 Attachment 134109: patch v2 http://bugzilla.mozilla.org/attachment.cgi?id=134109&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Asking Neil for r= ...

superreview requested: [Bug 204339] [RFE] Mozilla Mail should support the setting and reading the mail-followup-to header : [Attachment 169079] patch: support for interpreting mail-followup-to and ma #2
Daniel Faber <mail@daniel-faber.de> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 204339: [RFE] Mozilla Mail should support the setting and reading the mail-followup-to header https://bugzilla.mozilla.org/show_bug.cgi?id=204339 Attachment 169079: patch: support for interpreting mail-followup-to and mail-reply-to - v2 https://bugzilla.mozilla.org/attachment.cgi?id=169079&action=edit ...

superreview requested: [Bug 204339] [RFE] Mozilla Mail should support the setting and reading the mail-followup-to header : [Attachment 169079] patch: support for interpreting mail-followup-to and ma #3
Daniel Faber <mail@daniel-faber.de> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 204339: [RFE] Mozilla Mail should support the setting and reading the mail-followup-to header https://bugzilla.mozilla.org/show_bug.cgi?id=204339 Attachment 169079: patch: support for interpreting mail-followup-to and mail-reply-to - v2 https://bugzilla.mozilla.org/attachment.cgi?id=169079&action=edit ...

superreview requested: [Bug 204339] [RFE] Mozilla Mail should support the setting and reading the mail-followup-to header : [Attachment 169079] patch: support for interpreting mail-followup-to and ma #4
Daniel Faber <mail@daniel-faber.de> has asked Henry Jia <Henry.Jia@sun.com> for superreview: Bug 204339: [RFE] Mozilla Mail should support the setting and reading the mail-followup-to header https://bugzilla.mozilla.org/show_bug.cgi?id=204339 Attachment 169079: patch: support for interpreting mail-followup-to and mail-reply-to - v2 https://bugzilla.mozilla.org/attachment.cgi?id=169079&action=edit ...

Web resources about - superreview requested: [Bug 235355] hangs/crashes after choosing Server Settings in Mail&Newsgroup Account Settings, click o.k. : [Attachment 142195] v1 patch - netscape.mozilla.reviewers

Resources last updated: 1/1/2016 1:24:27 AM