superreview requested: [Bug 232321] Control-backspace doesn't delete words in URL bar : [Attachment 140950] Make word break pref work

neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Boris
Zbarsky <bzbarsky@mit.edu> for superreview:
Bug 232321: Control-backspace doesn't delete words in URL bar
http://bugzilla.mozilla.org/show_bug.cgi?id=232321

Attachment 140950: Make word break pref work
http://bugzilla.mozilla.org/attachment.cgi?id=140950&action=edit

------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
I basically copied code from nsImageFrame.cpp ;-)
0
bugzilla
2/9/2004 12:20:53 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
474 Views

Similar Articles

[PageSpeed] 46

Reply:

Similar Artilces:

superreview denied: [Bug 232321] Control-backspace doesn't delete words in URL bar : [Attachment 140950] Make word break pref work
Boris Zbarsky <bzbarsky@mit.edu> has denied neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 232321: Control-backspace doesn't delete words in URL bar http://bugzilla.mozilla.org/show_bug.cgi?id=232321 Attachment 140950: Make word break pref work http://bugzilla.mozilla.org/attachment.cgi?id=140950&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Hmm... So the code in nsImageFrame has a problem, actually -- it's passing an object with a refcount of 0 across xpcom boundaries. So i...

superreview requested: [Bug 232321] Control-backspace doesn't delete words in URL bar : [Attachment 140982] Addressed review comment
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 232321: Control-backspace doesn't delete words in URL bar http://bugzilla.mozilla.org/show_bug.cgi?id=232321 Attachment 140982: Addressed review comment http://bugzilla.mozilla.org/attachment.cgi?id=140982&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> No ref counts, does this make things better? ...

superreview requested: [Bug 232321] Control-backspace doesn't delete words in URL bar : [Attachment 141174] Another try
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 232321: Control-backspace doesn't delete words in URL bar http://bugzilla.mozilla.org/show_bug.cgi?id=232321 Attachment 141174: Another try http://bugzilla.mozilla.org/attachment.cgi?id=141174&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> I think I managed to kill a semicolon too. ...

superreview denied: [Bug 232321] Control-backspace doesn't delete words in URL bar : [Attachment 140982] Addressed review comment
Boris Zbarsky <bzbarsky@mit.edu> has denied neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 232321: Control-backspace doesn't delete words in URL bar http://bugzilla.mozilla.org/show_bug.cgi?id=232321 Attachment 140982: Addressed review comment http://bugzilla.mozilla.org/attachment.cgi?id=140982&action=edit ...

superreview granted: [Bug 232321] Control-backspace doesn't delete words in URL bar : [Attachment 141174] Another try
Boris Zbarsky <bzbarsky@mit.edu> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 232321: Control-backspace doesn't delete words in URL bar http://bugzilla.mozilla.org/show_bug.cgi?id=232321 Attachment 141174: Another try http://bugzilla.mozilla.org/attachment.cgi?id=141174&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> There we go. r+sr=bzbarsky ...

superreview requested: [Bug 419379] delete message doesn't work if focus in header of message preview pane : [Attachment 306928] Make the delete button work in all places
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 419379: delete message doesn't work if focus in header of message preview pane https://bugzilla.mozilla.org/show_bug.cgi?id=419379 Attachment 306928: Make the delete button work in all places https://bugzilla.mozilla.org/attachment.cgi?id=306928&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> I forgot the standalone message window before (thx Karsten for spotting), so the patch is v1 +...

superreview requested: [Bug 419379] delete message doesn't work if focus in header of message preview pane : [Attachment 305846] Make delete button work again v1
Bruno 'Aqualon' Escherl <aqualon@aquachan.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 419379: delete message doesn't work if focus in header of message preview pane https://bugzilla.mozilla.org/show_bug.cgi?id=419379 Attachment 305846: Make delete button work again v1 https://bugzilla.mozilla.org/attachment.cgi?id=305846&action=edit ------- Additional Comments from Bruno 'Aqualon' Escherl <aqualon@aquachan.de> The patch brings back the button_delete command removed in bug 391701 and also introduces button_shiftD...

superreview requested: [Bug 258175] Drag and drop of url in url bar to bookmarks toolbar doesn't work : [Attachment 159455] fix?
Robert O'Callahan <roc@ocallahan.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 258175: Drag and drop of url in url bar to bookmarks toolbar doesn't work http://bugzilla.mozilla.org/show_bug.cgi?id=258175 Attachment 159455: fix? http://bugzilla.mozilla.org/attachment.cgi?id=159455&action=edit ...

superreview requested: [Bug 237803] Unhiding the url bar doesn't update url address field to the currently displayed page : [Attachment 158943] make sure the field editor is non-nill before comparing
Geoff Beier <me@mollyandgeoff.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 237803: Unhiding the url bar doesn't update url address field to the currently displayed page http://bugzilla.mozilla.org/show_bug.cgi?id=237803 Attachment 158943: make sure the field editor is non-nill before comparing it to the firstResponder, which may be nil http://bugzilla.mozilla.org/attachment.cgi?id=158943&action=edit ...

superreview requested: [Bug 193332] about:config doesn't remove deleted prefs with no default : [Attachment 219490] don't remove entries while enumerating
Andrew Schultz <ajschult@verizon.net> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 193332: about:config doesn't remove deleted prefs with no default https://bugzilla.mozilla.org/show_bug.cgi?id=193332 Attachment 219490: don't remove entries while enumerating https://bugzilla.mozilla.org/attachment.cgi?id=219490&action=edit ------- Additional Comments from Andrew Schultz <ajschult@verizon.net> Running with this, I noticed it asserts during profile switch (I don't remember that before) due to pldhash recursion. This handles t...

superreview granted: [Bug 419379] delete message doesn't work if focus in header of message preview pane : [Attachment 305846] Make delete button work again v1
neil@parkwaycc.co.uk <neil@httl.net> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 419379: delete message doesn't work if focus in header of message preview pane https://bugzilla.mozilla.org/show_bug.cgi?id=419379 Attachment 305846: Make delete button work again v1 https://bugzilla.mozilla.org/attachment.cgi?id=305846&action=edit ...

superreview granted: [Bug 419379] delete message doesn't work if focus in header of message preview pane : [Attachment 306928] Make the delete button work in all places
neil@parkwaycc.co.uk <neil@httl.net> has granted Bruno 'Aqualon' Escherl <aqualon@aquachan.de>'s request for superreview: Bug 419379: delete message doesn't work if focus in header of message preview pane https://bugzilla.mozilla.org/show_bug.cgi?id=419379 Attachment 306928: Make the delete button work in all places https://bugzilla.mozilla.org/attachment.cgi?id=306928&action=edit ...

superreview requested: [Bug 283992] keyword search for exactly one word with non-ASCII characters (umlauts and accentuated characters) doesn't work due to punycode-conversion : [Attachment 176447] an
Jungshik Shin <jshin1987@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 283992: keyword search for exactly one word with non-ASCII characters (umlauts and accentuated characters) doesn't work due to punycode-conversion https://bugzilla.mozilla.org/show_bug.cgi?id=283992 Attachment 176447: an alternative (with pref. juggling) https://bugzilla.mozilla.org/attachment.cgi?id=176447&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> thanks for r. asking for sr. ...

superreview requested: [Bug 283992] keyword search for exactly one word with non-ASCII characters (umlauts and accentuated characters) doesn't work due to punycode-conversion : [Attachment 176341] pa
Jungshik Shin <jshin1987@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 283992: keyword search for exactly one word with non-ASCII characters (umlauts and accentuated characters) doesn't work due to punycode-conversion https://bugzilla.mozilla.org/show_bug.cgi?id=283992 Attachment 176341: patch for av 1.0.1 branch https://bugzilla.mozilla.org/attachment.cgi?id=176341&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> This is not pretty, but takes the least effort(?)... ...

Web resources about - superreview requested: [Bug 232321] Control-backspace doesn't delete words in URL bar : [Attachment 140950] Make word break pref work - netscape.mozilla.reviewers

Resources last updated: 2/7/2016 12:06:43 AM