superreview requested: [Bug 226954] doesn't show the 'contents' frame : [Attachment 136666] Partial patch
Boris Zbarsky (not really reading bugmail) <bz-vacation@mit.edu> has asked for superreview: Bug 226954: doesn't show the 'contents' frame http://bugzilla.mozilla.org/show_bug.cgi?id=226954 Attachment 136666: Partial patch http://bugzilla.mozilla.org/attachment.cgi?id=136666&action=edit ------- Additional Comments from Boris Zbarsky (not really reading bugmail) <bz-vacation@mit.edu> OK, the issue with the second testcase is resolved by the patch in bug 97695. Looks like line layout is just passing us a bogus CB height here... ...

superreview granted: [Bug 226954] doesn't show the 'contents' frame : [Attachment 136666] Partial patch
David Baron <dbaron@dbaron.org> has granted Boris Zbarsky (not in town, no tree) <bz-vacation@mit.edu>'s request for superreview: Bug 226954: doesn't show the 'contents' frame http://bugzilla.mozilla.org/show_bug.cgi?id=226954 Attachment 136666: Partial patch http://bugzilla.mozilla.org/attachment.cgi?id=136666&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> r+sr=dbaron. sorry for the delay ...

superreview requested: [Bug 258806] it doesn't build if a patch isn't applied at nsModule.cpp : [Attachment 158537] patch to avoid dogbert #2
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 258806: it doesn't build if a patch isn't applied at nsModule.cpp https://bugzilla.mozilla.org/show_bug.cgi?id=258806 Attachment 158537: patch to avoid dogbert https://bugzilla.mozilla.org/attachment.cgi?id=158537&action=edit ...

superreview requested: [Bug 271815] GTK2 IM over-the-spot doesn't work with Chinese IM because the editor doesn't return correct caret position : [Attachment 226123] Patch rv1.2
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 271815: GTK2 IM over-the-spot doesn't work with Chinese IM because the editor doesn't return correct caret position https://bugzilla.mozilla.org/show_bug.cgi?id=271815 Attachment 226123: Patch rv1.2 https://bugzilla.mozilla.org/attachment.cgi?id=226123&action=edit ...

superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...

superreview requested: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=3D93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=3D323226&action=3Dedit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> This proved to be pretty simple to fix, with some caveats. The attached pa= tch passes Hixie's test linke...

superreview requested: [Bug 258801] it doesn't build if a patch isn't applied on nsProfileMigrator.cpp : [Attachment 158496] a defined for a BeOS build #2
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 258801: it doesn't build if a patch isn't applied on nsProfileMigrator.cpp https://bugzilla.mozilla.org/show_bug.cgi?id=258801 Attachment 158496: a defined for a BeOS build https://bugzilla.mozilla.org/attachment.cgi?id=158496&action=edit ...

superreview requested: [Bug 248606] "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame : [Attachment 151705] patch
David Baron <dbaron@dbaron.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 248606: "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame http://bugzilla.mozilla.org/show_bug.cgi?id=248606 Attachment 151705: patch http://bugzilla.mozilla.org/attachment.cgi?id=151705&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> This patch separates the two coordinate transformations (so they're more like they used to be before bug 20022), and restores the baseV...

superreview requested: [Bug 268941] Error ``tabs has no properties'' [xs] in file ``chrome://communicator/content/sidebar/sidebarOverlay.js'', line 1355, character 0. : [Attachment 165464] Patch #2
Christopher A. Aillon <caillon@gmail.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 268941: Error ``tabs has no properties'' [xs] in file ``chrome://communicator/content/sidebar/sidebarOverlay.js'', line 1355, character 0. https://bugzilla.mozilla.org/show_bug.cgi?id=268941 Attachment 165464: Patch https://bugzilla.mozilla.org/attachment.cgi?id=165464&action=edit ------- Additional Comments from Christopher A. Aillon <caillon@gmail.com> r=me; but super-reviewer I am not. ...

superreview requested: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Neil: Easy fix, you forgot an arg ;-). ...

superreview requested: [Bug 395961] Shouldn't show full path to handler executable in Launch Application dialog (show 'pretty name' instead) : [Attachment 301938] cleanup cmd handler path patch v.3
Jim Mathies <jmathies@mozilla.com> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 395961: Shouldn't show full path to handler executable in Launch Application dialog (show 'pretty name' instead) https://bugzilla.mozilla.org/show_bug.cgi?id=395961 Attachment 301938: cleanup cmd handler path patch v.3 https://bugzilla.mozilla.org/attachment.cgi?id=301938&action=edit ...

superreview requested: [Bug 258806] it doesn't build if a patch isn't applied at nsModule.cpp : [Attachment 158537] patch to avoid dogbert
Sergei Dolgov <sergei_d@fi.tartu.ee> has asked timeless@myrealbox.com (working) <timeless@bemail.org> for superreview: Bug 258806: it doesn't build if a patch isn't applied at nsModule.cpp https://bugzilla.mozilla.org/show_bug.cgi?id=258806 Attachment 158537: patch to avoid dogbert https://bugzilla.mozilla.org/attachment.cgi?id=158537&action=edit ------- Additional Comments from Sergei Dolgov <sergei_d@fi.tartu.ee> timeless, can you sr and checkin this? ...

superreview requested: [Bug 271959] Mozilla's About page doesn't know how to spell its own name in its license : [Attachment 167171] patch
Alex Vincent <ajvincent@gmail.com> has asked Boris Zbarsky (out of town Dec 10 -- Jan 2) <bzbarsky@mit.edu> for superreview: Bug 271959: Mozilla's About page doesn't know how to spell its own name in its license https://bugzilla.mozilla.org/show_bug.cgi?id=271959 Attachment 167171: patch https://bugzilla.mozilla.org/attachment.cgi?id=167171&action=edit ------- Additional Comments from Alex Vincent <ajvincent@gmail.com> This may or may not require strong review; it's a comment-only change, really a nitpick. ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...