superreview requested: [Bug 225859] port NSPR to Windows XP / Server 2003 64bit for AMD64 : [Attachment 199357] Public interface and build system changes (for code review only)

Wan-Teh Chang <wtchang@redhat.com> has asked Brendan Eich <brendan@mozilla.org>
for superreview:
Bug 225859: port NSPR to Windows XP / Server 2003 64bit for AMD64
https://bugzilla.mozilla.org/show_bug.cgi?id=225859

Attachment 199357: Public interface and build system changes (for code review
only)
https://bugzilla.mozilla.org/attachment.cgi?id=199357&action=edit

------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com>
These are the changes to NSPR's exported header files
and build system for 64-bit Windows.  You are welcome
to review the full patch, but in the interest of saving
your time, I'd like you to review the most important
subset of that patch.  If you don't have time to review
this patch, feel free to cancel my review request.

64-bit Windows breaks two assumptions NSPR's code makes:
1. long is large enough to hold a pointer.
2. PRInt32 is large enough to hold an "OS fd" (Unix file
descriptors, Winsock SOCKET, Windows HANDLE, etc.).

So I have to redefine PRUptrdiff, PRWord, and PRUword for
64-bit Windows.  Note that I did not touch the definitions
of these types for the other platforms because I need to
maintain backward compatibility.

I also added a new type called PROsfd for the "OS fd", and
it is defined as __int64 on 64-bit Windows so it can hold
HANDLE (which is a void *), and as PRInt32 on all other
platforms (to be backward compatible).

Thanks.
0
bugzilla
10/12/2005 10:14:26 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
409 Views

Similar Articles

[PageSpeed] 1

Reply:

Similar Artilces:

superreview cancelled: [Bug 225859] port NSPR to Windows XP / Server 2003 64bit for AMD64 : [Attachment 199357] Public interface and build system changes (for code review only)
Wan-Teh Chang <wtchang@redhat.com> has cancelled Wan-Teh Chang <wtchang@redhat.com>'s request for superreview: Bug 225859: port NSPR to Windows XP / Server 2003 64bit for AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=225859 Attachment 199357: Public interface and build system changes (for code review only) https://bugzilla.mozilla.org/attachment.cgi?id=199357&action=edit ...

superreview requested: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 193985] Updated changes to files based on review feedback from Wan-Teh
Sandeep Konchady <Sandeep.Konchady@Sun.COM> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=302550 Attachment 193985: Updated changes to files based on review feedback from Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=193985&action=edit ------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM> 1. coreconf/import.pl Removed $var{ZIP} 2. coreconf/jdk.mk Replaced spaces with tabs to stick to the ex...

superreview requested: [Bug 239562] 64bit safe code for liveconnect (WinXP AMD64) : [Attachment 154366] The fix for porting Liveconnect to 64 bit platforms (Windows & Linux).
Xiaobin Lu <Xiaobin.Lu@Sun.com> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 239562: 64bit safe code for liveconnect (WinXP AMD64) http://bugzilla.mozilla.org/show_bug.cgi?id=239562 Attachment 154366: The fix for porting Liveconnect to 64 bit platforms (Windows & Linux). http://bugzilla.mozilla.org/attachment.cgi?id=154366&action=edit ...

superreview requested: [Bug 396137] port Windows font matching code to Mac and use in place of ATSUI font matching : [Attachment 293819] patch, v.1.4, updated based on review comments
John Daggett (:jtd) <jdaggett@mozilla.com> has asked Stuart Parmenter <pavlov@pavlov.net> for superreview: Bug 396137: port Windows font matching code to Mac and use in place of ATSUI font matching https://bugzilla.mozilla.org/show_bug.cgi?id=396137 Attachment 293819: patch, v.1.4, updated based on review comments https://bugzilla.mozilla.org/attachment.cgi?id=293819&action=edit ...

superreview requested: [Bug 232742] Mozilla incl. firebird does not build on Amd64 cpu : [Attachment 140309] This patch makes mozilla build on amd64 under gentoo linux
Roland Mainz <roland.mainz@nrubsig.org> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 232742: Mozilla incl. firebird does not build on Amd64 cpu http://bugzilla.mozilla.org/show_bug.cgi?id=232742 Attachment 140309: This patch makes mozilla build on amd64 under gentoo linux http://bugzilla.mozilla.org/attachment.cgi?id=140309&action=edit ------- Additional Comments from Roland Mainz <roland.mainz@nrubsig.org> Requesting r= from wtc for the NSPR and NSS changes per bryner's suggestion... ...

superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-review
Anant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 393002: "Server not found" message for view-source window doesn't display server name https://bugzilla.mozilla.org/show_bug.cgi?id=393002 Attachment 292031: patch v2: address issue raised by super-review https://bugzilla.mozilla.org/attachment.cgi?id=292031&action=edit ...

superreview requested: [Bug 226218] 64bit safe code for mozilla/widget (AMD64) : [Attachment 326161] a patch
Makoto Kato <m_kato@ga2.so-net.ne.jp> has asked Ere Maijala <emaijala@kolumbus.fi> for superreview: Bug 226218: 64bit safe code for mozilla/widget (AMD64) https://bugzilla.mozilla.org/show_bug.cgi?id=226218 Attachment 326161: a patch https://bugzilla.mozilla.org/attachment.cgi?id=326161&action=edit ...

superreview requested: [Bug 281519] Support Windows XP x64(AMD64) build : [Attachment 173744] a patch
Makoto Kato <m_kato@ga2.so-net.ne.jp> has asked Blake Ross <firefox@blakeross.com> for superreview: Bug 281519: Support Windows XP x64(AMD64) build https://bugzilla.mozilla.org/show_bug.cgi?id=281519 Attachment 173744: a patch https://bugzilla.mozilla.org/attachment.cgi?id=173744&action=edit ...

superreview requested: [Bug 281519] Support Windows XP x64(AMD64) build : [Attachment 173744] a patch #2
Makoto Kato <m_kato@ga2.so-net.ne.jp> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 281519: Support Windows XP x64(AMD64) build https://bugzilla.mozilla.org/show_bug.cgi?id=281519 Attachment 173744: a patch https://bugzilla.mozilla.org/attachment.cgi?id=173744&action=edit ...

superreview requested: [Bug 226238] 64bit safe code for mozilla/db (WinXP AMD64) : [Attachment 139489] diff at 2004/01/20
Makoto Kato <m_kato@ga2.so-net.ne.jp> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 226238: 64bit safe code for mozilla/db (WinXP AMD64) http://bugzilla.mozilla.org/show_bug.cgi?id=226238 Attachment 139489: diff at 2004/01/20 http://bugzilla.mozilla.org/attachment.cgi?id=139489&action=edit ...

superreview requested: [Bug 351246] Load some of Mozilla into Highmem on OS/2 : [Attachment 248072] Changes to SQLite build and OS/2 code
Peter Weilbacher <mozilla@Weilbacher.org> has asked Vladimir Vukicevic (:vlad) <vladimir@pobox.com> for superreview: Bug 351246: Load some of Mozilla into Highmem on OS/2 https://bugzilla.mozilla.org/show_bug.cgi?id=351246 Attachment 248072: Changes to SQLite build and OS/2 code https://bugzilla.mozilla.org/attachment.cgi?id=248072&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> Changes to SQLite in the Mozilla tree. If this is OK, I will make the change to os_os2.c simultaneously to the Mozilla tree and the SQLite repos...

superreview requested: [Bug 351246] Load some of Mozilla into Highmem on OS/2 : [Attachment 248681] 248072: Changes to SQLite build and OS/2 code, updated
Peter Weilbacher <mozilla@Weilbacher.org> has asked Vladimir Vukicevic (:vlad) (Vacation until 18 Dec) <vladimir@pobox.com> for superreview: Bug 351246: Load some of Mozilla into Highmem on OS/2 https://bugzilla.mozilla.org/show_bug.cgi?id=351246 Attachment 248681: 248072: Changes to SQLite build and OS/2 code, updated https://bugzilla.mozilla.org/attachment.cgi?id=248681&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> (In reply to comment #115) > If you meant to say "if GCC version >= 3.3" here, > th...

superreview requested: [Bug 307527] Connection timeout with IMAP on dual core systems : [Attachment 208675] Proposed patch: use timeGetTime (whitespace ignored for code review)
Wan-Teh Chang <wtchang@redhat.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 307527: Connection timeout with IMAP on dual core systems https://bugzilla.mozilla.org/show_bug.cgi?id=307527 Attachment 208675: Proposed patch: use timeGetTime (whitespace ignored for code review) https://bugzilla.mozilla.org/attachment.cgi?id=208675&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> The original code uses QueryPerformanceCounter if it works, and falls back on GetTickCount. This patch essentially has two ch...

superreview requested: [Bug 319115] nsTextFrame needs to have its public interface tightened up in preparation for Thebes version of it : [Attachment 205015] Code changes necessary to remove layout/g
Stephen Blackheath <stephen@blacksapphire.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 319115: nsTextFrame needs to have its public interface tightened up in preparation for Thebes version of it https://bugzilla.mozilla.org/show_bug.cgi?id=319115 Attachment 205015: Code changes necessary to remove layout/generic/nsTextFrame.h https://bugzilla.mozilla.org/attachment.cgi?id=205015&action=edit ...

Web resources about - superreview requested: [Bug 225859] port NSPR to Windows XP / Server 2003 64bit for AMD64 : [Attachment 199357] Public interface and build system changes (for code review only) - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/23/2016 12:45:15 AM