superreview requested: [Bug 224723] NS_ASSERTION(boxObject, "no box object!"); timer fired after tree was destroyed : [Attachment 134790] cancel the timer if the tree goes away #2

Darin Fisher <darin@meer.net> has asked David Baron <dbaron@dbaron.org> for
superreview:

Bug 224723: NS_ASSERTION(boxObject, "no box object!"); timer fired after tree
was destroyed
http://bugzilla.mozilla.org/show_bug.cgi?id=224723

Attachment 134790: cancel the timer if the tree goes away
http://bugzilla.mozilla.org/attachment.cgi?id=134790&action=edit

------- Additional Comments from Darin Fisher <darin@meer.net>
i defer to dbaron (or one of the other layout sr's).
0
bugzilla
11/5/2003 10:44:31 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
350 Views

Similar Articles

[PageSpeed] 22

Reply:

Similar Artilces:

superreview requested: [Bug 224723] NS_ASSERTION(boxObject, "no box object!"); timer fired after tree was destroyed : [Attachment 134790] cancel the timer if the tree goes away
timeless@myrealbox.com <timeless@bemail.org> has asked Darin Fisher <darin@meer.net> for superreview: Bug 224723: NS_ASSERTION(boxObject, "no box object!"); timer fired after tree was destroyed http://bugzilla.mozilla.org/show_bug.cgi?id=224723 Attachment 134790: cancel the timer if the tree goes away http://bugzilla.mozilla.org/attachment.cgi?id=134790&action=edit ...

superreview granted: [Bug 224723] NS_ASSERTION(boxObject, "no box object!"); timer fired after tree was destroyed : [Attachment 134790] cancel the timer if the tree goes away
David Baron <dbaron@dbaron.org> has granted Darin Fisher <darin@meer.net>'s request for superreview: Bug 224723: NS_ASSERTION(boxObject, "no box object!"); timer fired after tree was destroyed http://bugzilla.mozilla.org/show_bug.cgi?id=224723 Attachment 134790: cancel the timer if the tree goes away http://bugzilla.mozilla.org/attachment.cgi?id=134790&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> If you use boolean logic rather than nesting ifs, sr=dbaron. ...

superreview requested: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 156642] (Bv1a) <tree.xml> (/Toolkit part) #2
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Mike Connor (really busy through end of Sept) <mconnor@steelgryphon.com> for superreview: Bug 211046: In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" https://bugzilla.mozilla.org/show_bug.cgi?id=211046 Attachment 156642: (Bv1a) <tree.xml> (/Toolkit part) https://bugzilla.mozilla.org/attachment.cgi?id=156642&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 171575] Implement "find bookmark" : [Attachment 178832] implement "show in tree"
vladimir@pobox.com has asked Mike Connor <mconnor@steelgryphon.com> for superreview: Bug 171575: Implement "find bookmark" https://bugzilla.mozilla.org/show_bug.cgi?id=171575 Attachment 178832: implement "show in tree" https://bugzilla.mozilla.org/attachment.cgi?id=178832&action=edit ------- Additional Comments from vladimir@pobox.com The patch looks good, thanks! One concern I have is with special-casing the showintree command in bookmarksTree.xml, and just adding it to the end of the menu, etc. Not sure if that's a good plan from a UI perspect...

superreview requested: [Bug 241181] inconsistent spelling of cancelled or canceled in Mozilla. : [Attachment 146719] Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Fi
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Scott Collins <scc@mozilla.org> for superreview: Bug 241181: inconsistent spelling of cancelled or canceled in Mozilla. http://bugzilla.mozilla.org/show_bug.cgi?id=241181 Attachment 146719: Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Firefox. http://bugzilla.mozilla.org/attachment.cgi?id=146719&action=edit ------- Additional Comments from Bruce Davidson <Bruce.Davidson@iplbath.com> Requesting r/sr (rs=?) on this patch for 1.8 trunk. ...

superreview cancelled: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has cancelled Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 235337] Support "odd" and "even" properties for tree rows : [Attachment 142065] patch
Brian Ryner <bryner@brianryner.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 235337: Support "odd" and "even" properties for tree rows http://bugzilla.mozilla.org/show_bug.cgi?id=235337 Attachment 142065: patch http://bugzilla.mozilla.org/attachment.cgi?id=142065&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #3
Serge GAUTHERIE <gautheri@noos.fr> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #4
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No super-review from <bienvenu@nventure.com> since '2004-04-26' :-( ...

superreview requested: [Bug 340373] Escape key should cancel "send in Unicode (UTF-8)?" dialog : [Attachment 226042] use button 1 for cancel instead of button 2 #2
Gavin Sharp <gavin.sharp@gmail.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 340373: Escape key should cancel "send in Unicode (UTF-8)?" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=340373 Attachment 226042: use button 1 for cancel instead of button 2 https://bugzilla.mozilla.org/attachment.cgi?id=226042&action=edit ...

superreview requested: [Bug 211046] In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" : [Attachment 146534] (Av2) <tree.xml>
Serge GAUTHERIE <gautheri@noos.fr> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 211046: In <chrome://global/content/bindings/tree.xml>, "Error: this.treeBoxObject.selection has no properties" http://bugzilla.mozilla.org/show_bug.cgi?id=211046 Attachment 146534: (Av2) <tree.xml> http://bugzilla.mozilla.org/attachment.cgi?id=146534&action=edit ...

superreview requested: [Bug 205138] "New Folder" button in "File Bookmark" dialog does nothing : [Attachment 131254] modified addBookmark.js to always select a folder in the tree
Michael Kaply <mkaply@us.ibm.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 205138: "New Folder" button in "File Bookmark" dialog does nothing http://bugzilla.mozilla.org/show_bug.cgi?id=205138 Attachment 131254: modified addBookmark.js to always select a folder in the tree http://bugzilla.mozilla.org/attachment.cgi?id=131254&action=edit ------- Additional Comments from Michael Kaply <mkaply@us.ibm.com> r=mkaply Should there be a firebird version of this patch? Or are things totally different there? ...

Web resources about - superreview requested: [Bug 224723] NS_ASSERTION(boxObject, "no box object!"); timer fired after tree was destroyed : [Attachment 134790] cancel the timer if the tree goes away #2 - netscape.mozilla.reviewers

Resources last updated: 12/16/2015 2:36:31 PM