superreview granted: [Bug 216559] fill="currentColor" does not work. : [Attachment 167493] Updated patch for CSS3 currentColor including dbaron's requested change
David Baron <dbaron@mozilla.org> has granted Scooter Morris <scootermorris@comcast.net>'s request for superreview: Bug 216559: fill="currentColor" does not work. https://bugzilla.mozilla.org/show_bug.cgi?id=216559 Attachment 167493: Updated patch for CSS3 currentColor including dbaron's requested change https://bugzilla.mozilla.org/attachment.cgi?id=167493&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.org> >Index: content/base/src/nsRuleNode.cpp >+ // The data computed from this can't be shared in the...

superreview requested: [Bug 216559] fill="currentColor" does not work. : [Attachment 165858] Patch for CSS3 currentColor
Scooter Morris <scootermorris@comcast.net> has asked David Baron <dbaron@mozilla.org> for superreview: Bug 216559: fill="currentColor" does not work. https://bugzilla.mozilla.org/show_bug.cgi?id=216559 Attachment 165858: Patch for CSS3 currentColor https://bugzilla.mozilla.org/attachment.cgi?id=165858&action=edit ...

superreview denied: [Bug 216559] fill="currentColor" does not work. : [Attachment 165858] Patch for CSS3 currentColor
David Baron <dbaron@mozilla.org> has denied Scooter Morris <scootermorris@comcast.net>'s request for superreview: Bug 216559: fill="currentColor" does not work. https://bugzilla.mozilla.org/show_bug.cgi?id=216559 Attachment 165858: Patch for CSS3 currentColor https://bugzilla.mozilla.org/attachment.cgi?id=165858&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.org> SetColor needs to set aInherited to PR_TRUE in the new case that you're adding, with a comment something like: // The data computed from this can't ...

superreview requested: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ...

superreview requested: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 173081] updated patch to reflect Mike's comment
olivier@umich.edu has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 173081: updated patch to reflect Mike's comment https://bugzilla.mozilla.org/attachment.cgi?id=173081&action=edit ------- Additional Comments from olivier@umich.edu did a mistake on the previous one, so here is the correct patch ...

superreview requested: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 173080] updated patch file to reflect Mike's comments
olivier@umich.edu has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 173080: updated patch file to reflect Mike's comments https://bugzilla.mozilla.org/attachment.cgi?id=173080&action=edit ...

superreview requested: [Bug 246750] Can't read menu/menuitem's "keyboard shortcut" and "accesskey" : [Attachment 150781] patch v1
Louie Zhao <Louie.Zhao@sun.com> has asked Henry Jia <Henry.Jia@sun.com> for superreview: Bug 246750: Can't read menu/menuitem's "keyboard shortcut" and "accesskey" http://bugzilla.mozilla.org/show_bug.cgi?id=246750 Attachment 150781: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=150781&action=edit ...

superreview requested: [Bug 403173] Change "it's" to "it is" in Empty Cache dialog : [Attachment 294624] No more " =?UTF-8?Q?it=E2=80=99s?=" in the cache
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has ask= ed Mark Mentovai <mark@moxienet.com> for superreview: Bug 403173: Change "it's" to "it is" in Empty Cache dialog https://bugzilla.mozilla.org/show_bug.cgi?id=3D403173 Attachment 294624: No more "it=E2=80=99s" in the cache https://bugzilla.mozilla.org/attachment.cgi?id=3D294624&action=3Dedit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> (In reply to comment #3)=0D > This should probably be ano...

superreview requested: [Bug 337106] Appending "Search" to the search engine's name doesn't always work well (grey text in the search bar) : [Attachment 224769] Updates the strings
Joe Hughes <joe@retrovirus.com> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 337106: Appending "Search" to the search engine's name doesn't always work well (grey text in the search bar) https://bugzilla.mozilla.org/show_bug.cgi?id=337106 Attachment 224769: Updates the strings https://bugzilla.mozilla.org/attachment.cgi?id=224769&action=edit ...

superreview requested: [Bug 422511] "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" : [Attachment 312549] Patch
H=C3=A5kan Waara <hwaara@gmail.com> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 422511: "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" https://bugzilla.mozilla.org/show_bug.cgi?id=3D422511 Attachment 312549: Patch https://bugzilla.mozilla.org/attachment.cgi?id=3D312549&action=3Dedit= ...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183870] Phase 2, v3: changes inspired by wtc's review of ph3
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183870: Phase 2, v3: changes inspired by wtc's review of ph3 https://bugzilla.mozilla.org/attachment.cgi?id=183870&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> Changes since ph2v2 and ph2v3: - SDK_C_INCLUDE needs to use GCC_VERSION_FULL in lib for gcc4 - use ${target_os} inste...

superreview requested: [Bug 403173] Change "it's" to "it is" in Empty Cache dialog : [Attachment 294711] Now with better text
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has asked Mark Mentovai <mark@moxienet.com> for superreview: Bug 403173: Change "it's" to "it is" in Empty Cache dialog https://bugzilla.mozilla.org/show_bug.cgi?id=403173 Attachment 294711: Now with better text https://bugzilla.mozilla.org/attachment.cgi?id=294711&action=edit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> "so that they load more quickly on future visits" sounds good to me. See bug 41003...

superreview requested: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch
Simon Montagu <smontagu@smontagu.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 350693: "Character Encoding" in "View Source" window doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=350693 Attachment 236818: Patch https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit ------- Additional Comments from Simon Montagu <smontagu@smontagu.org> This is a port of Neil's patch to xpfe in bug 252317. It had r=doron, sr=bzbarsky over there, so I guess rs should be enough to apply it to toolkit. ...

superreview requested: [Bug 243679] Fix for "change bookmark's icon" notification : [Attachment 149138] Revised patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Alec Flett <alecf@flett.org> for superreview: Bug 243679: Fix for "change bookmark's icon" notification http://bugzilla.mozilla.org/show_bug.cgi?id=243679 Attachment 149138: Revised patch http://bugzilla.mozilla.org/attachment.cgi?id=149138&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Dan, you'll still need superreview; there's a list at http://www.mozilla.org/hacking/reviewers.html from which I've semi-arbitr...