superreview requested: [Bug 21616] Space after ::first-letter pseudo-element line is larger than between other lines : [Attachment 166184] fix based on MathML's GetBoundingMetrics

rbs@maths.uq.edu.au has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview:
Bug 21616: Space after ::first-letter pseudo-element line is larger than
between other lines
https://bugzilla.mozilla.org/show_bug.cgi?id=21616

Attachment 166184: fix based on MathML's GetBoundingMetrics
https://bugzilla.mozilla.org/attachment.cgi?id=166184&action=edit

------- Additional Comments from rbs@maths.uq.edu.au
Asking r/sr to beautify ::first-letter by default at little cost (since MathML
is on by default these days).
0
bugzilla
11/17/2004 3:26:39 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
592 Views

Similar Articles

[PageSpeed] 22

Reply:

Similar Artilces:

superreview granted: [Bug 21616] Space after ::first-letter pseudo-element line is larger than between other lines : [Attachment 166184] fix based on MathML's GetBoundingMetrics
Boris Zbarsky <bzbarsky@mit.edu> has granted rbs@maths.uq.edu.au's request for superreview: Bug 21616: Space after ::first-letter pseudo-element line is larger than between other lines https://bugzilla.mozilla.org/show_bug.cgi?id=21616 Attachment 166184: fix based on MathML's GetBoundingMetrics https://bugzilla.mozilla.org/attachment.cgi?id=166184&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, and could you file a bug on making GetBoundingMetrics either have its own ifdef (implied by MOZ_MATHML) or just be alway...

superreview requested: [Bug 287008] ###!!! ASSERTION: Don't call me!: 'Error', file r:/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 2986 : [Attachment 191294] Fix.
Johnny Stenback <jst@mozilla.org> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 287008: ###!!! ASSERTION: Don't call me!: 'Error', file r:/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 2986 https://bugzilla.mozilla.org/show_bug.cgi?id=287008 Attachment 191294: Fix. https://bugzilla.mozilla.org/attachment.cgi?id=191294&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> Calling nsElementSH::GetProperty() from here does nothing other than assert and return NS_OK, just return NS_OK instead. (P...

superreview requested: [Bug 277875] ###!!! ASSERTION: this shouldn't happen, should it?: 'Not Reached', file r:/cenzic/mozilla/layout/html/base/src/nsFrame.cpp, line 2427 : [Attachment 173584] fix
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 277875: ###!!! ASSERTION: this shouldn't happen, should it?: 'Not Reached', file r:/cenzic/mozilla/layout/html/base/src/nsFrame.cpp, line 2427 https://bugzilla.mozilla.org/show_bug.cgi?id=277875 Attachment 173584: fix https://bugzilla.mozilla.org/attachment.cgi?id=173584&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Make nsIFrame::GetWindow do it the easy way, and don't bother asser...

superreview requested: [Bug 217903] ###!!! ASSERTION: prev sibling not in line list: 'Not Reached', file i:/build/mozilla/layout/html/base/src/nsBlockFrame.cpp, line 4679 : [Attachment 194408] Patch
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 217903: ###!!! ASSERTION: prev sibling not in line list: 'Not Reached', file i:/build/mozilla/layout/html/base/src/nsBlockFrame.cpp, line 4679 https://bugzilla.mozilla.org/show_bug.cgi?id=217903 Attachment 194408: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=194408&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> This fixes the stack that I have, which is the same as the one in comment 1. The ...

superreview requested: [Bug 341436] ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 : [Attachment 225493] Don't pass nu
Alex Vincent <ajvincent@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 341436: ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 https://bugzilla.mozilla.org/show_bug.cgi?id=341436 Attachment 225493: Don't pass null in. https://bugzilla.mozilla.org/attachment.cgi?id=225493&action=edit ...

superreview requested: [Bug 428332] Add the MoFo EULA line back to SeaMonkey's about:license now that bug 368091 is fixed : [Attachment 316649] Fix, v1
Smokey Ardisson (behind; no bugmail - do not email) <alqahira@ardisson.org> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 428332: Add the MoFo EULA line back to SeaMonkey's about:license now that bug 368091 is fixed https://bugzilla.mozilla.org/show_bug.cgi?id=428332 Attachment 316649: Fix, v1 https://bugzilla.mozilla.org/attachment.cgi?id=316649&action=edit ------- Additional Comments from Smokey Ardisson (behind; no bugmail - do not email) <alqahira@ardisson.org> This was a breeze to fix :) Some notes: 1) I stuck this in suit...

superreview requested: [Bug 92686] Return inserts line break, should insert paragraph break : [Attachment 156598] fix #3, in answer to brade's and akkana's comments
Johnny Stenback <jst@mozilla.jstenback.com> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 92686: Return inserts line break, should insert paragraph break https://bugzilla.mozilla.org/show_bug.cgi?id=92686 Attachment 156598: fix #3, in answer to brade's and akkana's comments https://bugzilla.mozilla.org/attachment.cgi?id=156598&action=edit ...

superreview granted: [Bug 287008] ###!!! ASSERTION: Don't call me!: 'Error', file r:/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 2986 : [Attachment 191294] Fix.
Peter Van der Beken <peterv@propagandism.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 287008: ###!!! ASSERTION: Don't call me!: 'Error', file r:/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 2986 https://bugzilla.mozilla.org/show_bug.cgi?id=287008 Attachment 191294: Fix. https://bugzilla.mozilla.org/attachment.cgi?id=191294&action=edit ...

superreview granted: [Bug 277875] ###!!! ASSERTION: this shouldn't happen, should it?: 'Not Reached', file r:/cenzic/mozilla/layout/html/base/src/nsFrame.cpp, line 2427 : [Attachment 173584] fix
Boris Zbarsky <bzbarsky@mit.edu> has granted Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 277875: ###!!! ASSERTION: this shouldn't happen, should it?: 'Not Reached', file r:/cenzic/mozilla/layout/html/base/src/nsFrame.cpp, line 2427 https://bugzilla.mozilla.org/show_bug.cgi?id=277875 Attachment 173584: fix https://bugzilla.mozilla.org/attachment.cgi?id=173584&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky ...

superreview requested: [Bug 196270] Numeric line-height is not rendered identically to equivalent length or percent-based line-height : [Attachment 191416] patch to fix bug
David Baron <dbaron@mozillafoundation.org> has asked Boris Zbarsky (gone till Aug 14) <bzbarsky@mit.edu> for superreview: Bug 196270: Numeric line-height is not rendered identically to equivalent length or percent-based line-height https://bugzilla.mozilla.org/show_bug.cgi?id=196270 Attachment 191416: patch to fix bug https://bugzilla.mozilla.org/attachment.cgi?id=191416&action=edit ...

superreview requested: [Bug 243504] filename of attachment is truncated at the first # (numbersign) or ; (semicolon) : [Attachment 161048] improved fix based on jshin's comments
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 243504: filename of attachment is truncated at the first # (numbersign) or ; (semicolon) https://bugzilla.mozilla.org/show_bug.cgi?id=243504 Attachment 161048: improved fix based on jshin's comments https://bugzilla.mozilla.org/attachment.cgi?id=161048&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> jshin, this is the same patch but it uses: esc_OnlyASCII thanks again for the review! ...

superreview requested: [Bug 211657] [FIX]Should use '::' for anonymous boxes and other -moz pseudo-elements : [Attachment 127207] Patch to remove support for the single-':' form of -moz pseudos
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 211657: [FIX]Should use '::' for anonymous boxes and other -moz pseudo-elements http://bugzilla.mozilla.org/show_bug.cgi?id=211657 Attachment 127207: Patch to remove support for the single-':' form of -moz pseudos http://bugzilla.mozilla.org/attachment.cgi?id=127207&action=edit ...

superreview granted: [Bug 217903] ###!!! ASSERTION: prev sibling not in line list: 'Not Reached', file i:/build/mozilla/layout/html/base/src/nsBlockFrame.cpp, line 4679 : [Attachment 194408] Patch re
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 217903: ###!!! ASSERTION: prev sibling not in line list: 'Not Reached', file i:/build/mozilla/layout/html/base/src/nsBlockFrame.cpp, line 4679 https://bugzilla.mozilla.org/show_bug.cgi?id=217903 Attachment 194408: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=194408&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky; sorry about this. :( We need this on the 1.8 branch too. ...

superreview requested: [Bug 324036] ###!!! ASSERTION: NOT IMPLEMENTED: '0', file c:/mozsource/mozilla/layout/base/nsDocumentViewer.cpp, line 2512 : [Attachment 242696] patch, v1
Alex Vincent <ajvincent@gmail.com> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 324036: ###!!! ASSERTION: NOT IMPLEMENTED: '0', file c:/mozsource/mozilla/layout/base/nsDocumentViewer.cpp, line 2512 https://bugzilla.mozilla.org/show_bug.cgi?id=324036 Attachment 242696: patch, v1 https://bugzilla.mozilla.org/attachment.cgi?id=242696&action=edit ------- Additional Comments from Alex Vincent <ajvincent@gmail.com> It is disabled, but we never checked that... whoops! This is a really simple patch for nsXBLPrototypeHandler to make us do ...

Web resources about - superreview requested: [Bug 21616] Space after ::first-letter pseudo-element line is larger than between other lines : [Attachment 166184] fix based on MathML's GetBoundingMetrics - netscape.mozilla.reviewers

Resources last updated: 12/18/2015 9:33:27 PM