superreview requested: [Bug 181105] Selection behaves badly when SpellCheck Selection is on : [Attachment 141155] Make alternate selection types render properly

Boris Zbarsky <bzbarsky@mit.edu> has asked Simon Fraser <sfraser@aol.net> for
superreview:
Bug 181105: Selection behaves badly when SpellCheck Selection is on
http://bugzilla.mozilla.org/show_bug.cgi?id=181105

Attachment 141155: Make alternate selection types render properly
http://bugzilla.mozilla.org/attachment.cgi?id=141155&action=edit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
>Index: content/base/src/nsSelection.cpp
>@@ -2792,17 +2792,37 @@ nsSelection::LookUpSelection(nsIContent 
>+	mDomSelections[j]->GetIsCollapsed(&iscollapsed);
>+	if (iscollapsed){

!iscollapsed, no?

r=bzbarsky with that.  Gotta love that code in nsFrame.

sfraser should take a look at this, probably....
0
bugzilla
2/11/2004 5:04:17 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
634 Views

Similar Articles

[PageSpeed] 45

Reply:

Similar Artilces:

superreview cancelled: [Bug 181105] Selection behaves badly when SpellCheck Selection is on : [Attachment 141155] Make alternate selection types render properly
Neil Deakin <enndeakin@sympatico.ca> has cancelled Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 181105: Selection behaves badly when SpellCheck Selection is on http://bugzilla.mozilla.org/show_bug.cgi?id=181105 Attachment 141155: Make alternate selection types render properly http://bugzilla.mozilla.org/attachment.cgi?id=141155&action=edit ...

superreview requested: [Bug 181105] Selection behaves badly when SpellCheck Selection is on : [Attachment 141176] Better patch
Neil Deakin <enndeakin@sympatico.ca> has asked Simon Fraser <sfraser@aol.net> for superreview: Bug 181105: Selection behaves badly when SpellCheck Selection is on http://bugzilla.mozilla.org/show_bug.cgi?id=181105 Attachment 141176: Better patch http://bugzilla.mozilla.org/attachment.cgi?id=141176&action=edit ...

superreview requested: [Bug 112281] ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items : [Attachment 135533] Proposed patch
Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 112281: ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items http://bugzilla.mozilla.org/show_bug.cgi?id=112281 Attachment 135533: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=135533&action=edit ------- Additional Comments from Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> roc, what do you think? ...

superreview requested: [Bug 254047] Bad selection from "to & cc & bcc" (dialog Select Addresses) : [Attachment 155033] Proposed patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 254047: Bad selection from "to & cc & bcc" (dialog Select Addresses) http://bugzilla.mozilla.org/show_bug.cgi?id=254047 Attachment 155033: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=155033&action=edit ...

superreview requested: [Bug 256658] new plugin placeholder text is selectable : [Attachment 156911] Don't let users select the text, and make the cursor a pointer.
Johnny Stenback <jst@mozilla.jstenback.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 256658: new plugin placeholder text is selectable http://bugzilla.mozilla.org/show_bug.cgi?id=256658 Attachment 156911: Don't let users select the text, and make the cursor a pointer. http://bugzilla.mozilla.org/attachment.cgi?id=156911&action=edit ...

superreview requested: [Bug 362990] Customize Message Views dialog's selection should not affect View menu selection : [Attachment 248134] make view list manipulation asynchronous
Karsten D�sterloh <mnyromyr@tprac.de> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 362990: Customize Message Views dialog's selection should not affect View menu selection https://bugzilla.mozilla.org/show_bug.cgi?id=362990 Attachment 248134: make view list manipulation asynchronous https://bugzilla.mozilla.org/attachment.cgi?id=248134&action=edit ------- Additional Comments from Karsten D�sterloh <mnyromyr@tprac.de> With this patch, users can edit their view list without having their mal windows blocked; and the last or no selected...

superreview requested: [Bug 166004] Leave submenu, no accessible focus event fired for selected item in parent menu : [Attachment 157055] Make sure DOMMenuItemActive gets fired for currently selected
Aaron Leventhal <aaronleventhal@moonset.net> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 166004: Leave submenu, no accessible focus event fired for selected item in parent menu http://bugzilla.mozilla.org/show_bug.cgi?id=166004 Attachment 157055: Make sure DOMMenuItemActive gets fired for currently selected menu item after child menu closed http://bugzilla.mozilla.org/attachment.cgi?id=157055&action=edit ...

superreview granted: [Bug 112281] ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items : [Attachment 135533] Proposed patch
Robert O'Callahan <roc@ocallahan.org> has granted Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu>'s request for superreview: Bug 112281: ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items http://bugzilla.mozilla.org/show_bug.cgi?id=112281 Attachment 135533: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=135533&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> looks quite straighforward :-) ...

superreview requested: [Bug 297172] Select box bug when dynamicly enabling and disabling multiple selects. : [Attachment 197270] Proposed patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 297172: Select box bug when dynamicly enabling and disabling multiple selects. https://bugzilla.mozilla.org/show_bug.cgi?id=297172 Attachment 197270: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=197270&action=edit ...

superreview requested: [Bug 299533] hang when selecting across select dropdown arrow : [Attachment 188166] fix the hang
Blake Kaplan <mrbkap@gmail.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 299533: hang when selecting across select dropdown arrow https://bugzilla.mozilla.org/show_bug.cgi?id=299533 Attachment 188166: fix the hang https://bugzilla.mozilla.org/attachment.cgi?id=188166&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> This wasn't in the original patch, and is incorrect (we call GetLastLeaf on the farStoppingFrame). Sorry. ...

superreview requested: [Bug 444209] Filter only selected messages in a folder : [Attachment 328569] Filter Selected Messages UI
Jeff Beckley <beckley@qualcomm.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 444209: Filter only selected messages in a folder https://bugzilla.mozilla.org/show_bug.cgi?id=3D444209 Attachment 328569: Filter Selected Messages UI https://bugzilla.mozilla.org/attachment.cgi?id=3D328569&action=3Dedit ------- Additional Comments from Jeff Beckley <beckley@qualcomm.com> Some Classic Eudora users manage their mail by using the ability to manually filter specific messages (e.g. when the message has been dealt with by the user). This patch g...

superreview granted: [Bug 392746] Multiple selection can go wrong when selecting something before an existing selection : [Attachment 311145] patch
Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> has granted superreview: Bug 392746: Multiple selection can go wrong when selecting something before an existing selection https://bugzilla.mozilla.org/show_bug.cgi?id=392746 Attachment 311145: patch https://bugzilla.mozilla.org/attachment.cgi?id=311145&action=edit ------- Additional Comments from Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> looks good ...

superreview requested: [Bug 306240] Triple-click (paragraph selection) also selects adjacent floats : [Attachment 194099] patch
Uri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 306240: Triple-click (paragraph selection) also selects adjacent floats https://bugzilla.mozilla.org/show_bug.cgi?id=306240 Attachment 194099: patch https://bugzilla.mozilla.org/attachment.cgi?id=194099&action=edit ------- Additional Comments from Uri Bernstein <uriber@gmail.com> Stop on placeholder frames (replacing floats or absolutely-positioned elements) as well as on block frames and BRFrames. ...

superreview requested: [Bug 312415] Selected images (from a selection of the document to print) are black : [Attachment 204199] I think this is the right fix...
Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 312415: Selected images (from a selection of the document to print) are black https://bugzilla.mozilla.org/show_bug.cgi?id=312415 Attachment 204199: I think this is the right fix... https://bugzilla.mozilla.org/attachment.cgi?id=204199&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> We used to not enable selection at all in a presshell without a docshell, but that seems pretty odd to me. If printing can't handle...

Web resources about - superreview requested: [Bug 181105] Selection behaves badly when SpellCheck Selection is on : [Attachment 141155] Make alternate selection types render properly - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/16/2016 11:13:37 AM