superreview requested: [Bug 171575] Implement "find bookmark" : [Attachment 178832] implement "show in tree"

vladimir@pobox.com has asked Mike Connor <mconnor@steelgryphon.com> for
superreview:
Bug 171575: Implement "find bookmark"
https://bugzilla.mozilla.org/show_bug.cgi?id=171575

Attachment 178832: implement "show in tree"
https://bugzilla.mozilla.org/attachment.cgi?id=178832&action=edit

------- Additional Comments from vladimir@pobox.com
The patch looks good, thanks!  One concern I have is with special-casing the
showintree command in bookmarksTree.xml, and just adding it to the end of the
menu, etc.  Not sure if that's a good plan from a UI perspective -- asking
mconnor for sr, he may have some thoughts on this.
0
bugzilla
3/29/2005 7:29:59 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
365 Views

Similar Articles

[PageSpeed] 11

Reply:

Similar Artilces:

superreview requested: [Bug 193698] "attachment" content shows a checkbox for "don't ask" : [Attachment 126900] fix other implementers
Christian Biesinger <cbiesinger@web.de> has asked Darin Fisher <darin@netscape.com> for superreview: Bug 193698: "attachment" content shows a checkbox for "don't ask" http://bugzilla.mozilla.org/show_bug.cgi?id=193698 Attachment 126900: fix other implementers http://bugzilla.mozilla.org/attachment.cgi?id=126900&action=edit ------- Additional Comments from Christian Biesinger <cbiesinger@web.de> bz: ok, I'll file those bugs when I checkin this patch ...

superreview requested: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 237073] A Patch Not On Crack
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 237073: A Patch Not On Crack https://bugzilla.mozilla.org/attachment.cgi?id=237073&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> r=me. Style stuff: >+ NSMenuItem* menuItem = [[NSMenuItem alloc] initWithTitle:NSL...

superreview requested: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 241797] r=smorgan patch
froodian (unreliable 10/7-10/12) <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 241797: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=241797&action=edit ...

superreview granted: [Bug 193698] "attachment" content shows a checkbox for "don't ask" : [Attachment 126900] fix other implementers
Darin Fisher <darin@netscape.com> has granted Christian Biesinger <cbiesinger@web.de>'s request for superreview: Bug 193698: "attachment" content shows a checkbox for "don't ask" http://bugzilla.mozilla.org/show_bug.cgi?id=193698 Attachment 126900: fix other implementers http://bugzilla.mozilla.org/attachment.cgi?id=126900&action=edit ------- Additional Comments from Darin Fisher <darin@netscape.com> sr=darin ...

superreview requested: [Bug 258485] "Refresh Live Bookmark" should be "Reload Live Bookmark" : [Attachment 176976] quick text change of "refresh"
Tim Meader <tmeader@gmail.com> has asked Alec Flett (limited reviews in January) <alecf@flett.org> for superreview: Bug 258485: "Refresh Live Bookmark" should be "Reload Live Bookmark" https://bugzilla.mozilla.org/show_bug.cgi?id=258485 Attachment 176976: quick text change of "refresh" https://bugzilla.mozilla.org/attachment.cgi?id=176976&action=edit ...

superreview requested: [Bug 74959] implement mail "back" and "forward" : [Attachment 233310] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 233310: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=233310&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> this is getting to where I'd like to get it reviewed and landed... ...

superreview requested: [Bug 258485] "Refresh Live Bookmark" should be "Reload Live Bookmark" : [Attachment 176976] quick text change of "refresh" #2
Tim Meader <tmeader@gmail.com> has asked Mike Connor <mconnor@steelgryphon.com> for superreview: Bug 258485: "Refresh Live Bookmark" should be "Reload Live Bookmark" https://bugzilla.mozilla.org/show_bug.cgi?id=258485 Attachment 176976: quick text change of "refresh" https://bugzilla.mozilla.org/attachment.cgi?id=176976&action=edit ------- Additional Comments from Tim Meader <tmeader@gmail.com> Trying mconnor instead. ...

superreview requested: [Bug 74959] implement mail "back" and "forward" : [Attachment 234697] fix the dtd entities.
David Bienvenu <bienvenu@nventure.com> has asked Seth Spitzer [:ss] <sspitzer@mozilla.com> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 234697: fix the dtd entities. https://bugzilla.mozilla.org/attachment.cgi?id=234697&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> use consistent names for the go nav menu item entities. ...

superreview requested: [Bug 424641] Write profile migrator to make old Thunderbird profiles available under "Mozilla", "~/mozilla", or "Application Support" : [Attachment 318390] The fix v2
Mark Banner <bugzilla@standard8.plus.com> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 424641: Write profile migrator to make old Thunderbird profiles available under "Mozilla", "~/mozilla", or "Application Support" https://bugzilla.mozilla.org/show_bug.cgi?id=424641 Attachment 318390: The fix v2 https://bugzilla.mozilla.org/attachment.cgi?id=318390&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> I'm happy this should work on all platforms. I'll request toolkit revi...

superreview requested: [Bug 74959] implement mail "back" and "forward"
Hartmut Figge <h.figge@gmx.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 282902: SM port https://bugzilla.mozilla.org/attachment.cgi?id=282902&action=edit ------- Additional Comments from Hartmut Figge <h.figge@gmx.de> Adaption for SM suiterunner ...

superreview requested: [Bug 74959] implement mail "back" and "forward" : [Attachment 234707] fix Neil's issue
David Bienvenu <bienvenu@nventure.com> has asked Seth Spitzer [:ss] <sspitzer@mozilla.com> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 234707: fix Neil's issue https://bugzilla.mozilla.org/attachment.cgi?id=234707&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> remove unneeded code as pointed out by Neil. ...

superreview requested: [Bug 74959] implement mail "back" and "forward" : [Attachment 234936] fix navigation in stand-alone msg window
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 234936: fix navigation in stand-alone msg window https://bugzilla.mozilla.org/attachment.cgi?id=234936&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> this gets navigation working in a stand-alone msg window (for both normal folders and saved searches). I'll fix updating the enabling/disabling...

superreview requested: [Bug 40934] "From" misrepresented as "Sender" : [Attachment 223235] cute little patch to replace "Sender" by "From"
C�dric Menge <bugzilla@mengemail.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 40934: "From" misrepresented as "Sender" https://bugzilla.mozilla.org/show_bug.cgi?id=40934 Attachment 223235: cute little patch to replace "Sender" by "From" https://bugzilla.mozilla.org/attachment.cgi?id=223235&action=edit ...

superreview requested: [Bug 74959] implement mail "back" and "forward" #2
Karsten D=C3=BCsterloh <mnyromyr@tprac.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=3D74959 Attachment 283929: SM port, v2: addressed Neil's review comments https://bugzilla.mozilla.org/attachment.cgi?id=3D283929&action=3Dedit ------- Additional Comments from Karsten D=C3=BCsterloh <mnyromyr@tprac.de> Hartmut did most of the changes Neil requested, but asked me to fill in the PopulateHistoryMenu stuff where he lacked intima...

superreview cancelled: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 237073] A Patch Not On Crack
froodian (unreliable 10/7-10/12) <stridey@gmail.com> has cancelled Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 237073: A Patch Not On Crack https://bugzilla.mozilla.org/attachment.cgi?id=237073&action=edit ...

superreview requested: [Bug 205138] "New Folder" button in "File Bookmark" dialog does nothing : [Attachment 131254] modified addBookmark.js to always select a folder in the tree
Michael Kaply <mkaply@us.ibm.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 205138: "New Folder" button in "File Bookmark" dialog does nothing http://bugzilla.mozilla.org/show_bug.cgi?id=205138 Attachment 131254: modified addBookmark.js to always select a folder in the tree http://bugzilla.mozilla.org/attachment.cgi?id=131254&action=edit ------- Additional Comments from Michael Kaply <mkaply@us.ibm.com> r=mkaply Should there be a firebird version of this patch? Or are things totally different there? ...

superreview requested: [Bug 262300] "Composition & Addressing" and "Advanced Account Settings" should be handeled by Identity Manager : [Attachment 165378] finish implementing multiple identity UI
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 262300: "Composition & Addressing" and "Advanced Account Settings" should be handeled by Identity Manager https://bugzilla.mozilla.org/show_bug.cgi?id=262300 Attachment 165378: finish implementing multiple identity UI https://bugzilla.mozilla.org/attachment.cgi?id=165378&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> David, it's not as big as it looks. You can ignore the two new files (am-cop...

superreview requested: [Bug 74959] implement mail "back" and "forward" : [Attachment 234956] fix enabling/disabling of forward/back buttons in stand-alone msg window
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 74959: implement mail "back" and "forward" https://bugzilla.mozilla.org/show_bug.cgi?id=74959 Attachment 234956: fix enabling/disabling of forward/back buttons in stand-alone msg window https://bugzilla.mozilla.org/attachment.cgi?id=234956&action=edit ...

superreview requested: [Bug 193698] "attachment" content shows a checkbox for "don't ask" : [Attachment 126870] patch
Christian Biesinger <cbiesinger@web.de> has asked Darin Fisher <darin@netscape.com> for superreview: Bug 193698: "attachment" content shows a checkbox for "don't ask" http://bugzilla.mozilla.org/show_bug.cgi?id=193698 Attachment 126870: patch http://bugzilla.mozilla.org/attachment.cgi?id=126870&action=edit ...

superreview granted: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 241797] r=smorgan patch
Mike Pinkerton <mikepinkerton@mac.com> has granted froodian (unreliable 10/7-10/12) <stridey@gmail.com>'s request for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 241797: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=241797&action=edit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=pink ...

superreview requested: [Bug 47475] Need "Show(View) Image" / "Reload Image" on context menu : [Attachment 233530] unrotted, addressing bz's review comments from before
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 47475: Need "Show(View) Image" / "Reload Image" on context menu https://bugzilla.mozilla.org/show_bug.cgi?id=47475 Attachment 233530: unrotted, addressing bz's review comments from before https://bugzilla.mozilla.org/attachment.cgi?id=233530&action=edit ...

superreview requested: [Bug 285911] XPrint hardcodes english string with literal "Mozilla" : [Attachment 183036] Just remove "Mozilla" from the string
Ian Neal <bugzilla@arlen.demon.co.uk> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 285911: XPrint hardcodes english string with literal "Mozilla" https://bugzilla.mozilla.org/show_bug.cgi?id=285911 Attachment 183036: Just remove "Mozilla" from the string https://bugzilla.mozilla.org/attachment.cgi?id=183036&action=edit ------- Additional Comments from Ian Neal <bugzilla@arlen.demon.co.uk> No sign of roland ...

superreview cancelled: [Bug 258485] "Refresh Live Bookmark" should be "Reload Live Bookmark" : [Attachment 176976] quick text change of "refresh"
Tim Meader <tmeader@gmail.com> has cancelled Tim Meader <tmeader@gmail.com>'s request for superreview: Bug 258485: "Refresh Live Bookmark" should be "Reload Live Bookmark" https://bugzilla.mozilla.org/show_bug.cgi?id=258485 Attachment 176976: quick text change of "refresh" https://bugzilla.mozilla.org/attachment.cgi?id=176976&action=edit ------- Additional Comments from Tim Meader <tmeader@gmail.com> Please checkin if you find this okay. ...

superreview requested: [Bug 355204] Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" : [Attachment 241740] New AddBookmark.nib
froodian (unreliable 10/7-10/12) <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 355204: Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" https://bugzilla.mozilla.org/show_bug.cgi?id=355204 Attachment 241740: New AddBookmark.nib https://bugzilla.mozilla.org/attachment.cgi?id=241740&action=edit ------- Additional Comments from froodian (unreliable 10/7-10/12) <stridey@gmail.com> Same as last time, but sets the minimum size to 450, per comment 2. ...

Web resources about - superreview requested: [Bug 171575] Implement "find bookmark" : [Attachment 178832] implement "show in tree" - netscape.mozilla.reviewers

Resources last updated: 2/16/2016 7:09:54 AM