superreview requested: [Bug 131106] Make 'default browser' shouldn't steal image file associations from image programs : [Attachment 139348] only take "default browser" types for Seamonkey/Firebird

Mike Connor <mconnor@myrealbox.com> has asked Ben Goodger (I don't read
bugmail) <bugs@bengoodger.com> for superreview:

Bug 131106: Make 'default browser' shouldn't steal image file associations from
image programs
http://bugzilla.mozilla.org/show_bug.cgi?id=131106

Attachment 139348: only take "default browser" types for Seamonkey/Firebird by default
http://bugzilla.mozilla.org/attachment.cgi?id=139348&action=edit

------- Additional Comments from Mike Connor <mconnor@myrealbox.com>
http://lxr.mozilla.org/mozilla/source/xpfe/components/winhooks/nsSetDefaultBrow
ser.js#78 specifies six things as "default browser" settings which are always
set, but this part of winhooks makes a larger number default to on.

This will not affect existing Mozilla installations, as those installations may
modify the rest of this list in the advanced prefs, and future "set as default"
actions use those settings.  The exception is in the Prefs dialog button, where
it will force these six on (as it should).

For new users, however, we shouldn't take these by default.  Other than win
9x/ME/early 2k versions, Windows has an image viewer that beats Mozilla.  Worst
case is that those users have IE for their images, and if they want to change
it badly enough they do it via the prefs panel.  In Firebird, Ben already said
that we aren't going to have UI for this, if they want the image associations
they can do it themselves via the Windows interface.

We may want to consider for Firebird whether we should explicitly force the
images off in the Set As Default Browser button so that existing users aren't
affected.

This needs to happen here as the default browser dialog uses these values, so
product-specific changes won't be enough.
0
bugzilla
1/18/2004 5:57:53 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
824 Views

Similar Articles

[PageSpeed] 5

Reply:

Similar Artilces:

superreview cancelled: [Bug 131106] Make 'default browser' shouldn't steal image file associations from image programs : [Attachment 139348] only take "default browser" types for Seamonkey/Firebird b
Mike Connor <mconnor@myrealbox.com> has cancelled Mike Connor <mconnor@myrealbox.com>'s request for superreview: Bug 131106: Make 'default browser' shouldn't steal image file associations from image programs http://bugzilla.mozilla.org/show_bug.cgi?id=131106 Attachment 139348: only take "default browser" types for Seamonkey/Firebird by default http://bugzilla.mozilla.org/attachment.cgi?id=139348&action=edit ------- Additional Comments from Mike Connor <mconnor@myrealbox.com> forked for Firefox, if someone wants to take this and get r...

superreview requested: [Bug 131106] Make 'default browser' shouldn't steal image file associations from image programs : [Attachment 184578] Patch
Frank Wein <bugzilla@mcsmurf.de> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 131106: Make 'default browser' shouldn't steal image file associations from image programs https://bugzilla.mozilla.org/show_bug.cgi?id=131106 Attachment 184578: Patch https://bugzilla.mozilla.org/attachment.cgi?id=184578&action=edit ...

superreview granted: [Bug 131106] Make 'default browser' shouldn't steal image file associations from image programs : [Attachment 184578] Patch
jag (Peter Annema) <jag@tty.nl> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 131106: Make 'default browser' shouldn't steal image file associations from image programs https://bugzilla.mozilla.org/show_bug.cgi?id=131106 Attachment 184578: Patch https://bugzilla.mozilla.org/attachment.cgi?id=184578&action=edit ...

superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...

superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...

superreview requested: [Bug 280947] Fix for bug 279945 breaks dragging of dynamic images : [Attachment 173340] "fix" the file extension in the image URI when d&d'ing an image...
Johnny Stenback <jst@mozilla.org> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 280947: Fix for bug 279945 breaks dragging of dynamic images https://bugzilla.mozilla.org/show_bug.cgi?id=280947 Attachment 173340: "fix" the file extension in the image URI when d&d'ing an image... https://bugzilla.mozilla.org/attachment.cgi?id=173340&action=edit ...

superreview requested: [Bug 67873] [FILE]onchange for input type="file" doesn't behave correctly : [Attachment 141215] This fixes both testcases and the various tests I've tried with it
Boris Zbarsky <bzbarsky@mit.edu> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 67873: [FILE]onchange for input type="file" doesn't behave correctly http://bugzilla.mozilla.org/show_bug.cgi?id=67873 Attachment 141215: This fixes both testcases and the various tests I've tried with it http://bugzilla.mozilla.org/attachment.cgi?id=141215&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> peterv, I choose you! ...

superreview requested: [Bug 47475] Need "Show(View) Image" / "Reload Image" on context menu : [Attachment 233530] unrotted, addressing bz's review comments from before
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 47475: Need "Show(View) Image" / "Reload Image" on context menu https://bugzilla.mozilla.org/show_bug.cgi?id=47475 Attachment 233530: unrotted, addressing bz's review comments from before https://bugzilla.mozilla.org/attachment.cgi?id=233530&action=edit ...

superreview requested: [Bug 180620] Images don't display their alt text when images are disabled (have to restart browser to make pref take effect) : [Attachment 140100] patch
David Baron <dbaron@dbaron.org> has asked Boris Zbarsky <bz-vacation@mit.edu> for superreview: Bug 180620: Images don't display their alt text when images are disabled (have to restart browser to make pref take effect) http://bugzilla.mozilla.org/show_bug.cgi?id=180620 Attachment 140100: patch http://bugzilla.mozilla.org/attachment.cgi?id=140100&action=edit ...

superreview requested: [Bug 180620] Images don't display their alt text when images are disabled (have to restart browser to make pref take effect) : [Attachment 140026] patch
David Baron <dbaron@dbaron.org> has asked Boris Zbarsky <bz-vacation@mit.edu> for superreview: Bug 180620: Images don't display their alt text when images are disabled (have to restart browser to make pref take effect) http://bugzilla.mozilla.org/show_bug.cgi?id=180620 Attachment 140026: patch http://bugzilla.mozilla.org/attachment.cgi?id=140026&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #3
Serge GAUTHERIE <gautheri@noos.fr> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #4
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No super-review from <bienvenu@nventure.com> since '2004-04-26' :-( ...

Web resources about - superreview requested: [Bug 131106] Make 'default browser' shouldn't steal image file associations from image programs : [Attachment 139348] only take "default browser" types for Seamonkey/Firebird - netscape.mozilla.reviewers

Resources last updated: 12/5/2015 8:34:09 AM