superreview requested: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 163330] corrects neil's comments

Jean-Marc Desperrier <jmdesp@alussinan.org> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 123006: Keyword substitution with %s doesn't escape characters
https://bugzilla.mozilla.org/show_bug.cgi?id=123006

Attachment 163330: corrects neil's comments
https://bugzilla.mozilla.org/attachment.cgi?id=163330&action=edit
0
bugzilla
10/25/2004 5:22:35 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
484 Views

Similar Articles

[PageSpeed] 29

Reply:

Similar Artilces:

superreview granted: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 163330] corrects neil's comments
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jean-Marc Desperrier <jmdesp@alussinan.org>'s request for superreview: Bug 123006: Keyword substitution with %s doesn't escape characters https://bugzilla.mozilla.org/show_bug.cgi?id=123006 Attachment 163330: corrects neil's comments https://bugzilla.mozilla.org/attachment.cgi?id=163330&action=edit ...

superreview requested: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 139974] Encoding all characters for %s replacement (complete urlencoding); no encoding for %S
timeless@myrealbox.com (working) <timeless@bemail.org> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 123006: Keyword substitution with %s doesn't escape characters https://bugzilla.mozilla.org/show_bug.cgi?id=123006 Attachment 139974: Encoding all characters for %s replacement (complete urlencoding); no encoding for %S https://bugzilla.mozilla.org/attachment.cgi?id=139974&action=edit ...

superreview requested: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 162990] nit corrected mozilla patch
Jean-Marc Desperrier <jmdesp@alussinan.org> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 123006: Keyword substitution with %s doesn't escape characters https://bugzilla.mozilla.org/show_bug.cgi?id=123006 Attachment 162990: nit corrected mozilla patch https://bugzilla.mozilla.org/attachment.cgi?id=162990&action=edit ...

superreview granted: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 139974] Encoding all characters for %s replacement (complete urlencoding); no encoding for %S
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 123006: Keyword substitution with %s doesn't escape characters https://bugzilla.mozilla.org/show_bug.cgi?id=123006 Attachment 139974: Encoding all characters for %s replacement (complete urlencoding); no encoding for %S https://bugzilla.mozilla.org/attachment.cgi?id=139974&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> >+ shortcutURL =...

superreview requested: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 162844] Updated patch for Mozilla
Jean-Marc Desperrier <jmdesp@alussinan.org> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 123006: Keyword substitution with %s doesn't escape characters https://bugzilla.mozilla.org/show_bug.cgi?id=123006 Attachment 162844: Updated patch for Mozilla https://bugzilla.mozilla.org/attachment.cgi?id=162844&action=edit ...

superreview denied: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 162990] nit corrected mozilla patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has denied Jean-Marc Desperrier <jmdesp@alussinan.org>'s request for superreview: Bug 123006: Keyword substitution with %s doesn't escape characters https://bugzilla.mozilla.org/show_bug.cgi?id=123006 Attachment 162990: nit corrected mozilla patch https://bugzilla.mozilla.org/attachment.cgi?id=162990&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Sorry, didn't you know that /%[sS]/ is already a RegExp? Compare [] is a new Array, {} is ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ...

superreview granted: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 162844] Updated patch for Mozilla
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jean-Marc Desperrier <jmdesp@alussinan.org>'s request for superreview: Bug 123006: Keyword substitution with %s doesn't escape characters https://bugzilla.mozilla.org/show_bug.cgi?id=123006 Attachment 162844: Updated patch for Mozilla https://bugzilla.mozilla.org/attachment.cgi?id=162844&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> >+ shortcutURL = shortcutURL.match(/%[sS]/) ? shortcutURL.replace(/%s/g, encodeURICompo...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky. Land this either _really_ early in 1.8b2 or in 1.9a.... ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173127] patch v1
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173127: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=173127&action=edit ...

superreview requested: [Bug 232722] change 'character coding' to 'character encoding' : [Attachment 140854] Addressed jshin's comments
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 232722: change 'character coding' to 'character encoding' http://bugzilla.mozilla.org/show_bug.cgi?id=232722 Attachment 140854: Addressed jshin's comments http://bugzilla.mozilla.org/attachment.cgi?id=140854&action=edit ...

superreview requested: [Bug 231034] Tab doesn't scroll though address list : [Attachment 140245] updated patch with neil's comments
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 231034: Tab doesn't scroll though address list http://bugzilla.mozilla.org/show_bug.cgi?id=231034 Attachment 140245: updated patch with neil's comments http://bugzilla.mozilla.org/attachment.cgi?id=140245&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> moving forward the r, requesting sr. ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173127] patch v1
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173127: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=173127&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky, but it sounds like some cleanup of incremental vs final chunk is in order.... ...

superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...