superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...

superreview requested: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 144546] patch
Andrew Schultz <ajschult@mindspring.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 144546: patch http://bugzilla.mozilla.org/attachment.cgi?id=144546&action=edit ------- Additional Comments from Andrew Schultz <ajschult@mindspring.com> note that with bug 240929 and bug 236294 fixed, only the ErrorHandler part here is relevant. ...

superreview requested: [Bug 280470] input type="image" .src property doesn't resolve relative URIs : [Attachment 173705] Patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 280470: input type="image" .src property doesn't resolve relative URIs https://bugzilla.mozilla.org/show_bug.cgi?id=280470 Attachment 173705: Patch https://bugzilla.mozilla.org/attachment.cgi?id=173705&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This is the right thing, I think. ...

superreview granted: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 144546] patch
Brian Ryner (IBM) <bryner@brianryner.com> has granted Andrew Schultz <ajschult@mindspring.com>'s request for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 144546: patch http://bugzilla.mozilla.org/attachment.cgi?id=144546&action=edit ...

superreview requested: [Bug 131106] Make 'default browser' shouldn't steal image file associations from image programs : [Attachment 139348] only take "default browser" types for Seamonkey/Firebird
Mike Connor <mconnor@myrealbox.com> has asked Ben Goodger (I don't read bugmail) <bugs@bengoodger.com> for superreview: Bug 131106: Make 'default browser' shouldn't steal image file associations from image programs http://bugzilla.mozilla.org/show_bug.cgi?id=131106 Attachment 139348: only take "default browser" types for Seamonkey/Firebird by default http://bugzilla.mozilla.org/attachment.cgi?id=139348&action=edit ------- Additional Comments from Mike Connor <mconnor@myrealbox.com> http://lxr.mozilla.org/mozilla/source/xpfe/componen...

superreview requested: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 147374] fix error dialog
Andrew Schultz <ajschult@mindspring.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 147374: fix error dialog http://bugzilla.mozilla.org/attachment.cgi?id=147374&action=edit ...

superreview granted: [Bug 280470] input type="image" .src property doesn't resolve relative URIs : [Attachment 173705] Patch
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 280470: input type="image" .src property doesn't resolve relative URIs https://bugzilla.mozilla.org/show_bug.cgi?id=280470 Attachment 173705: Patch https://bugzilla.mozilla.org/attachment.cgi?id=173705&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview requested: [Bug 220451] Popup Manager's "Allowed Sites" dialog doesn't persist size and position : [Attachment 132310] Patch
Stefan Borggraefe <borggraefe@despammed.com> has asked Alec Flett <alecf@flett.org> for superreview: Bug 220451: Popup Manager's "Allowed Sites" dialog doesn't persist size and position http://bugzilla.mozilla.org/show_bug.cgi?id=220451 Attachment 132310: Patch http://bugzilla.mozilla.org/attachment.cgi?id=132310&action=edit ...

superreview requested: [Bug 248606] "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame : [Attachment 151705] patch
David Baron <dbaron@dbaron.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 248606: "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame http://bugzilla.mozilla.org/show_bug.cgi?id=248606 Attachment 151705: patch http://bugzilla.mozilla.org/attachment.cgi?id=151705&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> This patch separates the two coordinate transformations (so they're more like they used to be before bug 20022), and restores the baseV...

superreview granted: [Bug 249593] [WinNT] Firefox won't start because of missing Function "CopyStgMedium" in urlmon.dll (or urlmon.dll doesn't exist at all) : [Attachment 153192] patch v1
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 249593: [WinNT] Firefox won't start because of missing Function "CopyStgMedium" in urlmon.dll (or urlmon.dll doesn't exist at all) http://bugzilla.mozilla.org/show_bug.cgi?id=249593 Attachment 153192: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=153192&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> This patch hasn't regressed the ability to paste clipboard images in Thunderb...

superreview requested: [Bug 239535] [Mac] nsDateTimeFormatMac is broken in Japanese locale (Page Info fails to load / Media Tab doesn't work / Cookie Manager doesn't show "Expires") : [Attachment 154
Constantine A. Murenin <cnst+bmo@bugmail.mojo.ru> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 239535: [Mac] nsDateTimeFormatMac is broken in Japanese locale (Page Info fails to load / Media Tab doesn't work / Cookie Manager doesn't show "Expires") http://bugzilla.mozilla.org/show_bug.cgi?id=239535 Attachment 154694: patch http://bugzilla.mozilla.org/attachment.cgi?id=154694&action=edit ...

superreview requested: [Bug 67873] [FILE]onchange for input type="file" doesn't behave correctly : [Attachment 141215] This fixes both testcases and the various tests I've tried with it
Boris Zbarsky <bzbarsky@mit.edu> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 67873: [FILE]onchange for input type="file" doesn't behave correctly http://bugzilla.mozilla.org/show_bug.cgi?id=67873 Attachment 141215: This fixes both testcases and the various tests I've tried with it http://bugzilla.mozilla.org/attachment.cgi?id=141215&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> peterv, I choose you! ...

superreview cancelled: [Bug 131106] Make 'default browser' shouldn't steal image file associations from image programs : [Attachment 139348] only take "default browser" types for Seamonkey/Firebird b
Mike Connor <mconnor@myrealbox.com> has cancelled Mike Connor <mconnor@myrealbox.com>'s request for superreview: Bug 131106: Make 'default browser' shouldn't steal image file associations from image programs http://bugzilla.mozilla.org/show_bug.cgi?id=131106 Attachment 139348: only take "default browser" types for Seamonkey/Firebird by default http://bugzilla.mozilla.org/attachment.cgi?id=139348&action=edit ------- Additional Comments from Mike Connor <mconnor@myrealbox.com> forked for Firefox, if someone wants to take this and get r...

superreview granted: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 147374] fix error dialog
Brian Ryner (IBM) <bryner@brianryner.com> has granted Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 147374: fix error dialog http://bugzilla.mozilla.org/attachment.cgi?id=147374&action=edit ...