superreview requested: [Bug 112281] ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items : [Attachment 135533] Proposed patch

Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu> has asked Robert
O'Callahan <roc@ocallahan.org> for superreview:

Bug 112281: ctrl+shift+click whle making range selections in form <select>
shouldn't wipe out other selected items
http://bugzilla.mozilla.org/show_bug.cgi?id=112281

Attachment 135533: Proposed patch
http://bugzilla.mozilla.org/attachment.cgi?id=135533&action=edit

------- Additional Comments from Boris Zbarsky (real world intrudes)
<bz-vacation@mit.edu>
roc, what do you think?
0
bugzilla
11/15/2003 3:54:41 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
814 Views

Similar Articles

[PageSpeed] 54

Reply:

Similar Artilces:

superreview granted: [Bug 112281] ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items : [Attachment 135533] Proposed patch
Robert O'Callahan <roc@ocallahan.org> has granted Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu>'s request for superreview: Bug 112281: ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items http://bugzilla.mozilla.org/show_bug.cgi?id=112281 Attachment 135533: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=135533&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> looks quite straighforward :-) ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149416] Patch for 1.7 per roc
Doron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149416: Patch for 1.7 per roc - adding a if() check http://bugzilla.mozilla.org/attachment.cgi?id=149416&action=edit ...

superreview requested: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The problem is that "if (aDesiredSize.width > dropdownDesiredSize.width)" is false so we never do the second...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149404] Cleanup
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149404: Cleanup http://bugzilla.mozilla.org/attachment.cgi?id=149404&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Whoops, I accidentally mixed up part of this with another patch. Someone please ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149378] Change the check for if the dropdown is show
Doron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149378: Change the check for if the dropdown is shown to the correct way http://bugzilla.mozilla.org/attachment.cgi?id=149378&action=edit ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149525] Work around focus issue
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Richard Suitor <rsuitor@acm.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149525: Work around focus issue http://bugzilla.mozilla.org/attachment.cgi?id=149525&action=edit ...

superreview granted: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149416] Patch for 1.7 per roc
Robert O'Callahan <roc@ocallahan.org> has granted Doron Rosenberg (IBM) <doronr@us.ibm.com>'s request for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149416: Patch for 1.7 per roc - adding a if() check http://bugzilla.mozilla.org/attachment.cgi?id=149416&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> + if (mComboBoxFrame != nsnull) { should be + if (...

superreview requested: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> These two changes are not needed to fix this bug: Removed an unused parameter from GetMaxOptionHeight(). Make sure GetNum...

superreview requested: [Bug 245224] Selected attribute of <tab> doesn't work : [Attachment 168134] Patch to respect initially selected tab
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 245224: Selected attribute of <tab> doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=245224 Attachment 168134: Patch to respect initially selected tab https://bugzilla.mozilla.org/attachment.cgi?id=168134&action=edit ...

superreview granted: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Looks reasonable. Watch Tp carefully, though! ...

superreview granted: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149404] Cleanup
Robert O'Callahan <roc@ocallahan.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149404: Cleanup http://bugzilla.mozilla.org/attachment.cgi?id=149404&action=edit ...

superreview requested: [Bug 301737] Support multiple selection for xul:listbox : [Attachment 190379] The last patch didn't reduce the selection when you went shift+down then shift+up, or vice-versa.
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 301737: Support multiple selection for xul:listbox https://bugzilla.mozilla.org/show_bug.cgi?id=301737 Attachment 190379: The last patch didn't reduce the selection when you went shift+down then shift+up, or vice-versa. This patch also fixes the firing of accessible selection_* events https://bugzilla.mozilla.org/attachment.cgi?id=190379&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net>...

superreview cancelled: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149378] Change the check for if the dropdown is show
Simon Paquet (back in business) <bugzilla@babylonsounds.com> has cancelled Doron Rosenberg (IBM) <doronr@us.ibm.com>'s request for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149378: Change the check for if the dropdown is shown to the correct way http://bugzilla.mozilla.org/attachment.cgi?id=149378&action=edit ------- Additional Comments from Simon Paquet (back in business) <bugzilla@babylonsounds.com> ...

superreview granted: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: layout/forms/nsListControlFrame.cpp >+ nsIPresShell* shell = aPresContext->GetPresShell(); I thi...

Web resources about - superreview requested: [Bug 112281] ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items : [Attachment 135533] Proposed patch - netscape.mozilla.reviewers

Concrete and Wood: The Unusual Workspaces of Security Firm Bitium
Today's featured workspace belongs to Santa Monica-based security firm Bitium. It's a homier office than you might expect.

Internet Explorer 9 keyboard shortcuts
Learn keyboard shortcuts to perform actions in Internet Explorer 9.

app - Stack Alert [Opera] - Keep tabs on your inbox without needing to have a Stack Exchange site open ...
Stack Exchange log in - chat - about - faq Stack Apps Questions Tags Users Badges Unanswered Ask Question Stack Alert [Opera] - Keep tabs on ...

Classic Shell - Browse /Version 3.6.1 general release at SourceForge.net
Classic Shell adds some missing features to Windows 7 and Vista like a classic start menu, toolbar for Explorer and others.

Classic Shell: History
HOME - FEATURES - F.A.Q. - HISTORY - GALLERY - TESTIMONIALS - SKINNING - ALTERNATIVE SOLUTIONS Version 3.5.0 general release (Mar, 2012): Added ...

Put Paper over Automatic Toilet Sensors to Prevent Accidental Flushes
Mankind, in its great hubris, created automatically flushing toilets as a way to ensure clean public bathrooms. The result, however, are wonky ...

Windows tip News, Videos, Reviews and Gossip - Lifehacker
Drag and Drop with a Right Click to Copy, Create Shortcuts, and More in Windows Explorer. Move Windows Around Quickly Using Your Keyboard in ...

Classic Shell - Browse Files at SourceForge.net
Classic Shell adds some missing features to Windows 7 and Vista like a classic start menu, toolbar for Explorer and others.

Resources last updated: 1/3/2016 9:27:24 AM