superreview granted: [Bug 97283] [FIX] Mouse wheel scrolling does not work for elements such as div using overflow - auto or scroll : [Attachment 154083] Patch B rev. 3 #2

David Baron <dbaron@dbaron.org> has granted David Baron <dbaron@dbaron.org>'s
request for superreview:
Bug 97283: [FIX] Mouse wheel scrolling does not work for elements such as div
using overflow - auto or scroll
http://bugzilla.mozilla.org/show_bug.cgi?id=97283

Attachment 154083: Patch B rev. 3
http://bugzilla.mozilla.org/attachment.cgi?id=154083&action=edit

------- Additional Comments from David Baron <dbaron@dbaron.org>
Actually, never mind -- I was misreading something.  As long as this doesn't
break keyboard scrolling of comboboxes, that is.  (I'm not sure what's used for
wheel scrolling and what's used for keyboard scrolling.  While you're here, it
might be nice to document that, actually.)

But one more thing:

>+  if (!passToParent && scrollView) {

I'm pretty sure scrollView is guaranteed to be non-null if passToParent is
false, so you can drop the scrollView test and turn this into an if/else rather
than two ifs.
0
bugzilla
7/23/2004 9:04:16 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
572 Views

Similar Articles

[PageSpeed] 11

Reply:

Similar Artilces:

superreview requested: [Bug 78786] [FIX] Can't scroll URL bar history drop down with mouse wheel : [Attachment 153557] Patch A rev. 1 (must have patch from bug 97283 first)
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 78786: [FIX] Can't scroll URL bar history drop down with mouse wheel http://bugzilla.mozilla.org/show_bug.cgi?id=78786 Attachment 153557: Patch A rev. 1 (must have patch from bug 97283 first) http://bugzilla.mozilla.org/attachment.cgi?id=153557&action=edit ...

superreview cancelled: [Bug 78786] [FIX] Can't scroll URL bar history drop down with mouse wheel : [Attachment 153557] Patch A rev. 1 (must have patch from bug 97283 first)
Mats Palmgren <mats.palmgren@bredband.net> has cancelled Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 78786: [FIX] Can't scroll URL bar history drop down with mouse wheel http://bugzilla.mozilla.org/show_bug.cgi?id=78786 Attachment 153557: Patch A rev. 1 (must have patch from bug 97283 first) http://bugzilla.mozilla.org/attachment.cgi?id=153557&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> "Patch B rev. 2" on bug 97283 now includes a fix for this bug too. ...

superreview granted: [Bug 189308] javascript <body onscroll> -event don't work with mouse scroll, mouse wheel or keyboard arrow : [Attachment 192056] fix #2
David Baron <dbaron@mozillafoundation.org> has granted Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 189308: javascript <body onscroll> -event don't work with mouse scroll, mouse wheel or keyboard arrow https://bugzilla.mozilla.org/show_bug.cgi?id=189308 Attachment 192056: fix #2 https://bugzilla.mozilla.org/attachment.cgi?id=192056&action=edit ------- Additional Comments from David Baron <dbaron@mozillafoundation.org> ok, r+sr=dbaron if: * you change "static void PR_CALLBACK" to "PR_STATIC_CAL...

superreview granted: [Bug 254966] position:fixed and overflow:scroll not keyboard accessible : [Attachment 156348] Fix mouse drag scrolling. Scroll to iframe only if not already partially visible via
Robert O'Callahan <roc@ocallahan.org> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 254966: position:fixed and overflow:scroll not keyboard accessible http://bugzilla.mozilla.org/show_bug.cgi?id=254966 Attachment 156348: Fix mouse drag scrolling. Scroll to iframe only if not already partially visible via ScrollFrameIntoView(frame, NS_PRESSHELL_SCROLL_IF_NOT_VISIBLE, ...) http://bugzilla.mozilla.org/attachment.cgi?id=156348&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> c...

superreview requested: [Bug 189308] javascript <body onscroll> -event don't work with mouse scroll, mouse wheel or keyboard arrow : [Attachment 192056] fix #2 #2
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked for superreview: Bug 189308: javascript <body onscroll> -event don't work with mouse scroll, mouse wheel or keyboard arrow https://bugzilla.mozilla.org/show_bug.cgi?id=189308 Attachment 192056: fix #2 https://bugzilla.mozilla.org/attachment.cgi?id=192056&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> The fix for bug 303484 doesn't quite fix the issues in attachment 186026 in conjunction with the previous version of this patch. The problem is t...

superreview granted: [Bug 180015] [FIX] {drag-select} Scrolling by selecting & dragging jumps to top of page when marquee tag is encountered : [Attachment 168086] Patch rev. 2 (using nsIView::GetOffs
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 180015: [FIX] {drag-select} Scrolling by selecting & dragging jumps to top of page when marquee tag is encountered https://bugzilla.mozilla.org/show_bug.cgi?id=180015 Attachment 168086: Patch rev. 2 (using nsIView::GetOffsetTo) https://bugzilla.mozilla.org/attachment.cgi?id=168086&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, though the closestView != resultFrameView check is redundant, i...

superreview granted: [Bug 364125] middle-click on scroll bar keeps scrolling until the left mouse button is pressed : [Attachment 248984] A simple patch that fixes this bug.
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Smaug <Olli.Pettay@gmail.com>'s request for superreview: Bug 364125: middle-click on scroll bar keeps scrolling until the left mouse button is pressed https://bugzilla.mozilla.org/show_bug.cgi?id=364125 Attachment 248984: A simple patch that fixes this bug. https://bugzilla.mozilla.org/attachment.cgi?id=248984&action=edit ...

superreview granted: [Bug 256538] Can't scroll window with scroll wheel if a position: fixed element covers the top-left corner of the viewport. : [Attachment 160364] this solves the scrolling proble
Brian Ryner (IBM) <bryner@brianryner.com> has granted Geoff Beier <me@mollyandgeoff.com>'s request for superreview: Bug 256538: Can't scroll window with scroll wheel if a position: fixed element covers the top-left corner of the viewport. https://bugzilla.mozilla.org/show_bug.cgi?id=256538 Attachment 160364: this solves the scrolling problem for all test cases i've seen https://bugzilla.mozilla.org/attachment.cgi?id=160364&action=edit ...

superreview requested: [Bug 189308] javascript <body onscroll> -event don't work with mouse scroll, mouse wheel or keyboard arrow : [Attachment 192056] fix #2
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked David Baron <dbaron@mozillafoundation.org> for superreview: Bug 189308: javascript <body onscroll> -event don't work with mouse scroll, mouse wheel or keyboard arrow https://bugzilla.mozilla.org/show_bug.cgi?id=189308 Attachment 192056: fix #2 https://bugzilla.mozilla.org/attachment.cgi?id=192056&action=edit ...

superreview requested: [Bug 254966] position:fixed and overflow:scroll not keyboard accessible : [Attachment 156348] Fix mouse drag scrolling. Scroll to iframe only if not already partially visible v
Aaron Leventhal <aaronleventhal@moonset.net> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 254966: position:fixed and overflow:scroll not keyboard accessible http://bugzilla.mozilla.org/show_bug.cgi?id=254966 Attachment 156348: Fix mouse drag scrolling. Scroll to iframe only if not already partially visible via ScrollFrameIntoView(frame, NS_PRESSHELL_SCROLL_IF_NOT_VISIBLE, ...) http://bugzilla.mozilla.org/attachment.cgi?id=156348&action=edit ...

superreview granted: [Bug 386687] mouse wheel events propagated from plugin windows are dropped and so do not scroll : [Attachment 291989] Patch 2
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Michael Ventnor <ventnor.bugzilla@yahoo.com.au>'s request for superreview: Bug 386687: mouse wheel events propagated from plugin windows are dropped a= nd so do not scroll https://bugzilla.mozilla.org/show_bug.cgi?id=3D386687 Attachment 291989: Patch 2 https://bugzilla.mozilla.org/attachment.cgi?id=3D291989&action=3Dedit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.or= g> + event.isShift =3D (aEvent->state & GDK_SHIFT_MASK)=0D + ? PR_TRUE : PR_FALSE...

superreview granted: [Bug 342372] [FIX] <legend> does not scroll into view when it receives focus : [Attachment 226601] Patch rev. 2
Boris Zbarsky (gone June 26 -- Jul 13) <bzbarsky@mit.edu> has granted superreview: Bug 342372: [FIX] <legend> does not scroll into view when it receives focus https://bugzilla.mozilla.org/show_bug.cgi?id=342372 Attachment 226601: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=226601&action=edit ...

superreview granted: [Bug 212556] mouse wheel scrolling doesn't work on some other sites after window has been minimized : [Attachment 129497] patch
Johnny Stenback <jst@netscape.com> has granted Brian Ryner <bryner@brianryner.com>'s request for superreview: Bug 212556: mouse wheel scrolling doesn't work on some other sites after window has been minimized http://bugzilla.mozilla.org/show_bug.cgi?id=212556 Attachment 129497: patch http://bugzilla.mozilla.org/attachment.cgi?id=129497&action=edit ------- Additional Comments from Johnny Stenback <jst@netscape.com> sr=jst ...

superreview granted: [Bug 309822] Scroll wheel doesn't scroll list boxes [Mac] : [Attachment 197226] Fix, use event.point instead of event.refPoint (branch only)
Simon Fraser <sfraser_bugs@smfr.org> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 309822: Scroll wheel doesn't scroll list boxes [Mac] https://bugzilla.mozilla.org/show_bug.cgi?id=309822 Attachment 197226: Fix, use event.point instead of event.refPoint (branch only) https://bugzilla.mozilla.org/attachment.cgi?id=197226&action=edit ...

superreview granted: [Bug 257998] Using mouse wheel in edit mail filter window causes crash : [Attachment 158654] Patch rev. 2
Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 257998: Using mouse wheel in edit mail filter window causes crash http://bugzilla.mozilla.org/show_bug.cgi?id=257998 Attachment 158654: Patch rev. 2 http://bugzilla.mozilla.org/attachment.cgi?id=158654&action=edit ------- Additional Comments from Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu> r+sr=bzbarsky ...

Web resources about - superreview granted: [Bug 97283] [FIX] Mouse wheel scrolling does not work for elements such as div using overflow - auto or scroll : [Attachment 154083] Patch B rev. 3 #2 - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 11/21/2015 1:01:47 AM