superreview granted: [Bug 72361] ctrl+click/middle click a bookmark should open it in new window/new tab : [Attachment 153658] Updated patch

Dan Mosedale <dmose@mozilla.org> has granted Dan Mosedale <dmose@mozilla.org>'s
request for superreview:
Bug 72361: ctrl+click/middle click a bookmark should open it in new window/new
tab
http://bugzilla.mozilla.org/show_bug.cgi?id=72361

Attachment 153658: Updated patch
http://bugzilla.mozilla.org/attachment.cgi?id=153658&action=edit

------- Additional Comments from Dan Mosedale <dmose@mozilla.org>
With the JS strict fix that Neil noticed, sr=dmose.
0
bugzilla
7/20/2004 10:01:42 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
757 Views

Similar Articles

[PageSpeed] 16

Reply:

Similar Artilces:

superreview granted: [Bug 72361] ctrl+click/middle click a bookmark should open it in new window/new tab : [Attachment 153754] Patch to be checked in
Wladimir Palant <trev@gtchat.de> has granted Wladimir Palant <trev@gtchat.de>'s request for superreview: Bug 72361: ctrl+click/middle click a bookmark should open it in new window/new tab http://bugzilla.mozilla.org/show_bug.cgi?id=72361 Attachment 153754: Patch to be checked in http://bugzilla.mozilla.org/attachment.cgi?id=153754&action=edit ------- Additional Comments from Wladimir Palant <trev@gtchat.de> Carrying over the review flags. ...

superreview requested: [Bug 336925] Middle Click Search Button should open new tab : [Attachment 222066] Middle-clicking Search opens results in new tab
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 336925: Middle Click Search Button should open new tab https://bugzilla.mozilla.org/show_bug.cgi?id=336925 Attachment 222066: Middle-clicking Search opens results in new tab https://bugzilla.mozilla.org/attachment.cgi?id=222066&action=edit ...

superreview cancelled: [Bug 336925] Middle Click Search Button should open new tab : [Attachment 222066] Middle-clicking Search opens results in new tab
Pam Greene (Google) <pamg.bugs@gmail.com> has cancelled Pam Greene (Google) <pamg.bugs@gmail.com>'s request for superreview: Bug 336925: Middle Click Search Button should open new tab https://bugzilla.mozilla.org/show_bug.cgi?id=336925 Attachment 222066: Middle-clicking Search opens results in new tab https://bugzilla.mozilla.org/attachment.cgi?id=222066&action=edit ------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com> (In reply to comment #10) > I think we should remove the aEvent null checks. > nit: no space after "!&...

superreview requested: [Bug 228840] Bookmarks toolbar
H�kan Waara <hwaara@gmail.com> has asked for superreview: Bug 228840: Bookmarks toolbar - Middle-click should open bookmark in new tab https://bugzilla.mozilla.org/show_bug.cgi?id=228840 Attachment 206184: Patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=206184&action=edit ------- Additional Comments from H�kan Waara <hwaara@gmail.com> Ok, so same patch but this also makes us listen for shift before deciding whether to focus a new tab/window. If shift is held down, we should do the reverse of what is set in the pref. ...

superreview granted: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 159443] optional addition to divert window.open to a new tab
Peter Van der Beken <peterv@propagandism.org> has granted Dan M <danm.moz@gmail.com>'s request for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 159443: optional addition to divert window.open to a new tab https://bugzilla.mozilla.org/attachment.cgi?id=159443&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> >Index: dom/src/base/nsGlobalWindow.cpp >=================================...

superreview granted: [Bug 159377] tab-group bookmark does nothing when no windows are open : [Attachment 139408] revised patch plus open bookmarks group in new window
Alec Flett <alecf@flett.org> has granted Andreas Kunz <durbacher@gmx.de>'s request for superreview: Bug 159377: tab-group bookmark does nothing when no windows are open http://bugzilla.mozilla.org/show_bug.cgi?id=159377 Attachment 139408: revised patch plus open bookmarks group in new window http://bugzilla.mozilla.org/attachment.cgi?id=139408&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> sr=alecf ...

superreview granted: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 161419] don't divert window.open to a new tab if the named wind
Johnny Stenback <jst@mozilla.jstenback.com> has granted Dan M <danm.moz@gmail.com>'s request for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 161419: don't divert window.open to a new tab if the named window exists https://bugzilla.mozilla.org/attachment.cgi?id=161419&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> sr=jst ...

superreview requested: [Bug 155132] [patch] md+click or middle+click mailto: link opens extra window (or tab) : [Attachment 171913] Updated patch against latest CVS (also cleaned up my whitespace)
Bruce Davidson <Bruce.Davidson@ipl.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 155132: [patch] md+click or middle+click mailto: link opens extra window (or tab) https://bugzilla.mozilla.org/show_bug.cgi?id=155132 Attachment 171913: Updated patch against latest CVS (also cleaned up my whitespace) https://bugzilla.mozilla.org/attachment.cgi?id=171913&action=edit ------- Additional Comments from Bruce Davidson <Bruce.Davidson@ipl.com> Just to confirm earlier IRC conversation: I don't believe Firefox detects this. Testing with an (...

superreview cancelled: [Bug 155132] [patch] md+click or middle+click mailto: link opens extra window (or tab) : [Attachment 171913] Updated patch against latest CVS (also cleaned up my whitespace)
Smokey Ardisson (offline Apr 10-20) <alqahira@mindspring.com> has cancelled Bruce Davidson <mozilla@transoceanic.org.uk>'s request for superreview: Bug 155132: [patch] md+click or middle+click mailto: link opens extra window (or tab) https://bugzilla.mozilla.org/show_bug.cgi?id=155132 Attachment 171913: Updated patch against latest CVS (also cleaned up my whitespace) https://bugzilla.mozilla.org/attachment.cgi?id=171913&action=edit ------- Additional Comments from Smokey Ardisson (offline Apr 10-20) <alqahira@mindspring.com> Cancelling sr request on this...

superreview granted: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177879] Patch to make externally-launched links open in new window (Seamonkey only)
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jeremy Morton <bugzilla@game-point.net>'s request for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177879: Patch to make externally-launched links open in new window (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177879&action=edit ...

superreview granted: [Bug 133117] 'Web Search for...' results should open in new tab rather than new window : [Attachment 232888] Updated patch v3
neil@parkwaycc.co.uk <neil@httl.net> has granted ParadigmK <paradigmk@technodrome.com>'s request for superreview: Bug 133117: 'Web Search for...' results should open in new tab rather than new window https://bugzilla.mozilla.org/show_bug.cgi?id=133117 Attachment 232888: Updated patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=232888&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+<!ENTITY openContextSearchTab.label "Open tab instead of window for a context menu web search"> >+&l...

superreview granted: [Bug 336925] Middle Click Search Button should open new tab : [Attachment 223863] Fresh patch, same code
Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> has granted Pam Greene (Google) <pamg.bugs@gmail.com>'s request for superreview: Bug 336925: Middle Click Search Button should open new tab https://bugzilla.mozilla.org/show_bug.cgi?id=336925 Attachment 223863: Fresh patch, same code https://bugzilla.mozilla.org/attachment.cgi?id=223863&action=edit ------- Additional Comments from Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> sr=ben@mozilla.org ...

superreview granted: [Bug 300485] Launching SeaMonkey when it's already running, with "open in new tab" preference, should opens a new tab rather than window. : [Attachment 190315] Updated for commen
jag (Peter Annema) <jag@tty.nl> has granted jag (Peter Annema) <jag@tty.nl>'s request for superreview: Bug 300485: Launching SeaMonkey when it's already running, with "open in new tab" preference, should opens a new tab rather than window. https://bugzilla.mozilla.org/show_bug.cgi?id=300485 Attachment 190315: Updated for comments https://bugzilla.mozilla.org/attachment.cgi?id=190315&action=edit ...

superreview granted: [Bug 133117] 'Web Search for...' results should open in new tab rather than new window : [Attachment 232613] Updated patch v2.1
neil@parkwaycc.co.uk <neil@httl.net> has granted ParadigmK <paradigmk@technodrome.com>'s request for superreview: Bug 133117: 'Web Search for...' results should open in new tab rather than new window https://bugzilla.mozilla.org/show_bug.cgi?id=133117 Attachment 232613: Updated patch v2.1 https://bugzilla.mozilla.org/attachment.cgi?id=232613&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >- if (!newWindowFlag) >+ if (!newWindowOrTabFlag) { > loadURI(defaultSearchURL); >- else >- wi...

Web resources about - superreview granted: [Bug 72361] ctrl+click/middle click a bookmark should open it in new window/new tab : [Attachment 153658] Updated patch - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/5/2015 11:49:00 PM