superreview granted: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143888] patch for callers, v2

Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger
<cbiesinger@gmx.at>'s request for superreview:
Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File |
Open  or  file protocol)
http://bugzilla.mozilla.org/show_bug.cgi?id=69114

Attachment 143888: patch for callers, v2
http://bugzilla.mozilla.org/attachment.cgi?id=143888&action=edit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
>Index: xpfe/components/bookmarks/src/nsBookmarksService.cpp

The changes to this are fine.  File a bug on firefox to change their fork
accordingly?

>Index: widget/src/windows/nsClipboard.cpp

>+    if ( IsInternetShortcut(filepath) ) {
>+	nsCAutoString url;
>+	ResolveShortcut ( file, url );
>+	if ( !url.IsEmpty() ) {
....
>+	  *outData = ToNewUnicode(url);
>+	  *outDataLen = url.Length() * sizeof(PRUnichar);

I think you want UTF8ToNewUnicode(url) and you want to
nsCRT::strlen((PRUnichar*)outData).  What you're doing just zero-pads "url",
which is not desirable as far as I know.

sr=bzbarsky with those issues addressed.
0
bugzilla
7/13/2004 5:40:43 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
658 Views

Similar Articles

[PageSpeed] 13

Reply:

Similar Artilces:

superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143888] patch for callers, v2
Christian Biesinger <cbiesinger@gmx.at> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143888: patch for callers, v2 http://bugzilla.mozilla.org/attachment.cgi?id=143888&action=edit ------- Additional Comments from Christian Biesinger <cbiesinger@gmx.at> I'll make those changes ...

superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143888] patch for callers, v2 #2
Christian Biesinger <cbiesinger@gmx.at> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143888: patch for callers, v2 http://bugzilla.mozilla.org/attachment.cgi?id=143888&action=edit ...

superreview granted: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143792] patch v4
Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger <cbiesinger@gmx.at>'s request for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143792: patch v4 http://bugzilla.mozilla.org/attachment.cgi?id=143792&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky, but I didn't verify general correctness of the win32 mumbo-jumbo (I don't know enough about win32 to do that). ...

superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143792] patch v4
Christian Biesinger <cbiesinger@gmx.at> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143792: patch v4 http://bugzilla.mozilla.org/attachment.cgi?id=143792&action=edit ------- Additional Comments from Christian Biesinger <cbiesinger@gmx.at> I'll change nsIFileProtocolHandler's uuid before checking in ...

superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143792] patch v4 #2
Christian Biesinger <cbiesinger@gmx.at> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143792: patch v4 http://bugzilla.mozilla.org/attachment.cgi?id=143792&action=edit ...

superreview granted: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:open
Stuart Morgan <stuart.morgan@alumni.case.edu> has granted Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org>'s request for superreview: Bug 363654: .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch https://bugzilla.mozilla.org/show_bug.cgi?id=363654 Attachment 248458: disables .url in file:open https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Well, that kinda sucks. ...

superreview requested: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:open
Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org> has asked Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 363654: .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch https://bugzilla.mozilla.org/show_bug.cgi?id=363654 Attachment 248458: disables .url in file:open https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit ------- Additional Comments from Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org> Asking for sr on this 7-char patch in case we need to take it ...

superreview granted: [Bug 355894] Open file dialog doesn't allow me to open XUL documents : [Attachment 241861] Fix v2
Mike Pinkerton <mikepinkerton@mac.com> has granted Mike Pinkerton <mikepinkerton@mac.com>'s request for superreview: Bug 355894: Open file dialog doesn't allow me to open XUL documents https://bugzilla.mozilla.org/show_bug.cgi?id=355894 Attachment 241861: Fix v2 https://bugzilla.mozilla.org/attachment.cgi?id=241861&action=edit ...

superreview granted: [Bug 241215] Standalone window's File|Open File does not work : [Attachment 148589] Proposed patch
Scott MacGregor <mscott@mozilla.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 241215: Standalone window's File|Open File does not work http://bugzilla.mozilla.org/show_bug.cgi?id=241215 Attachment 148589: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=148589&action=edit ...

superreview granted: [Bug 255366] File picker calls crash mozilla (open file, file attach, file browser, etc) : [Attachment 159629] Make our prototype for _gtk_file_chooser_dialog_new_fn() match real
Johnny Stenback <jst@mozilla.jstenback.com> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 255366: File picker calls crash mozilla (open file, file attach, file browser, etc) https://bugzilla.mozilla.org/show_bug.cgi?id=255366 Attachment 159629: Make our prototype for _gtk_file_chooser_dialog_new_fn() match reality (patch by bryner) https://bugzilla.mozilla.org/attachment.cgi?id=159629&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> Chris, was this done this way intentionally...

superreview granted: [Bug 227267] Upload file doesn't work well. It just upload file with zero size. [ftp only?] : [Attachment 137582] v1 patch
Daniel Veditz <dveditz+bmo@cruzio.com> has granted Darin Fisher <darin@meer.net>'s request for superreview: Bug 227267: Upload file doesn't work well. It just upload file with zero size. [ftp only?] http://bugzilla.mozilla.org/show_bug.cgi?id=227267 Attachment 137582: v1 patch http://bugzilla.mozilla.org/attachment.cgi?id=137582&action=edit ------- Additional Comments from Daniel Veditz <dveditz+bmo@cruzio.com> sr=dveditz ...

superreview granted: [Bug 236541] "do this automatically for files like this" doesn't work when Content-Disposition:attachment is used : [Attachment 208411] Patch for the core code per comment 38.
Darin Fisher <darin@meer.net> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 236541: "do this automatically for files like this" doesn't work when Content-Disposition:attachment is used https://bugzilla.mozilla.org/show_bug.cgi?id=236541 Attachment 208411: Patch for the core code per comment 38. https://bugzilla.mozilla.org/attachment.cgi?id=208411&action=edit ...

superreview requested: [Bug 355894] Open file dialog doesn't allow me to open XUL documents : [Attachment 241861] Fix v2
Josh Aas <joshmoz@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 355894: Open file dialog doesn't allow me to open XUL documents https://bugzilla.mozilla.org/show_bug.cgi?id=355894 Attachment 241861: Fix v2 https://bugzilla.mozilla.org/attachment.cgi?id=241861&action=edit ...

superreview cancelled: [Bug 355894] Open file dialog doesn't allow me to open XUL documents : [Attachment 241861] Fix v2
H�kan Waara (away 9/10 - 16/10) <hwaara@gmail.com> has cancelled Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 355894: Open file dialog doesn't allow me to open XUL documents https://bugzilla.mozilla.org/show_bug.cgi?id=355894 Attachment 241861: Fix v2 https://bugzilla.mozilla.org/attachment.cgi?id=241861&action=edit ------- Additional Comments from H�kan Waara (away 9/10 - 16/10) <hwaara@gmail.com> Checked in before I saw the sr-request (sorry!), but Josh says it's fine. ...

Web resources about - superreview granted: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143888] patch for callers, v2 - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 11/22/2015 5:43:22 AM