superreview granted: [Bug 50380] Proxy: Option to set all servers to the same hostname : [Attachment 135971] patch v3

Brian Ryner (away until Dec 30) <bryner@brianryner.com> has granted Jerry
<jerry.tan@sun.com>'s request for superreview:

Bug 50380: Proxy: Option to set all servers to the same hostname
http://bugzilla.mozilla.org/show_bug.cgi?id=50380

Attachment 135971: patch v3
http://bugzilla.mozilla.org/attachment.cgi?id=135971&action=edit
0
bugzilla
12/23/2003 5:42:40 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
299 Views

Similar Articles

[PageSpeed] 40

Reply:

Similar Artilces:

superreview requested: [Bug 50380] Proxy: Option to set all servers to the same hostname : [Attachment 135971] patch v3
Jerry <jerry.tan@sun.com> has asked Brian Ryner (away until Dec 30) <bryner@brianryner.com> for superreview: Bug 50380: Proxy: Option to set all servers to the same hostname http://bugzilla.mozilla.org/show_bug.cgi?id=50380 Attachment 135971: patch v3 http://bugzilla.mozilla.org/attachment.cgi?id=135971&action=edit ...

superreview granted: [Bug 259076] proxy mode setting in gnome-network-preferences is not treated well by Mozilla : [Attachment 160322] patch to extend gconf proxy settings
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Wolfgang Rosenauer <mozilla@rosenauer.org>'s request for superreview: Bug 259076: proxy mode setting in gnome-network-preferences is not treated well by Mozilla https://bugzilla.mozilla.org/show_bug.cgi?id=259076 Attachment 160322: patch to extend gconf proxy settings https://bugzilla.mozilla.org/attachment.cgi?id=160322&action=edit ...

superreview granted: [Bug 253234] [patch]No Option to set Junk Mail as Read : [Attachment 192062] patch v3
Jens Bannmann <jens.b@web.de> has granted Jens Bannmann <jens.b@web.de>'s request for superreview: Bug 253234: [patch]No Option to set Junk Mail as Read https://bugzilla.mozilla.org/show_bug.cgi?id=253234 Attachment 192062: patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=192062&action=edit ------- Additional Comments from Jens Bannmann <jens.b@web.de> I replaced analyzeMessageForJunk() with an object that keeps track of pending messages and implements the listener. That didn't shorten the code, but its workings should be far more obvious now. ...

superreview granted: [Bug 253234] [patch]No Option to set Junk Mail as Read : [Attachment 192063] patch v3.1
Jens Bannmann <jens.b@web.de> has granted Jens Bannmann <jens.b@web.de>'s request for superreview: Bug 253234: [patch]No Option to set Junk Mail as Read https://bugzilla.mozilla.org/show_bug.cgi?id=253234 Attachment 192063: patch v3.1 https://bugzilla.mozilla.org/attachment.cgi?id=192063&action=edit ------- Additional Comments from Jens Bannmann <jens.b@web.de> .... now without dump() statements. ...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for review
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 218487: updated patch ready for review https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> my one concern is about migration from the per-server prefs to the global prefs. What happens in that scenar...

superreview granted: [Bug 253008] Set network.proxy.share_proxy_settings if IE has a single proxy set up. : [Attachment 154306] patch
Darin Fisher (IBM) <darin@meer.net> has granted Darin Fisher (IBM) <darin@meer.net>'s request for superreview: Bug 253008: Set network.proxy.share_proxy_settings if IE has a single proxy set up. https://bugzilla.mozilla.org/show_bug.cgi?id=253008 Attachment 154306: patch https://bugzilla.mozilla.org/attachment.cgi?id=154306&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> sr=darin ...

superreview requested: [Bug 259076] proxy mode setting in gnome-network-preferences is not treated well by Mozilla : [Attachment 160322] patch to extend gconf proxy settings
Wolfgang Rosenauer <mozilla@rosenauer.org> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 259076: proxy mode setting in gnome-network-preferences is not treated well by Mozilla https://bugzilla.mozilla.org/show_bug.cgi?id=259076 Attachment 160322: patch to extend gconf proxy settings https://bugzilla.mozilla.org/attachment.cgi?id=160322&action=edit ...

superreview granted: [Bug 90263] New account wizard uses "server name" and "hostname" : [Attachment 106602] quick patch that changes hostname to server name
Scott MacGregor <mscott@mozilla.org> has granted Henrik Lynggaard Hansen <admin@mozillatranslator.org>'s request for superreview: Bug 90263: New account wizard uses "server name" and "hostname" http://bugzilla.mozilla.org/show_bug.cgi?id=90263 Attachment 106602: quick patch that changes hostname to server name http://bugzilla.mozilla.org/attachment.cgi?id=106602&action=edit ...

superreview granted: [Bug 253234] [patch]No Option to set Junk Mail as Read : [Attachment 190879] patch v2
Jens Bannmann <jens.b@web.de> has granted Jens Bannmann <jens.b@web.de>'s request for superreview: Bug 253234: [patch]No Option to set Junk Mail as Read https://bugzilla.mozilla.org/show_bug.cgi?id=253234 Attachment 190879: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=190879&action=edit ------- Additional Comments from Jens Bannmann <jens.b@web.de> Addressing review comments. Additionally, I added a comment explaining how analyzeMessageForJunk() works and how it's called, and changed some broken indentation. This patch was tested both wi...

superreview granted: [Bug 253234] [patch]No Option to set Junk Mail as Read : [Attachment 192118] backend patch
David Bienvenu <bienvenu@nventure.com> has granted Jens Bannmann <jens.b@web.de>'s request for superreview: Bug 253234: [patch]No Option to set Junk Mail as Read https://bugzilla.mozilla.org/show_bug.cgi?id=253234 Attachment 192118: backend patch https://bugzilla.mozilla.org/attachment.cgi?id=192118&action=edit ...

superreview granted: [Bug 320349] Crash on authentification to the proxy server (possibly MS ISA server) : [Attachment 207311] patch
Darin Fisher (on vacation 12/23 - 1/8) <darin@meer.net> has granted Gavin Sharp <gavin.sharp@gmail.com>'s request for superreview: Bug 320349: Crash on authentification to the proxy server (possibly MS ISA server) https://bugzilla.mozilla.org/show_bug.cgi?id=320349 Attachment 207311: patch https://bugzilla.mozilla.org/attachment.cgi?id=207311&action=edit ...

superreview granted: [Bug 290435] proxy settings are disabled after switching profiles : [Attachment 181939] fix a bug in the previous patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Boying Lu <brian.lu@sun.com>'s request for superreview: Bug 290435: proxy settings are disabled after switching profiles https://bugzilla.mozilla.org/show_bug.cgi?id=290435 Attachment 181939: fix a bug in the previous patch https://bugzilla.mozilla.org/attachment.cgi?id=181939&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Yes, but who will see the event first? ...

superreview granted: [Bug 416233] Add sanitize (clear private data) option for SeaMonkey : [Attachment 305769] patch v3.1: address comments from v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 416233: Add sanitize (clear private data) option for SeaMonkey https://bugzilla.mozilla.org/show_bug.cgi?id=3D416233 Attachment 305769: patch v3.1: address comments from v3 https://bugzilla.mozilla.org/attachment.cgi?id=3D305769&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Almost there, but I noticed some new nits... sr=3Dme with them fixed:=0D =0D >+# DEFINES for preprocessing=0D >+# once we support ...

superreview granted: [Bug 62836] Mozilla should be kinder to mail servers in the event of a failure (disconnects without sending QUIT to SMTP server) : [Attachment 246013] proposed patch
David Bienvenu <bienvenu@nventure.com> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 62836: Mozilla should be kinder to mail servers in the event of a failure (disconnects without sending QUIT to SMTP server) https://bugzilla.mozilla.org/show_bug.cgi?id=62836 Attachment 246013: proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=246013&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Thx, Christian, I'll land this patch, along with the handling of 502 return code. Hect...

Web resources about - superreview granted: [Bug 50380] Proxy: Option to set all servers to the same hostname : [Attachment 135971] patch v3 - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 11/23/2015 8:40:45 AM