superreview granted: [Bug 319854] Firefox crashes on redirect after Firefox-warning [@ DocumentViewerImpl::PermitUnload] : [Attachment 205701] not all nsIDocShellTreeItem's are nsIDocShell's

Johnny Stenback <jst@mozilla.org> has granted timeless (will be away 1/15-1/27)
<timeless@bemail.org>'s request for superreview:
Bug 319854: Firefox crashes on redirect after Firefox-warning [@
DocumentViewerImpl::PermitUnload]
https://bugzilla.mozilla.org/show_bug.cgi?id=319854

Attachment 205701: not all nsIDocShellTreeItem's are nsIDocShell's
https://bugzilla.mozilla.org/attachment.cgi?id=205701&action=edit

------- Additional Comments from Johnny Stenback <jst@mozilla.org>
r+sr=jst
0
bugzilla
1/12/2006 1:22:02 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
485 Views

Similar Articles

[PageSpeed] 5

Reply:

Similar Artilces:

superreview requested: [Bug 319854] Firefox crashes on redirect after Firefox-warning [@ DocumentViewerImpl::PermitUnload] : [Attachment 205701] not all nsIDocShellTreeItem's are nsIDocShell's
timeless@myrealbox.com <timeless@bemail.org> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 319854: Firefox crashes on redirect after Firefox-warning [@ DocumentViewerImpl::PermitUnload] https://bugzilla.mozilla.org/show_bug.cgi?id=319854 Attachment 205701: not all nsIDocShellTreeItem's are nsIDocShell's https://bugzilla.mozilla.org/attachment.cgi?id=205701&action=edit ------- Additional Comments from timeless@myrealbox.com <timeless@bemail.org> this is for non gecko core creatures, it shouldn't fix firefox, but it is broken: ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky. Land this either _really_ early in 1.8b2 or in 1.9a.... ...

superreview granted: [Bug 189307] typeahead initializes sound when it's uninitialized instead of if it's unitialized and there's a sound to play : [Attachment 135251] right
Robert O'Callahan <roc@ocallahan.org> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 189307: typeahead initializes sound when it's uninitialized instead of if it's unitialized and there's a sound to play http://bugzilla.mozilla.org/show_bug.cgi?id=189307 Attachment 135251: right http://bugzilla.mozilla.org/attachment.cgi?id=135251&action=edit ...

superreview granted: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293607] fix assert
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293607: fix assert https://bugzilla.mozilla.org/attachment.cgi?id=293607&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> Looks good. That said, s...

superreview granted: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293637] reflow captions with unconstrained height
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293637: reflow captions with unconstrained height https://bugzilla.mozilla.org/attachment.cgi?id=293637&action=edit ...

superreview granted: [Bug 287943] Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp : [Attachment 180579] patch v4: address biesi's review nits
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 287943: Rebrand bootstrap's Windows bits including nsNativeAppSupportWin.cpp https://bugzilla.mozilla.org/show_bug.cgi?id=287943 Attachment 180579: patch v4: address biesi's review nits https://bugzilla.mozilla.org/attachment.cgi?id=180579&action=edit ...

superreview granted: [Bug 157566] Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension : [Attachment 147290] trunk version of the fix with david's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 157566: Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension http://bugzilla.mozilla.org/show_bug.cgi?id=157566 Attachment 147290: trunk version of the fix with david's review comment http://bugzilla.mozilla.org/attachment.cgi?id=147290&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying over david's sr ...

superreview granted: [Bug 320914] Firefox crashed with gnopernicus magnifier [@ nsXULMenuitemAccessible::GetState] : [Attachment 206468] patch addressing Aaron's comment
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Ginn Chen <ginn.chen@sun.com>'s request for superreview: Bug 320914: Firefox crashed with gnopernicus magnifier [@ nsXULMenuitemAccessible::GetState] https://bugzilla.mozilla.org/show_bug.cgi?id=320914 Attachment 206468: patch addressing Aaron's comment https://bugzilla.mozilla.org/attachment.cgi?id=206468&action=edit ...

superreview granted: [Bug 246892] Firefox crash when this page is opened [@ nsXPCWrappedJSClass::GetInterfaceName ] shockwave plugin? : [Attachment 161226] Prevent nsXPCWrappedJSClass's from going aw
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 246892: Firefox crash when this page is opened [@ nsXPCWrappedJSClass::GetInterfaceName ] shockwave plugin? https://bugzilla.mozilla.org/show_bug.cgi?id=246892 Attachment 161226: Prevent nsXPCWrappedJSClass's from going away while its code is on the stack. https://bugzilla.mozilla.org/attachment.cgi?id=161226&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> So is the plugin really doing itself in, or ...

superreview granted: [Bug 238733] Components.classes['@mozilla.org/wallet/wallet-service;1'] has no properties in contentAreaClick.js : [Attachment 144811] don't call the function if it's going to fa
Boris Zbarsky <bzbarsky@mit.edu> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 238733: Components.classes['@mozilla.org/wallet/wallet-service;1'] has no properties in contentAreaClick.js https://bugzilla.mozilla.org/show_bug.cgi?id=238733 Attachment 144811: don't call the function if it's going to fail https://bugzilla.mozilla.org/attachment.cgi?id=144811&action=edit ...

superreview granted: [Bug 303521] !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" : [Attachment 191706] fix spelling
Johnny Stenback <jst@mozilla.org> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 303521: !!! Object's nsIClassInfo lies about it's interfaces!!! s.b. "its" https://bugzilla.mozilla.org/show_bug.cgi?id=303521 Attachment 191706: fix spelling https://bugzilla.mozilla.org/attachment.cgi?id=191706&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst either way... ...

superreview granted: [Bug 408792] Eliminate more QI' s from performance hotspots. : [Attachment 293639] Eliminate QI's that aren 't needed.
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Johnny Stenback (:jst) <jst@mozilla.org>'s request for superreview: Bug 408792: Eliminate more QI's from performance hotspots. https://bugzilla.mozilla.org/show_bug.cgi?id=408792 Attachment 293639: Eliminate QI's that aren't needed. https://bugzilla.mozilla.org/attachment.cgi?id=293639&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> sr=bzbarsky, with the comments expanded out. And please file a followup...

superreview granted: [Bug 307632] Can't extend Selection Class anymore with Firefox 1.5b1 : [Attachment 195818] Use the current inner scope when wrapping natives in an outer window's scope.
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 307632: Can't extend Selection Class anymore with Firefox 1.5b1 https://bugzilla.mozilla.org/show_bug.cgi?id=307632 Attachment 195818: Use the current inner scope when wrapping natives in an outer window's scope. https://bugzilla.mozilla.org/attachment.cgi?id=195818&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> sr=me ahead of mrbkap, he better not embarrass me ;-). /be ...

superreview granted: [Bug 171349] Mozilla Firefox Icon is Windowing System's Standard Icon (Taskbar & Upper Lefthand Corner of App) : [Attachment 180473] actual patch for win9x
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 171349: Mozilla Firefox Icon is Windowing System's Standard Icon (Taskbar & Upper Lefthand Corner of App) https://bugzilla.mozilla.org/show_bug.cgi?id=171349 Attachment 180473: actual patch for win9x https://bugzilla.mozilla.org/attachment.cgi?id=180473&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> I don't see what effect that should have, resources are...