superreview granted: [Bug 311503] Safe Mode UI: closing or cancelling the dialog should quit Firefox : [Attachment 198807] Add "cancel" button, rev. 1

Mike Connor <mconnor@mozilla.com> has granted Benjamin Smedberg  [:bs]
<benjamin@smedbergs.us>'s request for superreview:
Bug 311503: Safe Mode UI: closing or cancelling the dialog should quit Firefox
https://bugzilla.mozilla.org/show_bug.cgi?id=311503

Attachment 198807: Add "cancel" button, rev. 1
https://bugzilla.mozilla.org/attachment.cgi?id=198807&action=edit

------- Additional Comments from Mike Connor <mconnor@mozilla.com>
sure, that'll work
0
bugzilla
10/7/2005 4:31:50 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
380 Views

Similar Articles

[PageSpeed] 33

Reply:

Similar Artilces:

superreview requested: [Bug 311503] Safe Mode UI: closing or cancelling the dialog should quit Firefox : [Attachment 198807] Add "cancel" button, rev. 1
Benjamin Smedberg [:bs] <benjamin@smedbergs.us> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 311503: Safe Mode UI: closing or cancelling the dialog should quit Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=311503 Attachment 198807: Add "cancel" button, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=198807&action=edit ...

superreview granted: [Bug 340373] Escape key should cancel "send in Unicode (UTF-8)?" dialog : [Attachment 226042] use button 1 for cancel instead of button 2
David Bienvenu <bienvenu@nventure.com> has granted Gavin Sharp <gavin.sharp@gmail.com>'s request for superreview: Bug 340373: Escape key should cancel "send in Unicode (UTF-8)?" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=340373 Attachment 226042: use button 1 for cancel instead of button 2 https://bugzilla.mozilla.org/attachment.cgi?id=226042&action=edit ...

superreview cancelled: [Bug 303279] Safe Mode: Display trouble shooting wizard : [Attachment 192407] Use "special" localstore in safe mode, rev. 1
Darin Fisher <darin@meer.net> has cancelled Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us>'s request for superreview: Bug 303279: Safe Mode: Display trouble shooting wizard https://bugzilla.mozilla.org/show_bug.cgi?id=303279 Attachment 192407: Use "special" localstore in safe mode, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=192407&action=edit ...

superreview granted: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156227] use Grant/Cancel
Blake Ross <firefox@blakeross.com> has granted Steffen Wilberg <steffen.wilberg@web.de>'s request for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156227: use Grant/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156227&action=edit ...

superreview granted: [Bug 303279] Safe Mode: Display trouble shooting wizard : [Attachment 193816] Use "special" localstore in safe mode, rev. 1.1
Darin Fisher <darin@meer.net> has granted Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us>'s request for superreview: Bug 303279: Safe Mode: Display trouble shooting wizard https://bugzilla.mozilla.org/show_bug.cgi?id=303279 Attachment 193816: Use "special" localstore in safe mode, rev. 1.1 https://bugzilla.mozilla.org/attachment.cgi?id=193816&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> By the way, it's not clear to me why NS_LOCALSTORE_UNSAFE_FILE exists. Who is the consumer? s...

superreview requested: [Bug 340373] Escape key should cancel "send in Unicode (UTF-8)?" dialog : [Attachment 226042] use button 1 for cancel instead of button 2
Gavin Sharp <gavin.sharp@gmail.com> has asked for superreview: Bug 340373: Escape key should cancel "send in Unicode (UTF-8)?" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=340373 Attachment 226042: use button 1 for cancel instead of button 2 https://bugzilla.mozilla.org/attachment.cgi?id=226042&action=edit ------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com> commonDialog.js sets the cancel button to the button at index 1 in the button flags, so POS_1 should be used for the cancel button. The only implementation that I tested was the...

superreview requested: [Bug 340373] Escape key should cancel "send in Unicode (UTF-8)?" dialog : [Attachment 226042] use button 1 for cancel instead of button 2 #2
Gavin Sharp <gavin.sharp@gmail.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 340373: Escape key should cancel "send in Unicode (UTF-8)?" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=340373 Attachment 226042: use button 1 for cancel instead of button 2 https://bugzilla.mozilla.org/attachment.cgi?id=226042&action=edit ...

superreview granted: [Bug 257801] Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog : [Attachment 157725] Fix
David Bienvenu <bienvenu@nventure.com> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 257801: Pressing "Cancel" in the "Defer Account?" warning closes the "Advanced Account Settings" dialog http://bugzilla.mozilla.org/show_bug.cgi?id=257801 Attachment 157725: Fix http://bugzilla.mozilla.org/attachment.cgi?id=157725&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx. I'm in the middle of making changes to this code, but I don't think this wil...

superreview cancelled: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156223] use OK/Cancel
Steffen Wilberg <steffen.wilberg@web.de> has cancelled Steffen Wilberg <steffen.wilberg@web.de>'s request for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156223: use OK/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156223&action=edit ...

superreview requested: [Bug 253944] enablePrivilege dialog uses "Yes" and "No" as button labels : [Attachment 156227] use Grant/Cancel
Steffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 253944: enablePrivilege dialog uses "Yes" and "No" as button labels http://bugzilla.mozilla.org/show_bug.cgi?id=253944 Attachment 156227: use Grant/Cancel http://bugzilla.mozilla.org/attachment.cgi?id=156227&action=edit ------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de> Grant/Cancel is better indeed. ...

superreview cancelled: [Bug 199262] Swap "Mark" and "Junk" Buttons (so that "Next" and "Mark" buttons are next to each other) : [Attachment 118601] patch that swaps the "Mark" and "Junk" buttons
Adam Becevello <bugs@abecevello.imapmail.org> has cancelled Adam Becevello <bugs@abecevello.imapmail.org>'s request for superreview: Bug 199262: Swap "Mark" and "Junk" Buttons (so that "Next" and "Mark" buttons are next to each other) https://bugzilla.mozilla.org/show_bug.cgi?id=199262 Attachment 118601: patch that swaps the "Mark" and "Junk" buttons https://bugzilla.mozilla.org/attachment.cgi?id=118601&action=edit ------- Additional Comments from Adam Becevello <bugs@abecevello.imapmail.org> Remo...

superreview granted: [Bug 383545] "Are you sure you want to quit?" dialog dismissal button should read "Don't Quit" : [Attachment 294627] Don 't Quit, now with better caps
Mark Mentovai <mark@moxienet.com> has granted Chris Lawson (cl-bugs) <cl-bugs@chrislawson.net>'s request for superreview: Bug 383545: "Are you sure you want to quit?" dialog dismissal button should read "Don't Quit" https://bugzilla.mozilla.org/show_bug.cgi?id=383545 Attachment 294627: Don't Quit, now with better caps https://bugzilla.mozilla.org/attachment.cgi?id=294627&action=edit ...

superreview cancelled: [Bug 241181] inconsistent spelling of cancelled or canceled in Mozilla. : [Attachment 146719] Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Fi
Bruce Davidson <Bruce.Davidson@iplbath.com> has cancelled Bruce Davidson <Bruce.Davidson@iplbath.com>'s request for superreview: Bug 241181: inconsistent spelling of cancelled or canceled in Mozilla. http://bugzilla.mozilla.org/show_bug.cgi?id=241181 Attachment 146719: Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Firefox. http://bugzilla.mozilla.org/attachment.cgi?id=146719&action=edit ...

superreview requested: [Bug 303279] Safe Mode: Display trouble shooting wizard : [Attachment 193816] Use "special" localstore in safe mode, rev. 1.1
Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 303279: Safe Mode: Display trouble shooting wizard https://bugzilla.mozilla.org/show_bug.cgi?id=303279 Attachment 193816: Use "special" localstore in safe mode, rev. 1.1 https://bugzilla.mozilla.org/attachment.cgi?id=193816&action=edit ...

Web resources about - superreview granted: [Bug 311503] Safe Mode UI: closing or cancelling the dialog should quit Firefox : [Attachment 198807] Add "cancel" button, rev. 1 - netscape.mozilla.reviewers

Resources last updated: 11/30/2015 8:51:43 PM