superreview granted: [Bug 311269] Crash on my.yahoo.com when sending password request [@ nsSHEntry::ContentInserted] [@ nsSHEntry::DropPresentationState] [@ nsSHEntry::DocumentMutated] : [Attachment

Brian Ryner <bryner@brianryner.com> has granted Jonas Sicking
<bugmail@sicking.cc>'s request for superreview:
Bug 311269: Crash on my.yahoo.com when sending password request [@
nsSHEntry::ContentInserted] [@ nsSHEntry::DropPresentationState] [@
nsSHEntry::DocumentMutated]
https://bugzilla.mozilla.org/show_bug.cgi?id=311269

Attachment 198647: Set up mutation observer at right place
https://bugzilla.mozilla.org/attachment.cgi?id=198647&action=edit

------- Additional Comments from Brian Ryner <bryner@brianryner.com>
Would be nice if we could avoid the kungFuDeathGrip, but that's fairly
difficult when both the SHEntry and the ContentViewer are going to be
destroyed.
0
bugzilla
10/6/2005 9:29:13 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
379 Views

Similar Articles

[PageSpeed] 18

Reply:

Similar Artilces:

superreview requested: [Bug 311269] Crash on my.yahoo.com when sending password request [@ nsSHEntry::ContentInserted] [@ nsSHEntry::DropPresentationState] [@ nsSHEntry::DocumentMutated] : [Attachmen
Jonas Sicking <bugmail@sicking.cc> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 311269: Crash on my.yahoo.com when sending password request [@ nsSHEntry::ContentInserted] [@ nsSHEntry::DropPresentationState] [@ nsSHEntry::DocumentMutated] https://bugzilla.mozilla.org/show_bug.cgi?id=311269 Attachment 198647: Set up mutation observer at right place https://bugzilla.mozilla.org/attachment.cgi?id=198647&action=edit ------- Additional Comments from Jonas Sicking <bugmail@sicking.cc> I think we want this patch either way. Without it there is ...

superreview requested: [Bug 262183] FFTrunk and Trunk crash [@ nsSHEntry::GetChildAt] : [Attachment 160577] v1 patch
Darin Fisher (IBM) <darin@meer.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 262183: FFTrunk and Trunk crash [@ nsSHEntry::GetChildAt] https://bugzilla.mozilla.org/show_bug.cgi?id=262183 Attachment 160577: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=160577&action=edit ...

superreview granted: [Bug 262183] FFTrunk and Trunk crash [@ nsSHEntry::GetChildAt] : [Attachment 160577] v1 patch
Boris Zbarsky <bzbarsky@mit.edu> has granted Darin Fisher (IBM) <darin@meer.net>'s request for superreview: Bug 262183: FFTrunk and Trunk crash [@ nsSHEntry::GetChildAt] https://bugzilla.mozilla.org/show_bug.cgi?id=262183 Attachment 160577: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=160577&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Doh. I should have caught that... we have to have the holes because otherwise timing issues would screw up framesets. sr=bzbarsky ...

superreview requested: [Bug 247542] crash on loading ca.yahoo.finance.com and finance.yahoo.com : [Attachment 151177] patch (diff -w)
Mike Pinkerton <pinkerton@aol.net> has asked Simon Fraser <sfraser@aol.net> for superreview: Bug 247542: crash on loading ca.yahoo.finance.com and finance.yahoo.com http://bugzilla.mozilla.org/show_bug.cgi?id=247542 Attachment 151177: patch (diff -w) http://bugzilla.mozilla.org/attachment.cgi?id=151177&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> smfr? thoughts? ...

superreview granted: [Bug 247542] crash on loading ca.yahoo.finance.com and finance.yahoo.com : [Attachment 151177] patch (diff -w)
Simon Fraser <sfraser@aol.net> has granted Mike Pinkerton <pinkerton@aol.net>'s request for superreview: Bug 247542: crash on loading ca.yahoo.finance.com and finance.yahoo.com http://bugzilla.mozilla.org/show_bug.cgi?id=247542 Attachment 151177: patch (diff -w) http://bugzilla.mozilla.org/attachment.cgi?id=151177&action=edit ...

superreview requested: [Bug 392873] crash in nsExpirationTracker<nsSHEntry, 3>::RemoveObject
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 392873: crash in nsExpirationTracker<nsSHEntry,3>::RemoveObject https://bugzilla.mozilla.org/show_bug.cgi?id=392873 Attachment 285527: patch https://bugzilla.mozilla.org/attachment.cgi?id=285527&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> Crash early in release builds if a destroyed nsSHEntry is still in the tracker. I'm also moving gHistoryTracker->A...

superreview granted: [Bug 392873] crash in nsExpirationTracker<nsSHEntry,3> ::RemoveObject
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 392873: crash in nsExpirationTracker<nsSHEntry,3>::RemoveObject https://bugzilla.mozilla.org/show_bug.cgi?id=392873 Attachment 285547: updated patch https://bugzilla.mozilla.org/attachment.cgi?id=285547&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> Let's do it. ...

superreview granted: [Bug 392873] crash in nsExpirationTracker<nsSHEntry,3> ::RemoveObject #2
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 392873: crash in nsExpirationTracker<nsSHEntry,3>::RemoveObject https://bugzilla.mozilla.org/show_bug.cgi?id=392873 Attachment 288252: band-aid https://bugzilla.mozilla.org/attachment.cgi?id=288252&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> Let's hope Jesse hits those asserts... ...

superreview requested: [Bug 260314] UMR in nsSHEntry::SetLayoutHistoryState : [Attachment 159614] v1.1 patch
Darin Fisher (IBM) <darin@meer.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 260314: UMR in nsSHEntry::SetLayoutHistoryState https://bugzilla.mozilla.org/show_bug.cgi?id=260314 Attachment 159614: v1.1 patch https://bugzilla.mozilla.org/attachment.cgi?id=159614&action=edit ...

superreview granted: [Bug 260314] UMR in nsSHEntry::SetLayoutHistoryState : [Attachment 159614] v1.1 patch
Boris Zbarsky <bzbarsky@mit.edu> has granted Darin Fisher (IBM) <darin@meer.net>'s request for superreview: Bug 260314: UMR in nsSHEntry::SetLayoutHistoryState https://bugzilla.mozilla.org/show_bug.cgi?id=260314 Attachment 159614: v1.1 patch https://bugzilla.mozilla.org/attachment.cgi?id=159614&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: nsSHEntry.cpp >+ mLoadType = (PRInt32) nsIDocShellLoadInfo::loadHistory; The member is PRUint32, actually... sr=bzbarsky ...

superreview granted: [Bug 224337] Mozilla crashes viewing hectorplasmic.com : [Attachment 137343] a patch
Brendan Eich <brendan@mozilla.org> has granted Jungshik Shin <jshin@mailaps.org>'s request for superreview: Bug 224337: Mozilla crashes viewing hectorplasmic.com http://bugzilla.mozilla.org/show_bug.cgi?id=224337 Attachment 137343: a patch http://bugzilla.mozilla.org/attachment.cgi?id=137343&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> >+#define DEFINE_CCMAP(var, type) \ >+type static union { \ >+ PRUint16 array[var ## SIZE]; \ >+ ALU_TYPE align; \ >+} var ## Union = ...

superreview requested: [Bug 224337] Mozilla crashes viewing hectorplasmic.com : [Attachment 137343] a patch
Jungshik Shin <jshin@mailaps.org> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 224337: Mozilla crashes viewing hectorplasmic.com http://bugzilla.mozilla.org/show_bug.cgi?id=224337 Attachment 137343: a patch http://bugzilla.mozilla.org/attachment.cgi?id=137343&action=edit ------- Additional Comments from Jungshik Shin <jshin@mailaps.org> Thanks for the confirmation, Mitch and Brendan. BTW, an empty macro argument should be OK (as long as there's the first argument that is not empty), right? Asking for r/sr. I don't mind get...

superreview requested: [Bug 392873] crash in nsExpirationTracker<nsSHEntry, 3>::RemoveObject #3
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 392873: crash in nsExpirationTracker<nsSHEntry,3>::RemoveObject https://bugzilla.mozilla.org/show_bug.cgi?id=392873 Attachment 285547: updated patch https://bugzilla.mozilla.org/attachment.cgi?id=285547&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> More crash-early instrumentation to detect if AddObject being called when the entry is already in the tracker is the ...

superreview requested: [Bug 392873] crash in nsExpirationTracker<nsSHEntry, 3>::RemoveObject #2
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 392873: crash in nsExpirationTracker<nsSHEntry,3>::RemoveObject https://bugzilla.mozilla.org/show_bug.cgi?id=392873 Attachment 288252: band-aid https://bugzilla.mozilla.org/attachment.cgi?id=288252&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> I think we're violating this: nsSHEntry::SetContentViewer(nsIContentViewer *aViewer) { NS_PRECONDITION(!aViewer ...

Web resources about - superreview granted: [Bug 311269] Crash on my.yahoo.com when sending password request [@ nsSHEntry::ContentInserted] [@ nsSHEntry::DropPresentationState] [@ nsSHEntry::DocumentMutated] : [Attachment - netscape.mozilla.reviewers

Resources last updated: 12/15/2015 7:43:12 AM