superreview granted: [Bug 310351] Cannot convert NodeList to JS Array with Array.prototype.slice any more : [Attachment 198392] Because of this

Brendan Eich <brendan@mozilla.org> has granted Blake Kaplan
<mrbkap@gmail.com>'s request for superreview:
Bug 310351: Cannot convert NodeList to JS Array with Array.prototype.slice any
more
https://bugzilla.mozilla.org/show_bug.cgi?id=310351

Attachment 198392: Because of this
https://bugzilla.mozilla.org/attachment.cgi?id=198392&action=edit

------- Additional Comments from Brendan Eich <brendan@mozilla.org>
Great, thanks!

/be
0
bugzilla
10/4/2005 4:39:06 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
343 Views

Similar Articles

[PageSpeed] 48

Reply:

Similar Artilces:

superreview requested: [Bug 310351] Cannot convert NodeList to JS Array with Array.prototype.slice any more : [Attachment 198392] Because of this
Blake Kaplan <mrbkap@gmail.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 310351: Cannot convert NodeList to JS Array with Array.prototype.slice any more https://bugzilla.mozilla.org/show_bug.cgi?id=310351 Attachment 198392: Because of this https://bugzilla.mozilla.org/attachment.cgi?id=198392&action=edit ...

superreview granted: [Bug 323156] XPCDispConvert::JSArrayToCOMArray does not convert empty arrays correctly : [Attachment 208273] Patch accounting for empty JS array
Johnny Stenback <jst@mozilla.org> has granted Garrett Davis <gdavis@nsisoftware.com>'s request for superreview: Bug 323156: XPCDispConvert::JSArrayToCOMArray does not convert empty arrays correctly https://bugzilla.mozilla.org/show_bug.cgi?id=323156 Attachment 208273: Patch accounting for empty JS array https://bugzilla.mozilla.org/attachment.cgi?id=208273&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> sr=jst ...

superreview requested: [Bug 323156] XPCDispConvert::JSArrayToCOMArray does not convert empty arrays correctly : [Attachment 208273] Patch accounting for empty JS array
Garrett Davis <gdavis@nsisoftware.com> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 323156: XPCDispConvert::JSArrayToCOMArray does not convert empty arrays correctly https://bugzilla.mozilla.org/show_bug.cgi?id=323156 Attachment 208273: Patch accounting for empty JS array https://bugzilla.mozilla.org/attachment.cgi?id=208273&action=edit ...

superreview granted: [Bug 306664] Bump JS version to 1.6, for E4X + Array extra + Array/String generics : [Attachment 194991] correct patch
Mike Shaver <shaver@mozilla.org> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 306664: Bump JS version to 1.6, for E4X + Array extra + Array/String generics https://bugzilla.mozilla.org/show_bug.cgi?id=306664 Attachment 194991: correct patch https://bugzilla.mozilla.org/attachment.cgi?id=194991&action=edit ...

superreview granted: [Bug 431414] Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks : [Attachment 318566] Fix memory leaks
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 431414: Review MailNews uses of idl functions that return xpcom allocat= ed arrays [..., array, ...] for memory leaks https://bugzilla.mozilla.org/show_bug.cgi?id=3D431414 Attachment 318566: Fix memory leaks https://bugzilla.mozilla.org/attachment.cgi?id=3D318566&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ // Ensure any old data is freed if necessary.=0D >+ if (mSearchAttrs) {=0D ...

superreview granted: [Bug 431414] Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks : [Attachment 319371] Fix memory leaks v2
Mark Banner <bugzilla@standard8.plus.com> has granted superreview: Bug 431414: Review MailNews uses of idl functions that return xpcom allocated arrays [..., array, ...] for memory leaks https://bugzilla.mozilla.org/show_bug.cgi?id=431414 Attachment 319371: Fix memory leaks v2 https://bugzilla.mozilla.org/attachment.cgi?id=319371&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> Fixes Neil's comments, carrying forward his sr. ...

superreview granted: [Bug 309046] XMLRPC doesnt work if Array.prototype.[...] or String.prototype.[...] are set : [Attachment 196537] Fixes the problem
Johnny Stenback <jst@mozilla.org> has granted Christian Biesinger (:bi) (reviews slower than usual) <cbiesinger@gmx.at>'s request for superreview: Bug 309046: XMLRPC doesnt work if Array.prototype.[...] or String.prototype.[...] are set https://bugzilla.mozilla.org/show_bug.cgi?id=309046 Attachment 196537: Fixes the problem https://bugzilla.mozilla.org/attachment.cgi?id=196537&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> sr=jst with the additional change mentioned above. ...

superreview granted: [Bug 306788] Sorting array of arrays can crash due to GC : [Attachment 194628] fix
Mike Shaver <shaver@mozilla.org> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 306788: Sorting array of arrays can crash due to GC https://bugzilla.mozilla.org/show_bug.cgi?id=306788 Attachment 194628: fix https://bugzilla.mozilla.org/attachment.cgi?id=194628&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> sr=shaver ...

superreview granted: [Bug 308409] convert ParseTextShadow to nsCSSValue::Array and nsCSSValueList : [Attachment 196261] patch
David Baron <dbaron@mozillafoundation.org> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 308409: convert ParseTextShadow to nsCSSValue::Array and nsCSSValueList https://bugzilla.mozilla.org/show_bug.cgi?id=308409 Attachment 196261: patch https://bugzilla.mozilla.org/attachment.cgi?id=196261&action=edit ------- Additional Comments from David Baron <dbaron@mozillafoundation.org> >+ if (!atEOP && !expectEOP && ExpectSymbol(aErrorCode, ',', PR_TRUE)) { >+ // Parse next value >+ con...

superreview granted: [Bug 308409] convert ParseTextShadow to nsCSSValue::Array and nsCSSValueList : [Attachment 196715] final patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 308409: convert ParseTextShadow to nsCSSValue::Array and nsCSSValueList https://bugzilla.mozilla.org/show_bug.cgi?id=308409 Attachment 196715: final patch https://bugzilla.mozilla.org/attachment.cgi?id=196715&action=edit ------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at> (transferring r+sr=dbaron) also removes the now-unused expectEOP variable ...

superreview requested: [Bug 306664] Bump JS version to 1.6, for E4X + Array extra + Array/String generics : [Attachment 194989] proposed change
Brendan Eich <brendan@mozilla.org> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 306664: Bump JS version to 1.6, for E4X + Array extra + Array/String generics https://bugzilla.mozilla.org/show_bug.cgi?id=306664 Attachment 194989: proposed change https://bugzilla.mozilla.org/attachment.cgi?id=194989&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> The only way to implement this so that 1.6 => E4X is to make JS_HAS_XML_OPTION(cx) test both the JSVERSION_HAS_XML bit reflected from JS_SetOptions(cx, JSOPTION_XM...

superreview requested: [Bug 306664] Bump JS version to 1.6, for E4X + Array extra + Array/String generics : [Attachment 194991] correct patch
Brendan Eich <brendan@mozilla.org> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 306664: Bump JS version to 1.6, for E4X + Array extra + Array/String generics https://bugzilla.mozilla.org/show_bug.cgi?id=306664 Attachment 194991: correct patch https://bugzilla.mozilla.org/attachment.cgi?id=194991&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> This is straightforward, except that I made nsScriptLoader::EvaluateScript match nsXULPrototypeScript::Compile in clearing JSOPTION_XML if e4x=0 or no e4x param was giv...

superreview cancelled: [Bug 306664] Bump JS version to 1.6, for E4X + Array extra + Array/String generics : [Attachment 194989] proposed change
Brendan Eich <brendan@mozilla.org> has cancelled Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 306664: Bump JS version to 1.6, for E4X + Array extra + Array/String generics https://bugzilla.mozilla.org/show_bug.cgi?id=306664 Attachment 194989: proposed change https://bugzilla.mozilla.org/attachment.cgi?id=194989&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Oops, forgot to copy the working patch to my staging area... new patch in a minute. /be ...

superreview granted: [Bug 408295] avoid temporary arrays when cascading style rules : [Attachment 293048] use RuleValue's linked list instead of arrays while cascading
Jonas Sicking (:sicking) <jonas@sicking.cc> has granted David Baron [:dbaron] <dbaron@mozilla.com>'s request for superreview: Bug 408295: avoid temporary arrays when cascading style rules https://bugzilla.mozilla.org/show_bug.cgi?id=408295 Attachment 293048: use RuleValue's linked list instead of arrays while cascading https://bugzilla.mozilla.org/attachment.cgi?id=293048&action=edit ------- Additional Comments from Jonas Sicking (:sicking) <jonas@sicking.cc> Sweet! ...

Web resources about - superreview granted: [Bug 310351] Cannot convert NodeList to JS Array with Array.prototype.slice any more : [Attachment 198392] Because of this - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/13/2016 6:59:43 PM