superreview granted: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)

Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren
<mats.palmgren@bredband.net>'s request for superreview:
Bug 305705: Whitespace in <option> of <select> isn't selectable when width is
specified.
https://bugzilla.mozilla.org/show_bug.cgi?id=305705

Attachment 200452: Patch rev. 1 (diff -w)
https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
Looks reasonable.  Watch Tp carefully, though!
0
bugzilla
10/23/2005 7:25:29 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
653 Views

Similar Articles

[PageSpeed] 23

Reply:

Similar Artilces:

superreview granted: [Bug 185098] Font style ignored if <option selected="selected"> in a <select> that contains an optgroup : [Attachment 154999] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 185098: Font style ignored if <option selected="selected"> in a <select> that contains an optgroup http://bugzilla.mozilla.org/show_bug.cgi?id=185098 Attachment 154999: Patch rev. 1 http://bugzilla.mozilla.org/attachment.cgi?id=154999&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Yeah, this is reasonable. r+sr=bzbarsky. For future reference, using more context and the -p option makes the diff...

superreview granted: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: layout/forms/nsListControlFrame.cpp >+ nsIPresShell* shell = aPresContext->GetPresShell(); I thi...

superreview granted: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149416] Patch for 1.7 per roc
Robert O'Callahan <roc@ocallahan.org> has granted Doron Rosenberg (IBM) <doronr@us.ibm.com>'s request for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149416: Patch for 1.7 per roc - adding a if() check http://bugzilla.mozilla.org/attachment.cgi?id=149416&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> + if (mComboBoxFrame != nsnull) { should be + if (...

superreview requested: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> These two changes are not needed to fix this bug: Removed an unused parameter from GetMaxOptionHeight(). Make sure GetNum...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149416] Patch for 1.7 per roc
Doron Rosenberg (IBM) <doronr@us.ibm.com> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149416: Patch for 1.7 per roc - adding a if() check http://bugzilla.mozilla.org/attachment.cgi?id=149416&action=edit ...

superreview granted: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149404] Cleanup
Robert O'Callahan <roc@ocallahan.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149404: Cleanup http://bugzilla.mozilla.org/attachment.cgi?id=149404&action=edit ...

superreview granted: [Bug 112281] ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items : [Attachment 135533] Proposed patch
Robert O'Callahan <roc@ocallahan.org> has granted Boris Zbarsky (real world intrudes) <bz-vacation@mit.edu>'s request for superreview: Bug 112281: ctrl+shift+click whle making range selections in form <select> shouldn't wipe out other selected items http://bugzilla.mozilla.org/show_bug.cgi?id=112281 Attachment 135533: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=135533&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> looks quite straighforward :-) ...

superreview canceled: [Bug 382369] Cannot select text in <label> associated with a <select> : [Attachment 281681] Alternative patch, rev. 2
Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has canceled Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 382369: Cannot select text in <label> associated with a <select> https://bugzilla.mozilla.org/show_bug.cgi?id=382369 Attachment 281681: Alternative patch, rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=281681&action=edit ...

superreview granted: [Bug 283345] Description of Profile Manager's <dialogheader> isn't updated when switching from Select Profile to Manage Profile mode : [Attachment 175337] Patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Stefan Borggraefe <Stefan.Borggraefe@gmx.de>'s request for superreview: Bug 283345: Description of Profile Manager's <dialogheader> isn't updated when switching from Select Profile to Manage Profile mode https://bugzilla.mozilla.org/show_bug.cgi?id=283345 Attachment 175337: Patch https://bugzilla.mozilla.org/attachment.cgi?id=175337&action=edit ...

superreview granted: [Bug 333243] Options inside <optgroup>s in RTL <selects>s are not indented : [Attachment 217684] patch
David Baron <dbaron@mozilla.com> has granted Uri Bernstein <uriber@gmail.com>'s request for superreview: Bug 333243: Options inside <optgroup>s in RTL <selects>s are not indented https://bugzilla.mozilla.org/show_bug.cgi?id=333243 Attachment 217684: patch https://bugzilla.mozilla.org/attachment.cgi?id=217684&action=edit ...

superreview granted: [Bug 277724] [FIX]<select> and <textarea> don't restore disabled state : [Attachment 245370] Fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 277724: [FIX]<select> and <textarea> don't restore disabled state https://bugzilla.mozilla.org/show_bug.cgi?id=277724 Attachment 245370: Fix https://bugzilla.mozilla.org/attachment.cgi?id=245370&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> - In nsHTMLTextAreaElement::BeforeSetAttr(): + if (aNotify && aNameSpaceID == kNameSpaceID_None && + aName == nsHTMLAtoms::disabled) { +...

superreview granted: [Bug 289667] drag 'n drop of < map > links found in an < img > is broken : [Attachment 187358] Patch rev. 1
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 289667: drag 'n drop of < map > links found in an < img > is broken https://bugzilla.mozilla.org/show_bug.cgi?id=289667 Attachment 187358: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=187358&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> You certainly should be able to drag content without frames. But all this code is trying to do it turn off ...

superreview granted: [Bug 287990] <plaintext></plaintext>doesn't works well in Mozilla 1.8b1 as before : [Attachment 179355] brings back plaintext
David Baron <dbaron@mozillafoundation.org> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 287990: <plaintext></plaintext>doesn't works well in Mozilla 1.8b1 as before https://bugzilla.mozilla.org/show_bug.cgi?id=287990 Attachment 179355: brings back plaintext https://bugzilla.mozilla.org/attachment.cgi?id=179355&action=edit ------- Additional Comments from David Baron <dbaron@mozillafoundation.org> >-// Currently there are 107 HTML tags. eHTMLTag_text = 109. >+// Currently there are 108 HTML tags. eHTMLTag...

superreview granted: [Bug 269561] Dropup/dropdown boxes leave gray box visible after selection if <select> has height/width on Mac : [Attachment 171565] Don't set mVisible to true willy-nilly
Boris Zbarsky <bzbarsky@mit.edu> has granted Simon Fraser <sfraser_bugs@smfr.org>'s request for superreview: Bug 269561: Dropup/dropdown boxes leave gray box visible after selection if <select> has height/width on Mac https://bugzilla.mozilla.org/show_bug.cgi?id=269561 Attachment 171565: Don't set mVisible to true willy-nilly https://bugzilla.mozilla.org/attachment.cgi?id=171565&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky ...

superreview granted: [Bug 225840] '4 .xul files': Convert <window class="dialog"> to <dialog> ... additional cleanup : [Attachment 136423] <p3pDialog.xul> patch v1
Asa Dotzler <asa@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 225840: '4 .xul files': Convert <window class="dialog"> to <dialog> ... additional cleanup http://bugzilla.mozilla.org/show_bug.cgi?id=225840 Attachment 136423: <p3pDialog.xul> patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=136423&action=edit ------- Additional Comments from Asa Dotzler <asa@mozilla.org> r=ben a=asa (on behalf of drivers) for checkin to 1.6beta. ...

Web resources about - superreview granted: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w) - netscape.mozilla.reviewers

Resources last updated: 1/21/2016 1:52:49 PM