superreview granted: [Bug 303620] Focus rectangle drawn at <select> when focus is actually on <input> : [Attachment 192375] Very sensible change -- same exact thing for button, select, input and text

Brian Ryner <bryner@brianryner.com> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 303620: Focus rectangle drawn at <select> when focus is actually on <input>
https://bugzilla.mozilla.org/show_bug.cgi?id=303620

Attachment 192375: Very sensible change -- same exact thing for button, select,
input and textarea. Don't assume that focus stays what you set it to after a
SetContentState(NS_EVENT_STATE_FOCUS)
https://bugzilla.mozilla.org/attachment.cgi?id=192375&action=edit
0
bugzilla
8/11/2005 5:03:38 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
486 Views

Similar Articles

[PageSpeed] 30

Reply:

Similar Artilces:

superreview requested: [Bug 303620] Focus rectangle drawn at <select> when focus is actually on <input> : [Attachment 192375] Very sensible change -- same exact thing for button, select, input and te
Aaron Leventhal <aaronleventhal@moonset.net> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 303620: Focus rectangle drawn at <select> when focus is actually on <input> https://bugzilla.mozilla.org/show_bug.cgi?id=303620 Attachment 192375: Very sensible change -- same exact thing for button, select, input and textarea. Don't assume that focus stays what you set it to after a SetContentState(NS_EVENT_STATE_FOCUS) https://bugzilla.mozilla.org/attachment.cgi?id=192375&action=edit ------- Additional Comments from Aaron Leventhal <aa...

superreview granted: [Bug 303620] Focus rectangle drawn at <select> when focus is actually on <input> : [Attachment 193586] Correct patch (applies to trunk only)
Brian Ryner <bryner@brianryner.com> has granted Brian Ryner <bryner@brianryner.com>'s request for superreview: Bug 303620: Focus rectangle drawn at <select> when focus is actually on <input> https://bugzilla.mozilla.org/show_bug.cgi?id=303620 Attachment 193586: Correct patch (applies to trunk only) https://bugzilla.mozilla.org/attachment.cgi?id=193586&action=edit ------- Additional Comments from Brian Ryner <bryner@brianryner.com> >--- content/events/src/nsEventStateManager.h 16 Aug 2005 17:54:28 -0000 1.138 >+++ content/events/src/...

superreview cancelled: [Bug 303620] Focus rectangle drawn at <select> when focus is actually on <input> : [Attachment 193459] Handle last few cases, do it more conveniently via return value from SetC
Mats Palmgren <mats.palmgren@bredband.net> has cancelled Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 303620: Focus rectangle drawn at <select> when focus is actually on <input> https://bugzilla.mozilla.org/show_bug.cgi?id=303620 Attachment 193459: Handle last few cases, do it more conveniently via return value from SetContentState() https://bugzilla.mozilla.org/attachment.cgi?id=193459&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Index: content/events/public/nsIEventStat...

superreview requested: [Bug 303620] Focus rectangle drawn at <select> when focus is actually on <input> : [Attachment 193459] Handle last few cases, do it more conveniently via return value from SetC
Aaron Leventhal <aaronleventhal@moonset.net> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 303620: Focus rectangle drawn at <select> when focus is actually on <input> https://bugzilla.mozilla.org/show_bug.cgi?id=303620 Attachment 193459: Handle last few cases, do it more conveniently via return value from SetContentState() https://bugzilla.mozilla.org/attachment.cgi?id=193459&action=edit ...

superreview granted: [Bug 279496] can't copy or paste in <input> and <textarea> : [Attachment 172323] 1) Keep -moz-user-focus: ignore entries, they affect blur supression 2) Modify nsXULPopupListen
Boris Zbarsky <bzbarsky@mit.edu> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 279496: can't copy or paste in <input> and <textarea> https://bugzilla.mozilla.org/show_bug.cgi?id=279496 Attachment 172323: 1) Keep -moz-user-focus: ignore entries, they affect blur supression 2) Modify nsXULPopupListener to use isFocusable() https://bugzilla.mozilla.org/attachment.cgi?id=172323&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky ...

superreview granted: [Bug 340564] Print/Print Preview does not print text in <input text> or <textarea> : [Attachment 243735] Patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340564: Print/Print Preview does not print text in <input text> or <textarea> https://bugzilla.mozilla.org/show_bug.cgi?id=340564 Attachment 243735: Patch https://bugzilla.mozilla.org/attachment.cgi?id=243735&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> thanks! the new textframe kills all this horrible code. ...

superreview granted: [Bug 185098] Font style ignored if <option selected="selected"> in a <select> that contains an optgroup : [Attachment 154999] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 185098: Font style ignored if <option selected="selected"> in a <select> that contains an optgroup http://bugzilla.mozilla.org/show_bug.cgi?id=185098 Attachment 154999: Patch rev. 1 http://bugzilla.mozilla.org/attachment.cgi?id=154999&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Yeah, this is reasonable. r+sr=bzbarsky. For future reference, using more context and the -p option makes the diff...

superreview canceled: [Bug 382369] Cannot select text in <label> associated with a <select> : [Attachment 281681] Alternative patch, rev. 2
Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has canceled Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 382369: Cannot select text in <label> associated with a <select> https://bugzilla.mozilla.org/show_bug.cgi?id=382369 Attachment 281681: Alternative patch, rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=281681&action=edit ...

superreview granted: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Looks reasonable. Watch Tp carefully, though! ...

superreview cancelled: [Bug 244179] tabindex not honoured if form element is focused via <LABEL> : [Attachment 154764] In GetDocSelectionLocation, don't return selection in a <label> because we shoul
Aaron Leventhal <aaronleventhal@moonset.net> has cancelled Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 244179: tabindex not honoured if form element is focused via <LABEL> http://bugzilla.mozilla.org/show_bug.cgi?id=244179 Attachment 154764: In GetDocSelectionLocation, don't return selection in a <label> because we should tab relative to focus when selection is inside label http://bugzilla.mozilla.org/attachment.cgi?id=154764&action=edit ...

superreview requested: [Bug 244179] tabindex not honoured if form element is focused via <LABEL> : [Attachment 154764] In GetDocSelectionLocation, don't return selection in a <label> because we shoul
Aaron Leventhal <aaronleventhal@moonset.net> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 244179: tabindex not honoured if form element is focused via <LABEL> http://bugzilla.mozilla.org/show_bug.cgi?id=244179 Attachment 154764: In GetDocSelectionLocation, don't return selection in a <label> because we should tab relative to focus when selection is inside label http://bugzilla.mozilla.org/attachment.cgi?id=154764&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net> Neo, thanks for...

superreview granted: [Bug 370092] Focus change between onKeyDown and onKeyPress, allowing to read arbitary files using <input type=file> ( Zalewski Firefox focus stealing vulnerability)
Jonas Sicking <jonas@sicking.cc> has granted Smaug <Olli.Pettay@gmail.com>'s request for superreview: Bug 370092: Focus change between onKeyDown and onKeyPress, allowing to read arbitary files using <input type=file> (Zalewski Firefox focus stealing vulnerability) https://bugzilla.mozilla.org/show_bug.cgi?id=370092 Attachment 260832: v2 https://bugzilla.mozilla.org/attachment.cgi?id=260832&action=edit ...

superreview granted: [Bug 359496] focus outline on combobox <select>s is always drawn in black : [Attachment 244668] Patch rv1.0
David Baron <dbaron@mozilla.com> has granted Masayuki Nakano (Mozilla Japan)(sickness, working slowly) <masayuki@d-toybox.com>'s request for superreview: Bug 359496: focus outline on combobox <select>s is always drawn in black https://bugzilla.mozilla.org/show_bug.cgi?id=359496 Attachment 244668: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=244668&action=edit ...

superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149525] Work around focus issue
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Richard Suitor <rsuitor@acm.org> for superreview: Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected http://bugzilla.mozilla.org/show_bug.cgi?id=244761 Attachment 149525: Work around focus issue http://bugzilla.mozilla.org/attachment.cgi?id=149525&action=edit ...

Web resources about - superreview granted: [Bug 303620] Focus rectangle drawn at <select> when focus is actually on <input> : [Attachment 192375] Very sensible change -- same exact thing for button, select, input and text - netscape.mozilla.reviewers

Resources last updated: 12/8/2015 3:03:24 PM