superreview granted: [Bug 300027] [FIX]text document on Web sent as mail attachment has MIME type application/x-vnd.mozilla.maybe-text : [Attachment 188859] Patch to fix

Darin Fisher <darin@meer.net> has granted Boris Zbarsky <bzbarsky@mit.edu>'s
request for superreview:
Bug 300027: [FIX]text document on Web sent as mail attachment has MIME type
application/x-vnd.mozilla.maybe-text
https://bugzilla.mozilla.org/show_bug.cgi?id=300027

Attachment 188859: Patch to fix
https://bugzilla.mozilla.org/attachment.cgi?id=188859&action=edit

------- Additional Comments from Darin Fisher <darin@meer.net>
Looks good to me, sr=darin
0
bugzilla
7/12/2005 7:27:17 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
732 Views

Similar Articles

[PageSpeed] 37

Reply:

Similar Artilces:

superreview requested: [Bug 300027] text document on Web sent as mail attachment has MIME type application/x-vnd.mozilla.maybe-text : [Attachment 188859] Patch to fix
Boris Zbarsky <bzbarsky@mit.edu> has asked Darin Fisher <darin@meer.net> for superreview: Bug 300027: text document on Web sent as mail attachment has MIME type application/x-vnd.mozilla.maybe-text https://bugzilla.mozilla.org/show_bug.cgi?id=300027 Attachment 188859: Patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=188859&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> The problem is that mailnews uses an nsIURIContentListener that accepts all types... This patch fixes the problem (I had to deal with the magic "...

superreview requested: [Bug 241181] inconsistent spelling of cancelled or canceled in Mozilla. : [Attachment 146719] Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Fi
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Scott Collins <scc@mozilla.org> for superreview: Bug 241181: inconsistent spelling of cancelled or canceled in Mozilla. http://bugzilla.mozilla.org/show_bug.cgi?id=241181 Attachment 146719: Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Firefox. http://bugzilla.mozilla.org/attachment.cgi?id=146719&action=edit ------- Additional Comments from Bruce Davidson <Bruce.Davidson@iplbath.com> Requesting r/sr (rs=?) on this patch for 1.8 trunk. ...

superreview cancelled: [Bug 241181] inconsistent spelling of cancelled or canceled in Mozilla. : [Attachment 146719] Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Fi
Bruce Davidson <Bruce.Davidson@iplbath.com> has cancelled Bruce Davidson <Bruce.Davidson@iplbath.com>'s request for superreview: Bug 241181: inconsistent spelling of cancelled or canceled in Mozilla. http://bugzilla.mozilla.org/show_bug.cgi?id=241181 Attachment 146719: Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Firefox. http://bugzilla.mozilla.org/attachment.cgi?id=146719&action=edit ...

superreview granted: [Bug 155537] Text in multipart message does not show if Content-Type is blank [ Mail with attachments sent by Outlook don't work] : [Attachment 294768] proposed fix
David Bienvenu <bienvenu@nventure.com> has granted Magnus Melin <mkmelin+mozilla@iki.fi>'s request for superreview: Bug 155537: Text in multipart message does not show if Content-Type is blank [Mail with attachments sent by Outlook don't work] https://bugzilla.mozilla.org/show_bug.cgi?id=155537 Attachment 294768: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=294768&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> sr=bienvenu, except, instead of + if (!obj->content_type || strlen(obj->content_t...

superreview granted: [Bug 436869] non-standard MIME types, application/x-pkcs7-mime and application/x-pkcs7-signature
David Bienvenu <bienvenu@nventure.com> has granted Magnus Melin <mkmelin+mozilla@iki.fi>'s request for superreview: Bug 436869: non-standard MIME types, application/x-pkcs7-mime and application/x-pkcs7-signature - don't need the x- prefix https://bugzilla.mozilla.org/show_bug.cgi?id=436869 Attachment 327436: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=327436&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> thx, Magnus. ...

superreview granted: [Bug 295652] [FIX]document.open("text/html; charset=..") opens as text/plain : [Attachment 184658] Fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu>'s request for superreview: Bug 295652: [FIX]document.open("text/html; charset=..") opens as text/plain https://bugzilla.mozilla.org/show_bug.cgi?id=295652 Attachment 184658: Fix https://bugzilla.mozilla.org/attachment.cgi?id=184658&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview requested: [Bug 155537] Text in multipart message does not show if Content-Type is blank [ Mail with attachments sent by Outlook don't work] : [Attachment 294768] proposed fix
Magnus Melin <mkmelin+mozilla@iki.fi> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 155537: Text in multipart message does not show if Content-Type is blank [Mail with attachments sent by Outlook don't work] https://bugzilla.mozilla.org/show_bug.cgi?id=155537 Attachment 294768: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=294768&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> The problem was that when the header value is an empty string we iterate over to the next line and the value...

superreview granted: [Bug 220807] [FIX]Prompt user about invalid text/plain content
Darin Fisher <darin@meer.net> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 220807: [FIX]Prompt user about invalid text/plain content - solving most incorrect MIME type issues http://bugzilla.mozilla.org/show_bug.cgi?id=220807 Attachment 138491: Patch for trunk, updated to all comments http://bugzilla.mozilla.org/attachment.cgi?id=138491&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> >Index: netwerk/mime/public/nsMimeTypes.h >+#define APPLICATION_GUESS_TYPE_FROM_EXTENSION "applic...

superreview granted: [Bug 309761] [FIX]text-align: justify and text-decoration produces text with wrong underline : [Attachment 218056] Proposed patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 309761: [FIX]text-align: justify and text-decoration produces text with wrong underline https://bugzilla.mozilla.org/show_bug.cgi?id=309761 Attachment 218056: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=218056&action=edit ...

superreview requested: [Bug 436869] non-standard MIME types, application/x-pkcs7-mime and application/x-pkcs7-signature
Magnus Melin <mkmelin+mozilla@iki.fi> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 436869: non-standard MIME types, application/x-pkcs7-mime and application/x-pkcs7-signature - don't need the x- prefix https://bugzilla.mozilla.org/show_bug.cgi?id=436869 Attachment 327436: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=327436&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> Drops the x-prefixes for what we send out. ...

superreview granted: [Bug 233094] [FIX]input text doesn't appear in text box if text box is in floated cell : [Attachment 140654] This fixes all three testcases and the website
David Baron <dbaron@dbaron.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 233094: [FIX]input text doesn't appear in text box if text box is in floated cell http://bugzilla.mozilla.org/show_bug.cgi?id=233094 Attachment 140654: This fixes all three testcases and the website http://bugzilla.mozilla.org/attachment.cgi?id=140654&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> I'm not crazy about any of the table pseudo frame construction code, and I don't remember my previous objection ...

superreview granted: [Bug 384599] want pref to quote text attachment in reply : [Attachment 297599] Patch to make bug 161775 fix configurable
Dan Mosedale <dmose@mozilla.org> has granted rsx11m.pub@gmail.com's request for superreview: Bug 384599: want pref to quote text attachment in reply https://bugzilla.mozilla.org/show_bug.cgi?id=384599 Attachment 297599: Patch to make bug 161775 fix configurable https://bugzilla.mozilla.org/attachment.cgi?id=297599&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> steeve: good point, it might well be worth having UI of some sort to do that. Apparently Eudora Classic has it. File a spin-off bug? rsx11: indeed, I had misunderstood p...

superreview granted: [Bug 73409] document.open("text/plain") creates an html document instead of plain text. : [Attachment 148032] Fix
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 73409: document.open("text/plain") creates an html document instead of plain text. http://bugzilla.mozilla.org/show_bug.cgi?id=73409 Attachment 148032: Fix http://bugzilla.mozilla.org/attachment.cgi?id=148032&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> Very nice! I'd say we'd probably be better off special casing text/plain here and treating everything else as text/html (l...

superreview granted: [Bug 215798] Running Venkman crashes Mozilla [@ JS_GetPrivate ] : [Attachment 131582] patch to fix the GC safety bug, plus a few warning fixes
Johnny Stenback <jst@mozilla.jstenback.com> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 215798: Running Venkman crashes Mozilla [@ JS_GetPrivate ] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131582: patch to fix the GC safety bug, plus a few warning fixes http://bugzilla.mozilla.org/attachment.cgi?id=131582&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> I wasn't able to test this or run with it, but the change looks good. Hopefully someone else is able to ve...

Web resources about - superreview granted: [Bug 300027] [FIX]text document on Web sent as mail attachment has MIME type application/x-vnd.mozilla.maybe-text : [Attachment 188859] Patch to fix - netscape.mozilla.reviewers

Resources last updated: 12/4/2015 1:36:52 PM