superreview granted: [Bug 241209] "Show File Location" and "Launch File" buttons (on download progress dialog) don't work : [Attachment 147465] patchDarin Fisher (IBM) <darin@meer.net> has granted Christian Biesinger
<cbiesinger@gmx.at>'s request for superreview:
Bug 241209: "Show File Location" and "Launch File" buttons (on download
progress dialog) don't work
http://bugzilla.mozilla.org/show_bug.cgi?id=241209
Attachment 147465: patch
http://bugzilla.mozilla.org/attachment.cgi?id=147465&action=edit
------- Additional Comments from Darin Fisher (IBM) <darin@meer.net>
sr=darin
...
superreview granted: [Bug 343762] Zoom All zooms downloads window (even when it's not visible) : [Attachment 228390] Don't Zoom Downloads SolutionMike Pinkerton <mikepinkerton@mac.com> has granted froodiantherapy
<stridey@gmail.com>'s request for superreview:
Bug 343762: Zoom All zooms downloads window (even when it's not visible)
https://bugzilla.mozilla.org/show_bug.cgi?id=343762
Attachment 228390: Don't Zoom Downloads Solution
https://bugzilla.mozilla.org/attachment.cgi?id=228390&action=edit
------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com>
sr=pink
...
superreview granted: [Bug 412360] Download Manager remains empty, downloads don't start, with this 3.0b2 downloads.sqlite : [Attachment 306041] v1Christian :Biesinger <cbiesinger@gmail.com> has granted Edward Lee (Mardak)
<edilee@gmail.com>'s request for superreview:
Bug 412360: Download Manager remains empty, downloads don't start, with this
3.0b2 downloads.sqlite
https://bugzilla.mozilla.org/show_bug.cgi?id=3D412360
Attachment 306041: v1
https://bugzilla.mozilla.org/attachment.cgi?id=3D306041&action=3Dedit
------- Additional Comments from Christian :Biesinger <cbiesinger@gmail.com>
+ SendErrorStatusChange(PR_TRUE, rv, nsnull, aFile);=0D
=0D
hmm... why not pass the channel here instead o...
superreview granted: [Bug 355222] Some downloads can fail when using 'Always ask me where to save files' NS_ERROR_FAILURE @ nsIFilePicker.init Line 148 : [Attachment 241057] patchDarin Fisher (Google) <darin@meer.net> has granted Gavin Sharp
<gavin.sharp@gmail.com>'s request for superreview:
Bug 355222: Some downloads can fail when using 'Always ask me where to save
files' NS_ERROR_FAILURE @ nsIFilePicker.init Line 148
https://bugzilla.mozilla.org/show_bug.cgi?id=355222
Attachment 241057: patch
https://bugzilla.mozilla.org/attachment.cgi?id=241057&action=edit
...
superreview requested: [Bug 241209] "Show File Location" and "Launch File" buttons (on download progress dialog) don't work : [Attachment 147465] patchChristian Biesinger <cbiesinger@gmx.at> has asked Darin Fisher (IBM)
<darin@meer.net> for superreview:
Bug 241209: "Show File Location" and "Launch File" buttons (on download
progress dialog) don't work
http://bugzilla.mozilla.org/show_bug.cgi?id=241209
Attachment 147465: patch
http://bugzilla.mozilla.org/attachment.cgi?id=147465&action=edit
...
superreview requested: [Bug 343762] Zoom All zooms downloads window (even when it's not visible) : [Attachment 228390] Don't Zoom Downloads Solutionfroodiantherapy <stridey@gmail.com> has asked Mike Pinkerton
<mikepinkerton@mac.com> for superreview:
Bug 343762: Zoom All zooms downloads window (even when it's not visible)
https://bugzilla.mozilla.org/show_bug.cgi?id=343762
Attachment 228390: Don't Zoom Downloads Solution
https://bugzilla.mozilla.org/attachment.cgi?id=228390&action=edit
...
superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviewsMarria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s
request for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 227973: tweaks in response to reviews
https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit
------- Additional Comments from Marria Nazif <marria@gmail.com>
Actually, I'm going to go ahead and check this in on the trunk, since thes...
superreview granted: [Bug 342321] nsIncrementalDownload doesn't create 0-sized file when downloading a 0-sized file : [Attachment 226514] Always create/truncate the dest. file during the channel's onSDarin Fisher (Google) <darin@meer.net> has granted Jeff Walden (remove +bmo to
email) <jwalden+bmo@mit.edu>'s request for superreview:
Bug 342321: nsIncrementalDownload doesn't create 0-sized file when downloading
a 0-sized file
https://bugzilla.mozilla.org/show_bug.cgi?id=342321
Attachment 226514: Always create/truncate the dest. file during the channel's
onStartRequest
https://bugzilla.mozilla.org/attachment.cgi?id=226514&action=edit
...
superreview canceled: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882Zack Weinberg <zweinberg@mozilla.com> has canceled Zack Weinberg
<zweinberg@mozilla.com>'s request for superreview:
Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work
https://bugzilla.mozilla.org/show_bug.cgi?id=93725
Attachment 323226: possible patch for this and #77882
https://bugzilla.mozilla.org/attachment.cgi?id=323226&action=edit
------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com>
retracting review request.
...
superreview granted: [Bug 298737] newsgroups periodically lose unread count for messages whose headers haven't been downloaded : [Attachment 249378] adjust unread counts for message headers we don't hScott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 298737: newsgroups periodically lose unread count for messages whose
headers haven't been downloaded
https://bugzilla.mozilla.org/show_bug.cgi?id=298737
Attachment 249378: adjust unread counts for message headers we don't have, but
just once for any given header
https://bugzilla.mozilla.org/attachment.cgi?id=249378&action=edit
...
superreview granted: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patchneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Frank
Wein <bugzilla@mcsmurf.de>'s request for superreview:
Bug 290788: crash when try to 'save all' Attachments from MailNews 'File'
'Attachments' Menu [@ nsMessenger::SaveAllAttachments]
https://bugzilla.mozilla.org/show_bug.cgi?id=290788
Attachment 181152: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit
------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
D'oh! ;-)
...
superreview granted: [Bug 341436] ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 : [Attachment 225493] Don't pass nullneil@parkwaycc.co.uk <neil@httl.net> has granted Alex Vincent
<ajvincent@gmail.com>'s request for superreview:
Bug 341436: ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file
c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978
https://bugzilla.mozilla.org/show_bug.cgi?id=341436
Attachment 225493: Don't pass null in.
https://bugzilla.mozilla.org/attachment.cgi?id=225493&action=edit
------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
Nit: adding a blank line after the return would make the code look nicer...
superreview granted: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's reDarin Fisher (Google) <darin@meer.net> has granted Marria Nazif
<marria@gmail.com>'s request for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 227564: fixes in response to Darin's review
https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit
------- Additional Comments from Darin Fisher (Google) <darin@meer.net>
>Index: docshell/base/nsDocShell.cpp
> if (!r...
superreview granted: [Bug 224449] Clicking Cancel doesn't close download window : [Attachment 134770] bz's fixDarin Fisher <darin@meer.net> has granted Darin Fisher <darin@meer.net>'s
request for superreview:
Bug 224449: Clicking Cancel doesn't close download window
http://bugzilla.mozilla.org/show_bug.cgi?id=224449
Attachment 134770: bz's fix
http://bugzilla.mozilla.org/attachment.cgi?id=134770&action=edit
------- Additional Comments from Darin Fisher <darin@meer.net>
sr=darin
biesi: isn't it fun how folks depend on undocumented implementation behavior of
nsIRequest :-/
in this case, i imagine it's just coincidence.
...