superreview granted: [Bug 296083] [FIX]{ib} Counter weirdness in block-in-inline situations : [Attachment 188233] Proposed fix

David Baron <dbaron@mozillafoundation.org> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 296083: [FIX]{ib} Counter weirdness in block-in-inline situations
https://bugzilla.mozilla.org/show_bug.cgi?id=296083

Attachment 188233: Proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=188233&action=edit

------- Additional Comments from David Baron <dbaron@mozillafoundation.org>
r+sr=dbaron, but in the long run I'd like to actually make this use
next/prev-in-flow linkage, and have a bit that indicates that the flow is
fixed.	This could solve a bunch of problems related to block-within-inline,
bidi continuations (nextBidi property), and :first-letter.
0
bugzilla
7/6/2005 11:54:20 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
330 Views

Similar Articles

[PageSpeed] 47

Reply:

Similar Artilces:

superreview requested: [Bug 296083] {ib} Counter weirdness in block-in-inline situations : [Attachment 188233] Proposed fix
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozillafoundation.org> for superreview: Bug 296083: {ib} Counter weirdness in block-in-inline situations https://bugzilla.mozilla.org/show_bug.cgi?id=296083 Attachment 188233: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=188233&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This is a bit of a hack, but I don't see a safe better way -- we need to init the frames before we start setting them special, so InitAndRestoreFrame has no obvious way to know ...

superreview granted: [Bug 245066] [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) : [Attachment 156344] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 245066: [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) http://bugzilla.mozilla.org/show_bug.cgi?id=245066 Attachment 156344: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=156344&action=edit ...

superreview granted: [Bug 285981] [FIX]No alt text displayed with broken (security-blocked) image : [Attachment 178630] Proposed fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 285981: [FIX]No alt text displayed with broken (security-blocked) image https://bugzilla.mozilla.org/show_bug.cgi?id=285981 Attachment 178630: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=178630&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> sr=jst ...

superreview granted: [Bug 231814] Mozilla blocks and hangs during message download : [Attachment 139669] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 231814: Mozilla blocks and hangs during message download http://bugzilla.mozilla.org/show_bug.cgi?id=231814 Attachment 139669: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=139669&action=edit ...

superreview granted: [Bug 253195] Fix a couple of subtle block reflow bugs : [Attachment 154425] fix
David Baron <dbaron@dbaron.org> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 253195: Fix a couple of subtle block reflow bugs http://bugzilla.mozilla.org/show_bug.cgi?id=253195 Attachment 154425: fix http://bugzilla.mozilla.org/attachment.cgi?id=154425&action=edit ...

superreview granted: [Bug 311615] [FIX]Fix for bug 286491 was a little too aggressive : [Attachment 198878] Proposed patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 311615: [FIX]Fix for bug 286491 was a little too aggressive https://bugzilla.mozilla.org/show_bug.cgi?id=311615 Attachment 198878: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=198878&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> okay. And I see that in the other case --- inline changing to block --- the ContentInserted call will reframe the containing block. You mig...

superreview granted: [Bug 354600] [FIX]Blocks whose parents are not blocks should have SPACE_MGR and MARGIN_ROOT flags set : [Attachment 245729] Fix
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 354600: [FIX]Blocks whose parents are not blocks should have SPACE_MGR and MARGIN_ROOT flags set https://bugzilla.mozilla.org/show_bug.cgi?id=354600 Attachment 245729: Fix https://bugzilla.mozilla.org/attachment.cgi?id=245729&action=edit ...

superreview granted: [Bug 359392] [FIX]Very slow rendering of the top bar on mozilla.org : [Attachment 246930] Fix one more arithmetic bug
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 359392: [FIX]Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246930: Fix one more arithmetic bug https://bugzilla.mozilla.org/attachment.cgi?id=246930&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Would be nice to have this in cairo as well. Someone else's problem I guess. ...

superreview granted: [Bug 215798] Running Venkman crashes Mozilla [@ JS_GetPrivate ] : [Attachment 131582] patch to fix the GC safety bug, plus a few warning fixes
Johnny Stenback <jst@mozilla.jstenback.com> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 215798: Running Venkman crashes Mozilla [@ JS_GetPrivate ] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131582: patch to fix the GC safety bug, plus a few warning fixes http://bugzilla.mozilla.org/attachment.cgi?id=131582&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> I wasn't able to test this or run with it, but the change looks good. Hopefully someone else is able to ve...

superreview granted: [Bug 182627] Message body is not displayed for some messages if view attachments inline is false : [Attachment 206280] proposed fix
Scott MacGregor (out of town December 10th-17th) <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 182627: Message body is not displayed for some messages if view attachments inline is false https://bugzilla.mozilla.org/show_bug.cgi?id=182627 Attachment 206280: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=206280&action=edit ...

superreview requested: [Bug 245066] [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) : [Attachment 156344] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 245066: [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) http://bugzilla.mozilla.org/show_bug.cgi?id=245066 Attachment 156344: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=156344&action=edit ...

superreview granted: [Bug 300027] [FIX]text document on Web sent as mail attachment has MIME type application/x-vnd.mozilla.maybe-text : [Attachment 188859] Patch to fix
Darin Fisher <darin@meer.net> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 300027: [FIX]text document on Web sent as mail attachment has MIME type application/x-vnd.mozilla.maybe-text https://bugzilla.mozilla.org/show_bug.cgi?id=300027 Attachment 188859: Patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=188859&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> Looks good to me, sr=darin ...

superreview requested: [Bug 241181] inconsistent spelling of cancelled or canceled in Mozilla. : [Attachment 146719] Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Fi
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Scott Collins <scc@mozilla.org> for superreview: Bug 241181: inconsistent spelling of cancelled or canceled in Mozilla. http://bugzilla.mozilla.org/show_bug.cgi?id=241181 Attachment 146719: Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Firefox. http://bugzilla.mozilla.org/attachment.cgi?id=146719&action=edit ------- Additional Comments from Bruce Davidson <Bruce.Davidson@iplbath.com> Requesting r/sr (rs=?) on this patch for 1.8 trunk. ...

superreview cancelled: [Bug 241181] inconsistent spelling of cancelled or canceled in Mozilla. : [Attachment 146719] Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Fi
Bruce Davidson <Bruce.Davidson@iplbath.com> has cancelled Bruce Davidson <Bruce.Davidson@iplbath.com>'s request for superreview: Bug 241181: inconsistent spelling of cancelled or canceled in Mozilla. http://bugzilla.mozilla.org/show_bug.cgi?id=241181 Attachment 146719: Proposed patch to fix use of "canceled" in user-visible text. Fixes Mozilla and Firefox. http://bugzilla.mozilla.org/attachment.cgi?id=146719&action=edit ...

Web resources about - superreview granted: [Bug 296083] [FIX]{ib} Counter weirdness in block-in-inline situations : [Attachment 188233] Proposed fix - netscape.mozilla.reviewers

Resources last updated: 12/2/2015 10:42:37 PM